Merge pull request #7248 from Ultimaker/CURA-7211_fix_unselected_pos_settings

Fix two if statements which caused POS settings to be unselectable
This commit is contained in:
konskarm 2020-03-09 11:49:02 +01:00 committed by GitHub
commit 9dec4bc178
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -71,7 +71,7 @@ class PerObjectSettingVisibilityHandler(UM.Settings.Models.SettingVisibilityHand
# Add all instances that are not added, but are in visibility list # Add all instances that are not added, but are in visibility list
for item in visible: for item in visible:
if settings.getInstance(item) is not None: # Setting was not added already. if settings.getInstance(item) is None: # Setting was not added already.
definition = self._stack.getSettingDefinition(item) definition = self._stack.getSettingDefinition(item)
if definition: if definition:
new_instance = SettingInstance(definition, settings) new_instance = SettingInstance(definition, settings)

View File

@ -97,7 +97,7 @@ class PerObjectSettingsTool(Tool):
for property_key in ["top_bottom_thickness", "wall_thickness"]: for property_key in ["top_bottom_thickness", "wall_thickness"]:
if mesh_type == "infill_mesh": if mesh_type == "infill_mesh":
if not settings.getInstance(property_key): if settings.getInstance(property_key) is None:
definition = stack.getSettingDefinition(property_key) definition = stack.getSettingDefinition(property_key)
new_instance = SettingInstance(definition, settings) new_instance = SettingInstance(definition, settings)
new_instance.setProperty("value", 0) new_instance.setProperty("value", 0)