From 9fe261ff58742726e984e7af07669c2f5f880ee2 Mon Sep 17 00:00:00 2001
From: Remco Burema <41987080+rburema@users.noreply.github.com>
Date: Fri, 2 Dec 2022 19:07:41 +0100
Subject: [PATCH] Apply suggestions from code review.

part of CURA-9347

Co-authored-by: Joey de l'Arago <joeydelarago@gmail.com>
---
 resources/qml/Dialogs/DiscardOrKeepProfileChangesDialog.qml  | 4 ++--
 resources/qml/Dialogs/RenameDialog.qml                       | 3 +--
 resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml | 4 ++--
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/resources/qml/Dialogs/DiscardOrKeepProfileChangesDialog.qml b/resources/qml/Dialogs/DiscardOrKeepProfileChangesDialog.qml
index ea2a690321..1876f926a7 100644
--- a/resources/qml/Dialogs/DiscardOrKeepProfileChangesDialog.qml
+++ b/resources/qml/Dialogs/DiscardOrKeepProfileChangesDialog.qml
@@ -178,15 +178,15 @@ UM.Dialog
         {
             id: overwriteButton
             text: catalog.i18nc("@action:button", "Save as new custom profile")
-            onClicked: base.accept()
             visible: alternateStates.state != ""
+            onClicked: base.accept()
         },
         Cura.PrimaryButton
         {
             id: saveButton
             text: catalog.i18nc("@action:button", "Save changes")
-            onClicked: base.reject()
             visible: alternateStates.state == "saveFromCustom"
+            onClicked: base.reject()
         }
     ]
 }
diff --git a/resources/qml/Dialogs/RenameDialog.qml b/resources/qml/Dialogs/RenameDialog.qml
index 1b3fd7f8e8..eae3bff098 100644
--- a/resources/qml/Dialogs/RenameDialog.qml
+++ b/resources/qml/Dialogs/RenameDialog.qml
@@ -67,9 +67,8 @@ UM.Dialog
         }
 
         // spacer
-        Rectangle
+        Item
         {
-            color: base.backgroundColor
             height: UM.Theme.getSize("wide_margin").height
             width: height
         }
diff --git a/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml b/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
index 4453e0666c..5742e12a3c 100644
--- a/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
+++ b/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
@@ -155,9 +155,9 @@ Item
         ProfileWarningReset
         {
             id: profileWarningReset
-            fullWarning: false
-            anchors.right: parent.right
             width: childrenRect.width
+            anchors.right: parent.right
+            fullWarning: false
         }
 
         QualitiesWithIntentMenu