GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-08-14 20:55:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix margins for OnboardBanner

Browse Source 
Re-usable components shouldn't really be setting layout themselves.
This should be done by whomever creates them.

The actual fix is that the banner no longe sets all margins, only left & right

CURA-8726
This commit is contained in:
Jaime van Kessel 2022-02-22 15:44:30 +01:00
parent 0b39fb1c91
commit a05650f64c
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/Marketplace/resources/qml/Marketplace.qml
View File

@ -92,6 +92,10 @@ Window
icon: content.item && content.item.bannerIcon icon: content.item && content.item.bannerIcon
onRemove: content.item && content.item.onRemoveBanner onRemove: content.item && content.item.onRemoveBanner
readMoreUrl: content.item && content.item.bannerReadMoreUrl readMoreUrl: content.item && content.item.bannerReadMoreUrl
Layout.fillWidth: true
Layout.leftMargin: UM.Theme.getSize("default_margin").width
Layout.rightMargin: UM.Theme.getSize("default_margin").width
} }
// Search & Top-Level Tabs // Search & Top-Level Tabs

5
plugins/Marketplace/resources/qml/OnboardBanner.qml
View File

@ -16,10 +16,7 @@ Rectangle
property var onRemove property var onRemove
property string readMoreUrl property string readMoreUrl
Layout.preferredHeight: childrenRect.height + 2 * UM.Theme.getSize("default_margin").height implicitHeight: childrenRect.height + 2 * UM.Theme.getSize("default_margin").height
Layout.fillWidth: true
Layout.margins: UM.Theme.getSize("default_margin").width
color: UM.Theme.getColor("action_panel_secondary") color: UM.Theme.getColor("action_panel_secondary")
// Icon // Icon