From 76075c53cf3f8f1f6e202c7ed0b43944f5a0777a Mon Sep 17 00:00:00 2001 From: TotalRetribution Date: Thu, 15 Sep 2016 14:04:26 +0100 Subject: [PATCH 1/6] Added setting outer_inset_first to experimental category in fdmprinter.def.json --- resources/definitions/fdmprinter.def.json | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index eae6593fb8..b565e6a504 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -3774,6 +3774,16 @@ } } }, + "outer_inset_first": + { + "label": "Print Outer Inset First", + "description": "Prints insets in order of outside to inside when selected. This can help improve dimensional accuracy in x and y when using a high viscosity plastic like ABS however it can decrease outer surface print quality, especially overhangs.", + "type": "bool", + "default_value": false, + "settable_per_mesh": false, + "settable_per_extruder": false, + "settable_per_meshgroup": false + }, "wireframe_enabled": { "label": "Wire Printing", From 54e8f343119fcb7fd4c614a3d613b29f3328b2b4 Mon Sep 17 00:00:00 2001 From: TotalRetribution Date: Fri, 16 Sep 2016 09:57:39 +0100 Subject: [PATCH 2/6] Moved outer_inset_first setting in fdmprinter.def.json to the shell category just above Alternate Extra Wall as per BagelOrb suggestion. --- resources/definitions/fdmprinter.def.json | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index b565e6a504..3e2a5eab26 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -816,6 +816,15 @@ "minimum_value_warning": "0", "maximum_value_warning": "machine_nozzle_size", "settable_per_mesh": true + },"outer_inset_first": + { + "label": "Print Outer Inset First", + "description": "Prints insets in order of outside to inside when selected. This can help improve dimensional accuracy in x and y when using a high viscosity plastic like ABS however it can decrease outer surface print quality, especially overhangs.", + "type": "bool", + "default_value": false, + "settable_per_mesh": false, + "settable_per_extruder": false, + "settable_per_meshgroup": false }, "alternate_extra_perimeter": { @@ -3774,16 +3783,6 @@ } } }, - "outer_inset_first": - { - "label": "Print Outer Inset First", - "description": "Prints insets in order of outside to inside when selected. This can help improve dimensional accuracy in x and y when using a high viscosity plastic like ABS however it can decrease outer surface print quality, especially overhangs.", - "type": "bool", - "default_value": false, - "settable_per_mesh": false, - "settable_per_extruder": false, - "settable_per_meshgroup": false - }, "wireframe_enabled": { "label": "Wire Printing", From 6e041af2b199a3a3b663721e63fc863522843840 Mon Sep 17 00:00:00 2001 From: TotalRetribution Date: Fri, 16 Sep 2016 15:40:45 +0100 Subject: [PATCH 3/6] Fixed some Grammer mistakes and changed settable_per_mesh to true. --- resources/definitions/fdmprinter.def.json | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 3e2a5eab26..94dbe71312 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -816,15 +816,14 @@ "minimum_value_warning": "0", "maximum_value_warning": "machine_nozzle_size", "settable_per_mesh": true - },"outer_inset_first": + }, + "outer_inset_first": { - "label": "Print Outer Inset First", - "description": "Prints insets in order of outside to inside when selected. This can help improve dimensional accuracy in x and y when using a high viscosity plastic like ABS however it can decrease outer surface print quality, especially overhangs.", + "label": "Print Outer Wall Before Inner Walls", + "description": "Prints insets in order of outside to inside when enabled. This can help improve dimensional accuracy in X and Y when using a high viscosity plastic like ABS; however it can decrease outer surface print quality, especially on overhangs.", "type": "bool", "default_value": false, - "settable_per_mesh": false, - "settable_per_extruder": false, - "settable_per_meshgroup": false + "settable_per_mesh": true, }, "alternate_extra_perimeter": { From 5c75b5f3703443c14c3fe4af8085160453061af8 Mon Sep 17 00:00:00 2001 From: TotalRetribution Date: Fri, 16 Sep 2016 15:44:25 +0100 Subject: [PATCH 4/6] Removed Print from outer_inset_first Label name. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 94dbe71312..a96dcca2be 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -819,7 +819,7 @@ }, "outer_inset_first": { - "label": "Print Outer Wall Before Inner Walls", + "label": "Outer Wall Before Inner Walls", "description": "Prints insets in order of outside to inside when enabled. This can help improve dimensional accuracy in X and Y when using a high viscosity plastic like ABS; however it can decrease outer surface print quality, especially on overhangs.", "type": "bool", "default_value": false, From ea093cfca7f800ca68967570561510b4152b23ca Mon Sep 17 00:00:00 2001 From: TotalRetribution Date: Fri, 16 Sep 2016 15:47:40 +0100 Subject: [PATCH 5/6] Changed outer_inset_first description to use the word Walls instead of Inset. Shrunk length of Label name further. --- resources/definitions/fdmprinter.def.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index a96dcca2be..fbe4d878f8 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -819,8 +819,8 @@ }, "outer_inset_first": { - "label": "Outer Wall Before Inner Walls", - "description": "Prints insets in order of outside to inside when enabled. This can help improve dimensional accuracy in X and Y when using a high viscosity plastic like ABS; however it can decrease outer surface print quality, especially on overhangs.", + "label": "Outer Before Inner Walls", + "description": "Prints walls in order of outside to inside when enabled. This can help improve dimensional accuracy in X and Y when using a high viscosity plastic like ABS; however it can decrease outer surface print quality, especially on overhangs.", "type": "bool", "default_value": false, "settable_per_mesh": true, From 1eabf85eb0b14467e3f91bd756849a3f968fb008 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Tue, 20 Sep 2016 13:43:02 +0200 Subject: [PATCH 6/6] JSON fix: accidental comma --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index ac563c7377..5b82de4092 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -835,7 +835,7 @@ "description": "Prints walls in order of outside to inside when enabled. This can help improve dimensional accuracy in X and Y when using a high viscosity plastic like ABS; however it can decrease outer surface print quality, especially on overhangs.", "type": "bool", "default_value": false, - "settable_per_mesh": true, + "settable_per_mesh": true }, "alternate_extra_perimeter": {