From 64b23758c538f0f8f77d13f4f52b76c7222517d3 Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Fri, 12 Jul 2019 14:35:02 +0200 Subject: [PATCH 1/2] Add camera_view as stats --- plugins/SliceInfoPlugin/SliceInfo.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/plugins/SliceInfoPlugin/SliceInfo.py b/plugins/SliceInfoPlugin/SliceInfo.py index 7501429796..e015af50ad 100755 --- a/plugins/SliceInfoPlugin/SliceInfo.py +++ b/plugins/SliceInfoPlugin/SliceInfo.py @@ -126,6 +126,17 @@ class SliceInfo(QObject, Extension): else: data["active_mode"] = "custom" + camera_view = application.getPreferences().getValue("general/camera_perspective_mode") + from UM.Scene.Camera import Camera + if camera_view == Camera.PerspectiveMode.PERSPECTIVE.value: + camera_view_string = "perspective" + elif camera_view == Camera.PerspectiveMode.ORTHOGONAL.value: + camera_view_string = "orthographic" + else: + Logger.log("w", "Unexpected perspective mode [%s], use 'perspective' as the default value.", camera_view) + camera_view_string = "perspective" + data["camera_view"] = camera_view_string + definition_changes = global_stack.definitionChanges machine_settings_changed_by_user = False if definition_changes.getId() != "empty": From 9da6044a72d01bdce3847627454c371a1be26f6f Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Mon, 15 Jul 2019 17:00:56 +0200 Subject: [PATCH 2/2] Simplify camera_view data collection --- plugins/SliceInfoPlugin/SliceInfo.py | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/plugins/SliceInfoPlugin/SliceInfo.py b/plugins/SliceInfoPlugin/SliceInfo.py index e015af50ad..843bacdc59 100755 --- a/plugins/SliceInfoPlugin/SliceInfo.py +++ b/plugins/SliceInfoPlugin/SliceInfo.py @@ -126,16 +126,7 @@ class SliceInfo(QObject, Extension): else: data["active_mode"] = "custom" - camera_view = application.getPreferences().getValue("general/camera_perspective_mode") - from UM.Scene.Camera import Camera - if camera_view == Camera.PerspectiveMode.PERSPECTIVE.value: - camera_view_string = "perspective" - elif camera_view == Camera.PerspectiveMode.ORTHOGONAL.value: - camera_view_string = "orthographic" - else: - Logger.log("w", "Unexpected perspective mode [%s], use 'perspective' as the default value.", camera_view) - camera_view_string = "perspective" - data["camera_view"] = camera_view_string + data["camera_view"] = application.getPreferences().getValue("general/camera_perspective_mode") definition_changes = global_stack.definitionChanges machine_settings_changed_by_user = False