From aac16a27d7f109a7a75586e05ac780c630d1b1ea Mon Sep 17 00:00:00 2001 From: Kostas Karmas Date: Fri, 23 Oct 2020 16:30:54 +0200 Subject: [PATCH] Remove "Enable Variable Line Widening" in favor of "Print Thin Walls" The setting "Enable Variable Line Widening" was using the same notion as the Print Thin Walls. This commit fixes that by removing it and making the settings "Minimum Feature Size" and "Minimum Wall Line Width" dependand on the Print Thin Walls. The commit also adds reasonable default and minimum/maximum values for those two settings, along with a clearer description on how these settings affect the thin features of the model. CURA-7682 --- resources/definitions/fdmprinter.def.json | 57 ++++++++++------------- 1 file changed, 25 insertions(+), 32 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 33afeda7ce..17976afdfd 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -1067,38 +1067,6 @@ "default_value": "inward_distributed", "limit_to_extruder": "wall_0_extruder_nr" }, - "widening_beading_enabled": - { - "label": "Enable Variable Line Widening", - "description": "Applies the Widening Beading meta-strategy on top of the selected beading strategy in libArachne.", - "type": "bool", - "default_value": false, - "limit_to_extruder": "wall_0_extruder_nr" - }, - "min_bead_width": - { - "label": "Minimum Wall Line Width", - "description": "Minimum Bead Width. Used in the Widening Beading meta-strategy in libArachne.", - "unit": "mm", - "value": "wall_line_width / 2", - "minimum_value": "0", - "maximum_value": "wall_line_width", - "type": "float", - "limit_to_extruder": "wall_0_extruder_nr", - "enabled": "widening_beading_enabled" - }, - "min_feature_size": - { - "label": "Minimum Feature Size", - "description": "Minimum Feature Size. Used in the Widening Beading meta-strategy in libArachne.", - "unit": "mm", - "value": "wall_line_width / 2", - "minimum_value": "0", - "maximum_value": "wall_line_width", - "type": "float", - "limit_to_extruder": "wall_0_extruder_nr", - "enabled": "widening_beading_enabled" - }, "wall_0_wipe_dist": { "label": "Outer Wall Wipe Distance", @@ -1379,6 +1347,31 @@ "limit_to_extruder": "wall_0_extruder_nr", "settable_per_mesh": true }, + "min_feature_size": + { + "label": "Minimum Feature Size", + "description": "Minimum thickness of thin features. Model features that are thinner than this value will not be printed, while features thicker than the Minimum Feature Size will be widened to the Minimum Wall Line Width.", + "unit": "mm", + "default_value": 0, + "minimum_value": "0", + "maximum_value": "wall_line_width_0", + "type": "float", + "limit_to_extruder": "wall_0_extruder_nr", + "enabled": "fill_outline_gaps" + }, + "min_bead_width": + { + "label": "Minimum Wall Line Width", + "description": "Width of the wall that will replace thin features (according to the Minimum Feature Size) of the model. If the Minimum Wall Line Width is thinner than the thickness of the feature, the wall will become as thick as the feature itself.", + "unit": "mm", + "value": "wall_line_width_0", + "minimum_value": "0.5 * machine_nozzle_size", + "minimum_value_warning": "min_feature_size", + "maximum_value": "wall_line_width_0", + "type": "float", + "limit_to_extruder": "wall_0_extruder_nr", + "enabled": "fill_outline_gaps" + }, "xy_offset": { "label": "Horizontal Expansion",