From b15c272d235c36edc5056aace5293f287d430144 Mon Sep 17 00:00:00 2001
From: Ghostkeeper <rubend@tutanota.com>
Date: Tue, 27 Nov 2018 13:24:13 +0100
Subject: [PATCH] Fix applying configuration when clicking

Also no longer use that signal for it. It was completely unnecessary.

Contributes to issue CURA-5876.
---
 resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml | 6 +++++-
 .../qml/Menus/ConfigurationMenu/ConfigurationListView.qml   | 5 -----
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml b/resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml
index 297c95d1d1..69c0b11882 100644
--- a/resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml
+++ b/resources/qml/Menus/ConfigurationMenu/ConfigurationItem.qml
@@ -12,7 +12,6 @@ Button
     id: configurationItem
 
     property var configuration: null
-    signal activateConfiguration()
 
     height: childrenRect.height
 
@@ -111,4 +110,9 @@ Button
             configurationItem.checked = Cura.MachineManager.matchesConfiguration(configuration)
         }
     }
+
+    onClicked:
+    {
+        Cura.MachineManager.applyRemoteConfiguration(configuration)
+    }
 }
\ No newline at end of file
diff --git a/resources/qml/Menus/ConfigurationMenu/ConfigurationListView.qml b/resources/qml/Menus/ConfigurationMenu/ConfigurationListView.qml
index 2b7444be01..86deae9c4e 100644
--- a/resources/qml/Menus/ConfigurationMenu/ConfigurationListView.qml
+++ b/resources/qml/Menus/ConfigurationMenu/ConfigurationListView.qml
@@ -70,11 +70,6 @@ Column
             {
                 width: parent.width - UM.Theme.getSize("default_margin").width
                 configuration: modelData
-                onActivateConfiguration:
-                {
-                    switchPopupState()
-                    Cura.MachineManager.applyRemoteConfiguration(configuration)
-                }
             }
         }
     }