From f4349be84a2976946df7972e0e9cee9589366b9e Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 28 May 2024 09:03:46 +0200 Subject: [PATCH 1/2] Fix diagnose script to match post script --- .github/workflows/printer-linter-pr-diagnose.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/printer-linter-pr-diagnose.yml b/.github/workflows/printer-linter-pr-diagnose.yml index 67fbe7247f..ed51f8b2f8 100644 --- a/.github/workflows/printer-linter-pr-diagnose.yml +++ b/.github/workflows/printer-linter-pr-diagnose.yml @@ -53,7 +53,7 @@ jobs: run: | echo ${{ github.event.number }} > printer-linter-result/pr-id.txt echo ${{ github.event.pull_request.head.repo.full_name }} > printer-linter-result/pr-head-repo.txt - echo ${{ github.event.pull_request.head.ref }} > printer-linter-result/pr-head-ref.txt + echo ${{ github.event.pull_request.head.sha }} > printer-linter-result/pr-head-sha.txt - uses: actions/upload-artifact@v2 with: From dca3cb2cca2639d9782a35a02cdb8c59dbcca6f7 Mon Sep 17 00:00:00 2001 From: Erwan MATHIEU Date: Tue, 28 May 2024 09:18:46 +0200 Subject: [PATCH 2/2] Fix wrong variable given to script --- .github/workflows/printer-linter-pr-post.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/printer-linter-pr-post.yml b/.github/workflows/printer-linter-pr-post.yml index 4d784e7e2c..7b3dd152cb 100644 --- a/.github/workflows/printer-linter-pr-post.yml +++ b/.github/workflows/printer-linter-pr-post.yml @@ -99,7 +99,7 @@ jobs: if: env.commentFileExists == 'true' uses: peter-evans/create-or-update-comment@v4 with: - issue-number: ${{ env.pr_id }} + issue-number: ${{ env.PR_ID }} body-path: 'printer-linter-result/comment.md' - name: Run clang-tidy-pr-comments action @@ -107,5 +107,5 @@ jobs: with: github_token: ${{ secrets.GITHUB_TOKEN }} clang_tidy_fixes: printer-linter-result/fixes.yml - pull_request_id: ${{ env.pr_id }} + pull_request_id: ${{ env.PR_ID }} request_changes: true