GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-08-12 02:09:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Catch UnicodeDecodeErrors when parsing error messages from server

Browse Source 
Stupid recursive errors.

Fixes Sentry issue CURA-3VB.
This commit is contained in:
Ghostkeeper 2022-05-20 12:55:59 +02:00
parent 64b29779ca
commit b5e3479c1c
No known key found for this signature in database
GPG Key ID: D2A8871EE34EC59A
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/Marketplace/PackageList.py
View File

@ -244,7 +244,10 @@ class PackageList(ListModel):
def _downloadError(self, package_id: str, update: bool = False, reply: Optional["QNetworkReply"] = None, error: Optional["QNetworkReply.NetworkError"] = None) -> None:
if reply:
try:
reply_string = bytes(reply.readAll()).decode()
except UnicodeDecodeError:
reply_string = "<error message is corrupt too>"
Logger.error(f"Failed to download package: {package_id} due to {reply_string}")
self._package_manager.packageInstallingFailed.emit(package_id)