diff --git a/cura/Machines/MaterialManager.py b/cura/Machines/MaterialManager.py index 5e674965b3..896d309d7e 100644 --- a/cura/Machines/MaterialManager.py +++ b/cura/Machines/MaterialManager.py @@ -18,6 +18,11 @@ from .MaterialGroup import MaterialGroup # The models GUI and QML use are now only dependent on the MaterialManager. That means as long as the data in # MaterialManager gets updated correctly, the GUI models should be updated correctly too, and the same goes for GUI. # +# For now, updating the lookup maps and trees here is very simple: we discard the old data completely and recreate them +# again. This means the update is exactly the same as initialization. There are performance concerns about this approach +# but so far the creation of the tables and maps is very fast and there is no noticeable slowness, we keep it like this +# because it's simple. +# class MaterialManager(QObject): materialsUpdated = pyqtSignal() # Emitted whenever the material lookup tables are updated. diff --git a/cura/Machines/QualityManager.py b/cura/Machines/QualityManager.py index 4115b710e0..68a6a344ba 100644 --- a/cura/Machines/QualityManager.py +++ b/cura/Machines/QualityManager.py @@ -152,6 +152,11 @@ class QualityNode(ContainerNode): # The models GUI and QML use are now only dependent on the QualityManager. That means as long as the data in # QualityManager gets updated correctly, the GUI models should be updated correctly too, and the same goes for GUI. # +# For now, updating the lookup maps and trees here is very simple: we discard the old data completely and recreate them +# again. This means the update is exactly the same as initialization. There are performance concerns about this approach +# but so far the creation of the tables and maps is very fast and there is no noticeable slowness, we keep it like this +# because it's simple. +# class QualityManager(QObject): qualitiesUpdated = pyqtSignal()