From bcf4bc813886fc05f7989a983137a5b3fb688ecb Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Tue, 11 Feb 2020 11:02:32 +0100 Subject: [PATCH] Simplify _is_any_version_compatible It now literally says: for any version, is it compatible? Contributes to issue CURA-7207. --- .../Toolbox/src/CloudSync/SubscribedPackagesModel.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/plugins/Toolbox/src/CloudSync/SubscribedPackagesModel.py b/plugins/Toolbox/src/CloudSync/SubscribedPackagesModel.py index f29f23b001..8e2b4255f0 100644 --- a/plugins/Toolbox/src/CloudSync/SubscribedPackagesModel.py +++ b/plugins/Toolbox/src/CloudSync/SubscribedPackagesModel.py @@ -74,8 +74,9 @@ class SubscribedPackagesModel(ListModel): @staticmethod def _is_any_version_compatible(package_manager: PackageManager, api_versions: [str]) -> bool: - """:return: True when any of the provided api versions is compatible""" - for version in api_versions: - if package_manager.isPackageCompatible(Version(version)): - return True - return False + """ + Check a list of version numbers if any of them applies to our + application. + :return: ``True`` when any of the provided API versions is compatible. + """ + return any(package_manager.isPackageCompatible(Version(version)) for version in api_versions)