From b0aae9a6dfd61f8d6bdc613c6e25485cf7862ea0 Mon Sep 17 00:00:00 2001 From: Oliver Mattos Date: Mon, 29 Jul 2024 16:16:09 +0100 Subject: [PATCH 1/3] Add setting for extra_infill_lines_to_support_skins --- resources/definitions/fdmprinter.def.json | 19 +++++++++++++++++-- resources/definitions/ultimaker.def.json | 1 - resources/setting_visibility/expert.cfg | 1 + 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 045bec05a4..65de59c27f 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2326,7 +2326,7 @@ "label": "Skin Edge Support Thickness", "description": "The thickness of the extra infill that supports skin edges.", "unit": "mm", - "default_value": 0.8, + "default_value": 0, "minimum_value": "0", "maximum_value": "machine_height", "maximum_value_warning": "resolveOrValue('infill_sparse_thickness') * 10", @@ -2341,7 +2341,7 @@ { "label": "Skin Edge Support Layers", "description": "The number of infill layers that supports skin edges.", - "default_value": 4, + "default_value": 0, "minimum_value": "0", "maximum_value_warning": "10", "type": "int", @@ -2353,6 +2353,21 @@ } } }, + "extra_infill_lines_to_support_skins": + { + "label": "Extra Infill Lines To Support Skins", + "description": "Add extra lines into the infill pattern to support skins above. This option prevents holes or plastic blobs that sometime show in complex shaped skins due to the infill below not correctly supporting the skin layer being printed above.", + "type": "enum", + "options": + { + "walls_and_lines": "Walls and Lines", + "walls": "Walls Only", + "none": "None" + }, + "default_value": "walls_and_lines", + "value": "'none' if infill_sparse_density > 50 else 'walls' if skin_edge_support_thickness > 0 else 'walls_and_lines'", + "enabled": "infill_sparse_density > 0" + }, "lightning_infill_support_angle": { "label": "Lightning Infill Support Angle", diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json index 918db0d0ea..0d0b162c01 100644 --- a/resources/definitions/ultimaker.def.json +++ b/resources/definitions/ultimaker.def.json @@ -111,7 +111,6 @@ "roofing_layer_count": { "value": "1" }, "roofing_material_flow": { "value": "material_flow" }, "skin_angles": { "value": "[] if infill_pattern not in ['cross', 'cross_3d'] else [20, 110]" }, - "skin_edge_support_thickness": { "value": "4 * layer_height if infill_sparse_density < 30 else 0" }, "skin_material_flow": { "value": "0.95 * material_flow" }, "skin_material_flow_layer_0": { "value": "95" }, "skin_monotonic": { "value": "roofing_layer_count == 0" }, diff --git a/resources/setting_visibility/expert.cfg b/resources/setting_visibility/expert.cfg index f0ba478a53..9950957081 100644 --- a/resources/setting_visibility/expert.cfg +++ b/resources/setting_visibility/expert.cfg @@ -110,6 +110,7 @@ min_skin_width_for_expansion infill_randomize_start_location skin_edge_support_thickness skin_edge_support_layers +extra_infill_lines_to_support_skins [material] default_material_print_temperature From acf5a222cd8c64b1c2eb719280bdc3421bb119e9 Mon Sep 17 00:00:00 2001 From: Oliver Mattos Date: Thu, 8 Aug 2024 15:38:14 +0100 Subject: [PATCH 2/3] Adjust enable criteria and expand on description --- resources/definitions/fdmprinter.def.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 65de59c27f..661cb6d0dd 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2356,7 +2356,7 @@ "extra_infill_lines_to_support_skins": { "label": "Extra Infill Lines To Support Skins", - "description": "Add extra lines into the infill pattern to support skins above. This option prevents holes or plastic blobs that sometime show in complex shaped skins due to the infill below not correctly supporting the skin layer being printed above.", + "description": "Add extra lines into the infill pattern to support skins above. This option prevents holes or plastic blobs that sometime show in complex shaped skins due to the infill below not correctly supporting the skin layer being printed above. 'Walls' supports just the outlines of the skin, whereas 'Walls and Lines' also supports the ends of the lines that make up the skin.", "type": "enum", "options": { @@ -2366,7 +2366,7 @@ }, "default_value": "walls_and_lines", "value": "'none' if infill_sparse_density > 50 else 'walls' if skin_edge_support_thickness > 0 else 'walls_and_lines'", - "enabled": "infill_sparse_density > 0" + "enabled": "infill_sparse_density > 0 and infill_pattern not in ('lightning', 'concentric', 'cross','cross_3d')" }, "lightning_infill_support_angle": { From dc4a92d960613dea31745bcbc77cf27dca74c42a Mon Sep 17 00:00:00 2001 From: Oliver Mattos Date: Thu, 8 Aug 2024 17:39:58 +0100 Subject: [PATCH 3/3] A few more enable conditions for extra_infill_lines_to_support_skins --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 00e2f76f1e..579197d024 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2367,7 +2367,7 @@ }, "default_value": "walls_and_lines", "value": "'none' if infill_sparse_density > 50 else 'walls' if skin_edge_support_thickness > 0 else 'walls_and_lines'", - "enabled": "infill_sparse_density > 0 and infill_pattern not in ('lightning', 'concentric', 'cross','cross_3d')" + "enabled": "infill_sparse_density > 0 and infill_pattern not in ('lightning', 'concentric', 'cross','cross_3d') and wall_line_count > 0 and top_layers > 0" }, "lightning_infill_support_angle": {