From c5d5cd2c594b1383787b69da10fc0cb4596a3d08 Mon Sep 17 00:00:00 2001
From: Jaime van Kessel <nallath@gmail.com>
Date: Fri, 10 Jul 2020 13:54:16 +0200
Subject: [PATCH] Precompute delegate height for settingview

Speed up the rendering of settingitems a bit
---
 resources/qml/Settings/SettingView.qml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/resources/qml/Settings/SettingView.qml b/resources/qml/Settings/SettingView.qml
index 5dfba3e464..4c31988eb0 100644
--- a/resources/qml/Settings/SettingView.qml
+++ b/resources/qml/Settings/SettingView.qml
@@ -246,13 +246,14 @@ Item
             }
 
             property int indexWithFocus: -1
+            property double delegateHeight: UM.Theme.getSize("section").height + 2 * UM.Theme.getSize("default_lining").height
             property string activeMachineId: Cura.MachineManager.activeMachine !== null ? Cura.MachineManager.activeMachine.id : ""
             delegate: Loader
             {
                 id: delegate
 
                 width: scrollView.width
-                height: provider.properties.enabled === "True" ? UM.Theme.getSize("section").height + 2 * UM.Theme.getSize("default_lining").height : 0
+                height: provider.properties.enabled === "True" ? contents.delegateHeight: 0
                 Behavior on height { NumberAnimation { duration: 100 } }
                 opacity: provider.properties.enabled === "True" ? 1 : 0
                 Behavior on opacity { NumberAnimation { duration: 100 } }