From d25ca84c6c4e7f2ad89fb3557359175530dc5cfa Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Sun, 3 Nov 2019 02:20:18 +0100 Subject: [PATCH] Make small feature max length a child setting of small hole max size The small hole max size is not used in CuraEngine. It may not be a leaf setting then. Instead, Small Feature Max Length is used which is directly dependent on Small Hole Max Size. They are simply different units of the same thing. This is how we should structure these settings then. --- resources/definitions/fdmprinter.def.json | 27 +++++++++++++---------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 2861e2ec74..2df14c4948 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -7559,18 +7559,21 @@ "type": "float", "minimum_value": "0", "default_value": 0, - "settable_per_mesh": true - }, - "small_feature_max_length": - { - "label": "Small Feature Max Length", - "description": "Feature outlines that are shorter than this length will be printed using Small Feature Speed.", - "unit": "mm", - "type": "float", - "minimum_value": "0", - "default_value": 0, - "value": "small_hole_max_size * math.pi", - "settable_per_mesh": true + "settable_per_mesh": true, + "children": + { + "small_feature_max_length": + { + "label": "Small Feature Max Length", + "description": "Feature outlines that are shorter than this length will be printed using Small Feature Speed.", + "unit": "mm", + "type": "float", + "minimum_value": "0", + "default_value": 0, + "value": "small_hole_max_size * math.pi", + "settable_per_mesh": true + } + } }, "small_feature_speed_factor": {