From a8685b10bed2ea6b014defbddb0dcf35f92ee716 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 4 Jul 2018 11:48:27 +0100 Subject: [PATCH 1/6] Change some settings to be settable per mesh rather than per extruder. # Conflicts: # resources/definitions/fdmprinter.def.json --- resources/definitions/fdmprinter.def.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index b458316686..1b8f333509 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -1287,8 +1287,8 @@ "default_value": 0, "type": "float", "enabled": "travel_compensate_overlapping_walls_0_enabled or travel_compensate_overlapping_walls_x_enabled", - "settable_per_mesh": false, - "settable_per_extruder": true + "settable_per_mesh": true, + "settable_per_extruder": false }, "wall_min_flow_retract": { @@ -1297,8 +1297,8 @@ "type": "bool", "default_value": false, "enabled": "(travel_compensate_overlapping_walls_0_enabled or travel_compensate_overlapping_walls_x_enabled) and wall_min_flow > 0", - "settable_per_mesh": false, - "settable_per_extruder": true + "settable_per_mesh": true, + "settable_per_extruder": false }, "fill_perimeter_gaps": { @@ -6464,8 +6464,8 @@ "minimum_value": "0", "default_value": 5, "enabled": "bridge_settings_enabled", - "settable_per_mesh": false, - "settable_per_extruder": true + "settable_per_mesh": true, + "settable_per_extruder": false }, "bridge_skin_support_threshold": { @@ -6501,7 +6501,7 @@ "minimum_value": "0", "maximum_value": "500", "enabled": "bridge_settings_enabled", - "settable_per_mesh": false + "settable_per_mesh": true }, "bridge_wall_speed": { From 404551e30a25109fc84e6b9f2d37cbf464f1ccd7 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 4 Jul 2018 11:49:08 +0100 Subject: [PATCH 2/6] Remove bridge_wall_max_overhang - no longer required with new overhang settings. # Conflicts: # resources/definitions/fdmprinter.def.json --- resources/definitions/fdmprinter.def.json | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 1b8f333509..be99b2fd39 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6479,18 +6479,6 @@ "enabled": "bridge_settings_enabled", "settable_per_mesh": true }, - "bridge_wall_max_overhang": - { - "label": "Bridge Wall Max Overhang", - "description": "The maximum allowed width of the region of air below a wall line before the wall is printed using bridge settings. Expressed as a percentage of the wall line width. When the air gap is wider than this, the wall line is printed using the bridge settings. Otherwise, the wall line is printed using the normal settings. The lower the value, the more likely it is that overhung wall lines will be printed using bridge settings.", - "unit": "%", - "default_value": 100, - "type": "float", - "minimum_value": "0", - "maximum_value": "100", - "enabled": "bridge_settings_enabled", - "settable_per_mesh": true - }, "bridge_wall_coast": { "label": "Bridge Wall Coasting", From 41900e33b82cc21036c40a9cc788374cfbe37d7f Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 4 Jul 2018 11:49:53 +0100 Subject: [PATCH 3/6] Add wall_overhang_angle and wall_overhang_speed_factor settings. # Conflicts: # resources/definitions/fdmprinter.def.json --- resources/definitions/fdmprinter.def.json | 24 +++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index be99b2fd39..7dc80fa030 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6445,6 +6445,30 @@ "settable_per_extruder": false, "settable_per_meshgroup": false }, + "wall_overhang_angle": + { + "label": "Overhanging Wall Angle", + "description": "Walls that overhang more than this angle will be printed using overhanging wall settings.", + "unit": "°", + "type": "float", + "minimum_value": "0", + "minimum_value_warning": "2", + "maximum_value": "80", + "default_value": 40, + "settable_per_mesh": true + }, + "wall_overhang_speed_factor": + { + "label": "Overhanging Wall Speed", + "description": "Overhanging walls will be printed at this percentage of their normal print speed.", + "unit": "%", + "type": "float", + "default_value": 50, + "minimum_value": "10", + "minimum_value_warning": "25", + "maximum_value": "100", + "settable_per_mesh": true + }, "bridge_settings_enabled": { "label": "Enable Bridge Settings", From 5f23bcf8e90cbf4ab6e8816edac7de93907421aa Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Tue, 19 Jun 2018 15:15:50 +0100 Subject: [PATCH 4/6] Allow wall_overhang_angle to be 90 and add blurb that describes how this disables overhang processing. --- resources/definitions/fdmprinter.def.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 7dc80fa030..2eb823d8d0 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6448,12 +6448,12 @@ "wall_overhang_angle": { "label": "Overhanging Wall Angle", - "description": "Walls that overhang more than this angle will be printed using overhanging wall settings.", + "description": "Walls that overhang more than this angle will be printed using overhanging wall settings. When the value is 90, no walls will be treated as overhanging.", "unit": "°", "type": "float", "minimum_value": "0", "minimum_value_warning": "2", - "maximum_value": "80", + "maximum_value": "90", "default_value": 40, "settable_per_mesh": true }, From 9186dc2c89492b727f86760069c02806d5b42b44 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Tue, 19 Jun 2018 22:08:30 +0100 Subject: [PATCH 5/6] Default value for wall_overhang_angle is now 90 so overhang detection is disabled by default. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 2eb823d8d0..5720b8cadb 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6454,7 +6454,7 @@ "minimum_value": "0", "minimum_value_warning": "2", "maximum_value": "90", - "default_value": 40, + "default_value": 90, "settable_per_mesh": true }, "wall_overhang_speed_factor": From 9e0b79469b814242679feab9b3be0c4b6e9648ae Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 20 Jun 2018 09:49:40 +0100 Subject: [PATCH 6/6] Set default value of wall_overhang_speed_factor to 100, i.e. print overhang at the normal speed. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 5720b8cadb..7d62ef4253 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6463,7 +6463,7 @@ "description": "Overhanging walls will be printed at this percentage of their normal print speed.", "unit": "%", "type": "float", - "default_value": 50, + "default_value": 100, "minimum_value": "10", "minimum_value_warning": "25", "maximum_value": "100",