From d866216f0c431abcd0cfef66a748c6c2adc199bc Mon Sep 17 00:00:00 2001
From: Ghostkeeper <rubend@tutanota.com>
Date: Mon, 13 Mar 2017 13:39:10 +0100
Subject: [PATCH] Add tests for removed settings from preferences files

Contributes to issue CURA-3479.
---
 .../tests/TestVersionUpgrade24to25.py         | 43 ++++++++++++++++++-
 1 file changed, 42 insertions(+), 1 deletion(-)

diff --git a/plugins/VersionUpgrade/VersionUpgrade24to25/tests/TestVersionUpgrade24to25.py b/plugins/VersionUpgrade/VersionUpgrade24to25/tests/TestVersionUpgrade24to25.py
index 065e778462..03c58bff18 100644
--- a/plugins/VersionUpgrade/VersionUpgrade24to25/tests/TestVersionUpgrade24to25.py
+++ b/plugins/VersionUpgrade/VersionUpgrade24to25/tests/TestVersionUpgrade24to25.py
@@ -92,4 +92,45 @@ version = not-a-text-version-number
 @pytest.mark.parametrize("data", test_cfg_version_bad_data)
 def test_cfgVersionBad(data, upgrader):
     with pytest.raises(data["exception"]):
-        upgrader.getCfgVersion(data["file_data"])
\ No newline at end of file
+        upgrader.getCfgVersion(data["file_data"])
+
+test_removed_settings_data = [
+    {
+        "test_name": "Removed Setting",
+        "file_data": """[general]
+visible_settings = baby;you;know;how;I;like;to;start_layers_at_same_position
+""",
+    },
+    {
+        "test_name": "No Removed Setting",
+        "file_data": """[general]
+visible_settings = baby;you;now;how;I;like;to;eat;chocolate;muffins
+"""
+},
+    {
+        "test_name": "No Visible Settings Key",
+        "file_data": """[general]
+cura = cool
+"""
+    },
+    {
+        "test_name": "No General Category",
+        "file_data": """[foos]
+foo = bar
+"""
+    }
+]
+
+##  Tests whether the settings that should be removed are removed for the 2.5
+#   version of preferences.
+@pytest.mark.parametrize("data", test_removed_settings_data)
+def test_upgradePreferencesRemovedSettings(data, upgrader):
+    _, upgraded_preferences = upgrader.upgradePreferences(data["file_data"], "<string>")
+    upgraded_preferences = upgraded_preferences[0]
+
+    #Find whether the removed setting is removed from the file now.
+    bad_setting = "start_layers_at_same_position"
+    parser = configparser.ConfigParser(interpolation = None)
+    parser.read_string(upgraded_preferences)
+    if parser.has_section("general") and "visible_settings" in parser["general"]:
+        assert bad_setting not in parser["general"]["visible_settings"]
\ No newline at end of file