From f1cc551309b005f088ac725a3654e05a93b607e5 Mon Sep 17 00:00:00 2001 From: Rijk van Manen Date: Thu, 2 Feb 2023 11:08:21 +0100 Subject: [PATCH 1/2] add value limits Slicing becomes very slow for large interlocking_boundary_avoidance and interlocking_depth values. The minimum interlocking_beam_width is the minimum wall line width. And the interlocking_rotation should be between 0 and 360 degrees. PP-283 --- resources/definitions/fdmprinter.def.json | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 881f0dc04c..8d0a7de308 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6870,7 +6870,7 @@ "enabled": "extruders_enabled_count > 1 and resolveOrValue('interlocking_enable')", "default_value": 0.8, "value": "2 * wall_line_width_0", - "minimum_value": "0.001", + "minimum_value": "min_odd_wall_line_width", "maximum_value": "min(0.5 * machine_width, 0.5 * machine_depth)", "maximum_value_warning": "max(extruderValues('wall_line_width_0')) * 6", "settable_per_mesh": true, @@ -6884,6 +6884,8 @@ "type": "float", "enabled": "extruders_enabled_count > 1 and resolveOrValue('interlocking_enable')", "default_value": 22.5, + "minimum_value": "0", + "maximum_value": "360", "resolve": "min(extruderValues('interlocking_orientation'))", "settable_per_mesh": false, "settable_per_extruder": false @@ -6896,6 +6898,7 @@ "enabled": "extruders_enabled_count > 1 and resolveOrValue('interlocking_enable')", "default_value": 2, "minimum_value": "1", + "maximum_value_warning": "50", "resolve": "max(extruderValues('interlocking_beam_layer_count'))", "settable_per_mesh": false, "settable_per_extruder": false @@ -6908,6 +6911,8 @@ "enabled": "extruders_enabled_count > 1 and resolveOrValue('interlocking_enable')", "default_value": 2, "minimum_value": "1", + "maximum_value": "10", + "maximum_value_warning": "5", "resolve": "max(extruderValues('interlocking_depth'))", "settable_per_mesh": false, "settable_per_extruder": false @@ -6920,8 +6925,10 @@ "enabled": "extruders_enabled_count > 1 and resolveOrValue('interlocking_enable')", "default_value": 3, "minimum_value": "0", - "resolve": "max(extruderValues('interlocking_boundary_avoidance'))", "minimum_value_warning": "resolveOrValue('interlocking_depth')", + "maximum_value": "10", + "maximum_value_warning": "5", + "resolve": "max(extruderValues('interlocking_boundary_avoidance'))", "settable_per_mesh": false, "settable_per_extruder": false }, From 5b2fb0c0d986a75b3b7a7d6e357e33df7e7b35ca Mon Sep 17 00:00:00 2001 From: Rijk van Manen Date: Thu, 2 Feb 2023 11:10:22 +0100 Subject: [PATCH 2/2] reduce the interlocking_boundary_avoidance The interlocking_boundary_avoidance was a bit larger originally to prevent interlocking structures outside the model for edge cases. But this behaviour is improved a lot, so the boundary avoidance can be reduced, which helps for thin and small structures. PP-283 --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 8d0a7de308..536ce27e06 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -6923,7 +6923,7 @@ "description": "The distance close to the boundary of the print where not to generate an interlocking structure as measued in number of cells times 2. If set to a value lower than the Inerlocking Depth then the interlocking structure can become visible on the outside of the print near the interfaces where two models meet.", "type": "int", "enabled": "extruders_enabled_count > 1 and resolveOrValue('interlocking_enable')", - "default_value": 3, + "default_value": 2, "minimum_value": "0", "minimum_value_warning": "resolveOrValue('interlocking_depth')", "maximum_value": "10",