From d8cf234a17507c46ecb913f0166f65135e033946 Mon Sep 17 00:00:00 2001
From: Joey de l'Arago <joeydelarago@gmail.com>
Date: Wed, 7 Dec 2022 12:25:33 +0100
Subject: [PATCH] Use different signal for triggering update to extrduderIds.
 **This is a hack**. Actually fixing this problem could take days.

CURA-9793
---
 cura/Settings/ExtruderManager.py | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/cura/Settings/ExtruderManager.py b/cura/Settings/ExtruderManager.py
index aff1498a2a..dec4a74d27 100755
--- a/cura/Settings/ExtruderManager.py
+++ b/cura/Settings/ExtruderManager.py
@@ -46,17 +46,22 @@ class ExtruderManager(QObject):
         self._selected_object_extruders = []  # type: List[Union[str, "ExtruderStack"]]
 
         Selection.selectionChanged.connect(self.resetSelectedObjectExtruders)
-        Application.getInstance().globalContainerStackChanged.connect(self.emitExtrudersChanged)  # When the machine is swapped we must update the active machine extruders
+        Application.getInstance().globalContainerStackChanged.connect(self.emitGlobalStackExtrudersChanged)  # When the machine is swapped we must update the active machine extruders
 
-    extrudersChanged = pyqtSignal()
+    # Don't use this unless you are reading from ExtruderManager.extruderIds when receiving the signal
+    globalStackExtrudersChanged = pyqtSignal()
+
+    # This signal actually emits before the global stacks extruders are updated, changing this behaviour breaks too many things
+    # Use globalStackExtrudersChanged = pyqtSignal() if you want a trigger when the extrduerIds property changes.
+    extrudersChanged = pyqtSignal(QVariant)
     """Signal to notify other components when the list of extruders for a machine definition changes."""
 
     activeExtruderChanged = pyqtSignal()
     """Notify when the user switches the currently active extruder."""
 
-    def emitExtrudersChanged(self):
+    def emitGlobalStackExtrudersChanged(self):
         # The emit function can't be directly connected to another signal. This wrapper function is required.
-        self.extrudersChanged.emit()
+        self.globalStackExtrudersChanged.emit()
 
     @pyqtProperty(str, notify = activeExtruderChanged)
     def activeExtruderStackId(self) -> Optional[str]:
@@ -381,6 +386,8 @@ class ExtruderManager(QObject):
             extruders_changed = True
 
         self.fixSingleExtrusionMachineExtruderDefinition(global_stack)
+        if extruders_changed:
+            self.extrudersChanged.emit(global_stack_id)
 
     # After 3.4, all single-extrusion machines have their own extruder definition files instead of reusing
     # "fdmextruder". We need to check a machine here so its extruder definition is correct according to this.