From e127f7e4b610903a8b98f4341314e91c3253e076 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 15 Jul 2021 16:45:50 +0200 Subject: [PATCH] Move construction of slicing error message to constructor This way we could re-use it in other places. Contributes to issue CURA-6568. --- .../CuraEngineBackend/CuraEngineBackend.py | 25 ++++++++++--------- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/plugins/CuraEngineBackend/CuraEngineBackend.py b/plugins/CuraEngineBackend/CuraEngineBackend.py index ed4141c99a..d49baf189e 100755 --- a/plugins/CuraEngineBackend/CuraEngineBackend.py +++ b/plugins/CuraEngineBackend/CuraEngineBackend.py @@ -157,6 +157,18 @@ class CuraEngineBackend(QObject, Backend): self.determineAutoSlicing() application.getPreferences().preferenceChanged.connect(self._onPreferencesChanged) + self._slicing_error_message = Message( + text = catalog.i18nc("@message", "Slicing failed with an unexpected error. Please consider reporting a bug on our issue tracker."), + title = catalog.i18nc("@message:title", "Slicing failed") + ) + self._slicing_error_message.addAction( + action_id = "report_bug", + name = catalog.i18nc("@message:button", "Report a bug"), + description = catalog.i18nc("@message:description", "Report a bug on Ultimaker Cura's issue tracker."), + icon = "[no_icon]" + ) + self._slicing_error_message.actionTriggered.connect(self._reportBackendError) + self._snapshot = None #type: Optional[QImage] application.initializationFinished.connect(self.initialize) @@ -925,18 +937,7 @@ class CuraEngineBackend(QObject, Backend): return_code = self._process.wait() if return_code != 0: Logger.log("e", f"Backend exited abnormally with return code {return_code}!") - message = Message( - text = catalog.i18nc("@message", "Slicing failed with an unexpected error. Please consider reporting a bug on our issue tracker."), - title = catalog.i18nc("@message:title", "Slicing failed") - ) - message.addAction( - action_id = "report_bug", - name = catalog.i18nc("@message:button", "Report a bug"), - description = catalog.i18nc("@message:description", "Report a bug on Ultimaker Cura's issue tracker."), - icon = "[no_icon]" - ) - message.actionTriggered.connect(self._reportBackendError) - message.show() + self._slicing_error_message.show() self.stopSlicing() else: Logger.log("d", "Backend finished slicing. Resetting process and socket.")