From e633b6408e19e3f6f8c30ec3c22f506779d86ae9 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Fri, 10 Jul 2020 14:34:02 +0200 Subject: [PATCH] Use pre-calculated control height It's way faster to not re-compute every single time --- resources/qml/Settings/SettingItem.qml | 2 +- resources/themes/cura-light/theme.json | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/resources/qml/Settings/SettingItem.qml b/resources/qml/Settings/SettingItem.qml index 4f232cd7ee..f0c748d190 100644 --- a/resources/qml/Settings/SettingItem.qml +++ b/resources/qml/Settings/SettingItem.qml @@ -156,7 +156,7 @@ Item { id: settingControls - height: Math.round(parent.height / 2) + height: UM.Theme.getSize("section_control").height spacing: Math.round(UM.Theme.getSize("thick_margin").height / 2) anchors diff --git a/resources/themes/cura-light/theme.json b/resources/themes/cura-light/theme.json index 10cb353c60..784f62965c 100644 --- a/resources/themes/cura-light/theme.json +++ b/resources/themes/cura-light/theme.json @@ -502,6 +502,7 @@ "extruder_icon": [2.33, 2.33], "section": [0.0, 2], + "section_control": [0, 1], "section_icon": [1.6, 1.6], "section_icon_column": [2.8, 0.0], "rating_star": [1.0, 1.0],