From 06e61a31291bc4fc307837ebf496e12089de2b3a Mon Sep 17 00:00:00 2001 From: digitalfrost Date: Mon, 8 Aug 2022 09:48:33 +0200 Subject: [PATCH 1/3] Use is not operator rather than not ... is This is advocated by both PEP8 and the Google Python Style Guide --- cura/Arranging/ShapeArray.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cura/Arranging/ShapeArray.py b/cura/Arranging/ShapeArray.py index 5607c03663..45454f6239 100644 --- a/cura/Arranging/ShapeArray.py +++ b/cura/Arranging/ShapeArray.py @@ -74,7 +74,7 @@ class ShapeArray: # If the child-nodes are included, adjust convex hulls as well: if include_children: children = node.getAllChildren() - if not children is None: + if children is not None: for child in children: # 'Inefficient' combination of convex hulls through known code rather than mess it up: child_hull = child.callDecoration("getConvexHull") @@ -159,4 +159,4 @@ class ShapeArray: max_col_idx = (idxs[0] - p1[0]) / (p2[0] - p1[0]) * (p2[1] - p1[1]) + p1[1] sign = numpy.sign(p2[0] - p1[0]) - return idxs[1] * sign <= max_col_idx * sign \ No newline at end of file + return idxs[1] * sign <= max_col_idx * sign From ff07129f2ce6bf92d192be003f0ef5457ae2b842 Mon Sep 17 00:00:00 2001 From: digitalfrost Date: Mon, 8 Aug 2022 09:50:36 +0200 Subject: [PATCH 2/3] Use is not operator rather than not ... is This is advocated by both PEP8 and the Google Python Style Guide --- cura/Arranging/ShapeArray.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cura/Arranging/ShapeArray.py b/cura/Arranging/ShapeArray.py index 45454f6239..3060ea6e8e 100644 --- a/cura/Arranging/ShapeArray.py +++ b/cura/Arranging/ShapeArray.py @@ -78,7 +78,7 @@ class ShapeArray: for child in children: # 'Inefficient' combination of convex hulls through known code rather than mess it up: child_hull = child.callDecoration("getConvexHull") - if not child_hull is None: + if child_hull is not None: hull_verts = hull_verts.unionConvexHulls(child_hull) child_hull_head = child.callDecoration("getConvexHullHead") or child_hull if not child_hull_head is None: From 54b9ed97aeb3e8ddf7af65e479fe7ade3a492aa0 Mon Sep 17 00:00:00 2001 From: digitalfrost Date: Mon, 8 Aug 2022 09:52:16 +0200 Subject: [PATCH 3/3] Use is not operator rather than not ... is This is advocated by both PEP8 and the Google Python Style Guide --- cura/Arranging/ShapeArray.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cura/Arranging/ShapeArray.py b/cura/Arranging/ShapeArray.py index 3060ea6e8e..714d9d3837 100644 --- a/cura/Arranging/ShapeArray.py +++ b/cura/Arranging/ShapeArray.py @@ -81,7 +81,7 @@ class ShapeArray: if child_hull is not None: hull_verts = hull_verts.unionConvexHulls(child_hull) child_hull_head = child.callDecoration("getConvexHullHead") or child_hull - if not child_hull_head is None: + if child_hull_head is not None: hull_head_verts = hull_head_verts.unionConvexHulls(child_hull_head) offset_verts = hull_head_verts.getMinkowskiHull(Polygon.approximatedCircle(min_offset))