GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-07-18 11:24:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed mypy typing failure

Browse Source 
@ghostkeeper being nerd snipped
It's giving that typing failure because the section variable is re-used.
First as elements from self._getSections (strs) and then as elements
from sorted_sections.values() (List[PackageModel]s). Python has no
variable scopes within functions so the variable still exists after the
first for loop.

Contributes to CURA-8558
This commit is contained in:
Jelle Spijker 2021-11-03 16:29:35 +01:00 committed by Jelle Spijker
parent 07fcf8b533
commit e7aecb6c06
No known key found for this signature in database
GPG Key ID: 6662DC033BE6B99A
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/Marketplace/LocalPackageList.py
View File

@ -62,8 +62,8 @@ class LocalPackageList(PackageList):
sorted_sections[section] = sorted(packages, key = lambda p: p.displayName) sorted_sections[section] = sorted(packages, key = lambda p: p.displayName)
# Append the order PackageModels to the list # Append the order PackageModels to the list
for section in sorted_sections.values(): for sorted_section in sorted_sections.values():
for package_data in section: for package_data in sorted_section:
self.appendItem({"package": package_data}) self.appendItem({"package": package_data})
self.setIsLoading(False) self.setIsLoading(False)