From e821179d7f22eb728bd40fe3fbb2e58002980233 Mon Sep 17 00:00:00 2001
From: Lipu Fei <lipu.fei815@gmail.com>
Date: Mon, 11 Mar 2019 08:33:30 +0100
Subject: [PATCH] WIP: Fix binding loops

---
 resources/qml/WelcomePages/DropDownWidget.qml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/resources/qml/WelcomePages/DropDownWidget.qml b/resources/qml/WelcomePages/DropDownWidget.qml
index d55fa363c8..16e0f6d282 100644
--- a/resources/qml/WelcomePages/DropDownWidget.qml
+++ b/resources/qml/WelcomePages/DropDownWidget.qml
@@ -15,7 +15,7 @@ Item
     id: base
 
     implicitWidth: 200
-    height: header.contentShown ? childrenRect.height : header.height
+    height: header.contentShown ? (header.height + contentRectangle.height) : header.height
 
     property var contentComponent: null
 
@@ -47,7 +47,7 @@ Item
         anchors.top: header.bottom
         anchors.left: header.left
         anchors.right: header.right
-        height: childrenRect.height
+        height: contentLoader.height + 2
 
         border.width: UM.Theme.getSize("default_lining").width
         border.color: UM.Theme.getColor("lining")
@@ -62,7 +62,6 @@ Item
             anchors.top: parent.top
             anchors.left: parent.left
             anchors.right: parent.right
-            height: childrenRect.height + 2
             anchors.margins: 1
             sourceComponent: base.contentComponent != null ? base.contentComponent : emptyComponent
         }