Apply suggestions from code review

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
This commit is contained in:
Jelle Spijker 2023-12-08 14:36:29 +01:00 committed by GitHub
parent 065f22ba07
commit f2f2f742bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 23 additions and 35 deletions

View File

@ -31,16 +31,15 @@ env:
CONAN_LOGIN_USERNAME_CURA: ${{ secrets.CONAN_USER }} CONAN_LOGIN_USERNAME_CURA: ${{ secrets.CONAN_USER }}
CONAN_PASSWORD_CURA: ${{ secrets.CONAN_PASS }} CONAN_PASSWORD_CURA: ${{ secrets.CONAN_PASS }}
# FIXME: point to `main` once merged
jobs: jobs:
conan-recipe-version: conan-recipe-version:
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@main
with: with:
project_name: cura project_name: cura
conan-package-export: conan-package-export:
needs: [ conan-recipe-version ] needs: [ conan-recipe-version ]
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-export.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-export.yml@main
with: with:
recipe_id_full: ${{ needs.conan-recipe-version.outputs.recipe_id_full }} recipe_id_full: ${{ needs.conan-recipe-version.outputs.recipe_id_full }}
recipe_id_latest: ${{ needs.conan-recipe-version.outputs.recipe_id_latest }} recipe_id_latest: ${{ needs.conan-recipe-version.outputs.recipe_id_latest }}

View File

@ -42,16 +42,15 @@ env:
jobs: jobs:
default_values: default_values:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-default-value.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-default-value.yml@main
with: with:
cura_conan_version: ${{ inputs.cura_conan_version }} cura_conan_version: ${{ inputs.cura_conan_version }}
latest_release: '5.6' latest_release: '5.6'
latest_release_schedule_hour: 4 latest_release_schedule_hour: 4
latest_release_tag: 'nightly' latest_release_tag: 'nightly'
# FIXME: point to `main` once merged
windows-installer: windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@main
needs: [ default_values ] needs: [ default_values ]
with: with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }} cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
@ -62,9 +61,8 @@ jobs:
operating_system: windows-2022 operating_system: windows-2022
secrets: inherit secrets: inherit
# FIXME: point to `main` once merged
linux-installer: linux-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@main
needs: [ default_values ] needs: [ default_values ]
with: with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }} cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
@ -75,9 +73,8 @@ jobs:
operating_system: ubuntu-22.04 operating_system: ubuntu-22.04
secrets: inherit secrets: inherit
# FIXME: point to `main` once merged
macos-installer: macos-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@main
needs: [ default_values ] needs: [ default_values ]
with: with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }} cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}
@ -88,9 +85,8 @@ jobs:
operating_system: self-hosted-X64 operating_system: self-hosted-X64
secrets: inherit secrets: inherit
# FIXME: point to `main` once merged
macos-arm-installer: macos-arm-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@main
needs: [ default_values ] needs: [ default_values ]
with: with:
cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }} cura_conan_version: ${{ needs.default_values.outputs.cura_conan_version }}

View File

@ -45,9 +45,8 @@ env:
STAGING: ${{ inputs.staging || false }} STAGING: ${{ inputs.staging || false }}
jobs: jobs:
# FIXME: point to `main` once merged
windows-installer: windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-linux.yml@main
with: with:
cura_conan_version: ${{ inputs.cura_conan_version }} cura_conan_version: ${{ inputs.cura_conan_version }}
conan_args: ${{ inputs.conan_args }} conan_args: ${{ inputs.conan_args }}

View File

@ -49,9 +49,8 @@ env:
STAGING: ${{ inputs.staging || false }} STAGING: ${{ inputs.staging || false }}
jobs: jobs:
# FIXME: point to `main` once merged
windows-installer: windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-macos.yml@main
with: with:
cura_conan_version: ${{ inputs.cura_conan_version }} cura_conan_version: ${{ inputs.cura_conan_version }}
conan_args: ${{ inputs.conan_args }} conan_args: ${{ inputs.conan_args }}

View File

@ -4,8 +4,7 @@ on:
pull_request_target: pull_request_target:
types: [ opened, reopened, edited, review_requested, ready_for_review, assigned ] types: [ opened, reopened, edited, review_requested, ready_for_review, assigned ]
# FIXME: Use `main` instead of `CURA-10831` once merged
jobs: jobs:
add_label: add_label:
uses: ultimaker/cura-workflows/.github/workflows/process-pull-request.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/process-pull-request.yml@main
secrets: inherit secrets: inherit

View File

@ -6,9 +6,8 @@ on:
types: [ completed ] types: [ completed ]
jobs: jobs:
# FIXME: Use `main` instead of `CURA-10831` once merged
publish-test-results: publish-test-results:
uses: ultimaker/cura-workflows/.github/workflows/unit-test-post.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/unit-test-post.yml@main
with: with:
event: ${{ github.event.workflow_run.event }} event: ${{ github.event.workflow_run.event }}
conclusion: ${{ github.event.workflow_run.conclusion }} conclusion: ${{ github.event.workflow_run.conclusion }}

View File

@ -45,15 +45,13 @@ env:
CONAN_PASSWORD: ${{ secrets.CONAN_PASS }} CONAN_PASSWORD: ${{ secrets.CONAN_PASS }}
jobs: jobs:
# FIXME: Change to `main` instead of `CURA-10831` once merged
conan-recipe-version: conan-recipe-version:
uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/conan-recipe-version.yml@main
with: with:
project_name: cura project_name: cura
testing: testing:
# FIXME: Change to `main` instead of `CURA-10831` once merged uses: ultimaker/cura-workflows/.github/workflows/unit-test.yml@main
uses: ultimaker/cura-workflows/.github/workflows/unit-test.yml@CURA-10831
needs: [ conan-recipe-version ] needs: [ conan-recipe-version ]
with: with:
recipe_id_full: ${{ needs.conan-recipe-version.outputs.recipe_id_full }} recipe_id_full: ${{ needs.conan-recipe-version.outputs.recipe_id_full }}

View File

@ -45,9 +45,8 @@ env:
STAGING: ${{ inputs.staging || false }} STAGING: ${{ inputs.staging || false }}
jobs: jobs:
# FIXME: point to `main` once merged
windows-installer: windows-installer:
uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@CURA-10831 uses: ultimaker/cura-workflows/.github/workflows/cura-installer-windows.yml@main
with: with:
cura_conan_version: ${{ inputs.cura_conan_version }} cura_conan_version: ${{ inputs.cura_conan_version }}
conan_args: ${{ inputs.conan_args }} conan_args: ${{ inputs.conan_args }}

View File

@ -1,18 +1,18 @@
version: "5.7.0-alpha.0" version: "5.7.0-alpha.0"
requirements: requirements:
- "uranium/(latest)@ultimaker/cura_10831" - "uranium/(latest)@ultimaker/latest"
- "curaengine/(latest)@ultimaker/cura_10831" - "curaengine/(latest)@ultimaker/latest"
- "cura_binary_data/(latest)@ultimaker/cura_10831" - "cura_binary_data/(latest)@ultimaker/latest"
- "fdm_materials/(latest)@ultimaker/cura_10831" - "fdm_materials/(latest)@ultimaker/latest"
- "curaengine_plugin_gradual_flow/(latest)@ultimaker/cura_10831" - "curaengine_plugin_gradual_flow/(latest)@ultimaker/stable"
- "dulcificum/(latest)@ultimaker/cura_10831" - "dulcificum/(latest)@ultimaker/latest"
- "pyarcus/5.3.0" - "pyarcus/5.3.0"
- "pysavitar/5.3.0" - "pysavitar/5.3.0"
- "pynest2d/5.3.0" - "pynest2d/5.3.0"
- "curaengine_grpc_definitions/(latest)@ultimaker/cura_10831" - "curaengine_grpc_definitions/(latest)@ultimaker/latest"
requirements_internal: requirements_internal:
- "fdm_materials/(latest)@internal/cura_10831" - "fdm_materials/(latest)@internal/latest"
- "cura_private_data/(latest)@internal/cura_10831" - "cura_private_data/(latest)@internal/latest"
urls: urls:
default: default:
cloud_api_root: "https://api.ultimaker.com" cloud_api_root: "https://api.ultimaker.com"