From f44d4d341f50b0c96e3a3ccf57d360c9c6908a6e Mon Sep 17 00:00:00 2001
From: Jaime van Kessel <nallath@gmail.com>
Date: Wed, 12 Jan 2022 15:57:20 +0100
Subject: [PATCH] Apply suggestions from code review

Minor codestyle issues

CURA-8683

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
---
 resources/qml/Menus/NozzleMenu.qml | 7 ++-----
 resources/qml/Menus/ViewMenu.qml   | 2 +-
 resources/qml/Widgets/MenuItem.qml | 2 +-
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/resources/qml/Menus/NozzleMenu.qml b/resources/qml/Menus/NozzleMenu.qml
index 973cf1fb09..7afe2b48bc 100644
--- a/resources/qml/Menus/NozzleMenu.qml
+++ b/resources/qml/Menus/NozzleMenu.qml
@@ -46,13 +46,10 @@ UM.Menu
                 var extruder = activeMachine.extruderList[extruderIndex]
                 return (extruder === undefined) ? false : extruder.isEnabled
             }
-            onTriggered:Cura.MachineManager.setVariant(nozzleMenu.extruderIndex, model.container_node)
+            onTriggered: Cura.MachineManager.setVariant(nozzleMenu.extruderIndex, model.container_node)
         }
 
-        onObjectAdded:
-        {
-            nozzleMenu.insertItem(index, object)
-        }
+        onObjectAdded: nozzleMenu.insertItem(index, object)
         onObjectRemoved: nozzleMenu.removeItem(object)
     }
 
diff --git a/resources/qml/Menus/ViewMenu.qml b/resources/qml/Menus/ViewMenu.qml
index 0b6489bf9a..d38bf536b0 100644
--- a/resources/qml/Menus/ViewMenu.qml
+++ b/resources/qml/Menus/ViewMenu.qml
@@ -27,7 +27,7 @@ Menu
     {
         id: cameraViewMenu
 
-        title: catalog.i18nc("@action:inmenu menubar:view","Camera view")
+        title: catalog.i18nc("@action:inmenu menubar:view", "Camera view")
         property string cameraMode: UM.Preferences.getValue("general/camera_perspective_mode")
 
         Connections
diff --git a/resources/qml/Widgets/MenuItem.qml b/resources/qml/Widgets/MenuItem.qml
index 8861da1eac..dd3f40b49a 100644
--- a/resources/qml/Widgets/MenuItem.qml
+++ b/resources/qml/Widgets/MenuItem.qml
@@ -15,7 +15,7 @@ MenuItem
 
     implicitHeight: UM.Theme.getSize("setting_control").height + UM.Theme.getSize("narrow_margin").height
     opacity: enabled ? 1.0 : 0.5
-    height: visible ? implicitHeight: 0
+    height: visible ? implicitHeight : 0
 
     arrow: UM.RecolorImage
     {