From f7ef24819dab49f7059efe6fe922428b1c3d5960 Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Thu, 9 May 2019 16:23:12 +0200 Subject: [PATCH] Remove unused code I'm not sure why loadConfigurationFromPrinter is not used... but it's not. Contributes to CL-1331 --- .../src/DiscoverUM3Action.py | 27 ------------------- 1 file changed, 27 deletions(-) diff --git a/plugins/UM3NetworkPrinting/src/DiscoverUM3Action.py b/plugins/UM3NetworkPrinting/src/DiscoverUM3Action.py index 6b6e466219..76d898b840 100644 --- a/plugins/UM3NetworkPrinting/src/DiscoverUM3Action.py +++ b/plugins/UM3NetworkPrinting/src/DiscoverUM3Action.py @@ -108,33 +108,11 @@ class DiscoverUM3Action(MachineAction): else: return [] - # # TODO: Should be able to just access the API from QML. - # @pyqtSlot(str) - # def setGroupName(self, group_name: str) -> None: - # self._api.machines.setCurrentMachineGroupName(group_name) - # if self._network_plugin: - # self._network_plugin.refreshConnections() - - # # TODO: Should be able to just access the API from QML. - # @pyqtSlot(QObject) - # def associateActiveMachineWithPrinterDevice(self, output_device: Optional["PrinterOutputDevice"]) -> None: - # self._api.machines.addOutputDeviceToCurrentMachine(output_device) - @pyqtSlot() def refreshConnections(self) -> None: if self._network_plugin: self._network_plugin.refreshConnections() - # # TODO: Better naming needed. Stored where? This is current machine's key. - # # TODO: CHANGE TO HOSTNAME - # # TODO: Should be able to just access the API from QML. - # @pyqtSlot(result = str) - # def getStoredKey(self) -> str: - # current_machine = self._api.machines.getCurrentMachine() - # if current_machine: - # return current_machine["um_network_key"] - # return "" - # TODO: CHANGE TO HOSTNAME @pyqtSlot(result = str) def getLastManualEntryKey(self) -> str: @@ -150,11 +128,6 @@ class DiscoverUM3Action(MachineAction): containers = CuraContainerRegistry.getInstance().findContainerStacks(type="machine", **metadata_filter) return bool(containers) - # TODO: Should be able to just access the API from QML. - @pyqtSlot() - def loadConfigurationFromPrinter(self) -> None: - self._api.machines.updateCurrentMachineConfiguration() - def _createAdditionalComponentsView(self) -> None: Logger.log("d", "Creating additional ui components for UM3.")