From f8d9f1e39c98546a31705d4b6fe489427f750810 Mon Sep 17 00:00:00 2001 From: casper Date: Mon, 29 Nov 2021 11:55:33 +0100 Subject: [PATCH] Use `visible` property of `Rectangle` rather than defining a separate property CURA-8564 --- plugins/Marketplace/resources/qml/Marketplace.qml | 2 +- plugins/Marketplace/resources/qml/OnboardBanner.qml | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/plugins/Marketplace/resources/qml/Marketplace.qml b/plugins/Marketplace/resources/qml/Marketplace.qml index fe1c967a42..1ae82adfff 100644 --- a/plugins/Marketplace/resources/qml/Marketplace.qml +++ b/plugins/Marketplace/resources/qml/Marketplace.qml @@ -50,7 +50,7 @@ Window OnboardBanner { - bannerVisible: content.item && content.item.bannerVisible + visible: content.item && content.item.bannerVisible bannerText: content.item && content.item.bannerText bannerIcon: content.item && content.item.bannerIcon onRemoveBanner: content.item && content.item.onRemoveBanner diff --git a/plugins/Marketplace/resources/qml/OnboardBanner.qml b/plugins/Marketplace/resources/qml/OnboardBanner.qml index 8d68512878..4a65297816 100644 --- a/plugins/Marketplace/resources/qml/OnboardBanner.qml +++ b/plugins/Marketplace/resources/qml/OnboardBanner.qml @@ -11,14 +11,11 @@ import Cura 1.6 as Cura // Onboarding banner. Rectangle { - property bool bannerVisible property string bannerIcon property string bannerText property var onRemoveBanner property string readMoreUrl - visible: bannerVisible - Layout.preferredHeight: childrenRect.height + 2 * UM.Theme.getSize("default_margin").height anchors {