From fec488898976f8bd38317fb7d624e9731eff6466 Mon Sep 17 00:00:00 2001
From: "p.kuiper"
Date: Thu, 2 Jun 2022 09:01:26 +0200
Subject: [PATCH] Clean up of jerk settings. Moved the jerk setting up to
ultimaker.def.json. Removed duplicate entries in quality profiles and removed
a number of strange jerk entries in the quality profiles.
Relates to PP-19
---
resources/definitions/ultimaker.def.json | 53 +++++++++++++++++--
resources/definitions/ultimaker3.def.json | 14 -----
resources/definitions/ultimaker_s3.def.json | 14 -----
resources/definitions/ultimaker_s5.def.json | 14 -----
...s3_aa0.4_CPEP_Fast_Print_Accurate.inst.cfg | 6 ---
...a0.4_TPLA_Normal_Quality_Accurate.inst.cfg | 6 ---
...aa0.4_ABS_Normal_Quality_Accurate.inst.cfg | 6 ---
...s5_aa0.4_PETG_Fast_Print_Accurate.inst.cfg | 6 ---
.../um_s3_aa0.4_CPEP_High_Quality.inst.cfg | 1 -
.../um_s5_aa0.4_CPEP_High_Quality.inst.cfg | 1 -
.../um_s5_aa0.4_TPLA_Draft_Print.inst.cfg | 1 -
11 files changed, 50 insertions(+), 72 deletions(-)
diff --git a/resources/definitions/ultimaker.def.json b/resources/definitions/ultimaker.def.json
index 2946a06c6d..3b4e830238 100644
--- a/resources/definitions/ultimaker.def.json
+++ b/resources/definitions/ultimaker.def.json
@@ -89,9 +89,6 @@
"meshfix_maximum_deviation": {
"value": "machine_nozzle_size / 10"
},
- "jerk_travel": {
- "value": "jerk_print"
- },
"acceleration_travel": {
"value": "acceleration_wall"
},
@@ -154,6 +151,56 @@
},
"bridge_fan_speed_3": {
"value": "cool_fan_speed_min"
+ },
+ "bridge_fan_speed_3": {
+ "value": "cool_fan_speed_min"
+ },
+ "jerk_print": {
+ "value": "20",
+ "minimum_value_warning": 20
+ },
+ "jerk_infill": {
+ "minimum_value_warning": 20
+ },
+ "jerk_wall": {
+ "minimum_value_warning": 20
+ },
+ "jerk_wall_0": {
+ "minimum_value_warning": 20
+ },
+ "jerk_roofing": {
+ "minimum_value_warning": 20
+ },
+ "jerk_topbottom": {
+ "minimum_value_warning": 20
+ },
+ "jerk_support": {
+ "minimum_value_warning": 20
+ },
+ "jerk_support_infill": {
+ "minimum_value_warning": 20
+ },
+ "jerk_support_interface": {
+ "minimum_value_warning": 20
+ },
+ "jerk_prime_tower": {
+ "minimum_value_warning": 20
+ },
+ "jerk_layer_0": {
+ "minimum_value_warning": 20
+ },
+ "jerk_print_layer_0": {
+ "minimum_value_warning": 20
+ },
+ "jerk_travel": {
+ "value": "jerk_print",
+ "minimum_value_warning": 20
+ },
+ "jerk_travel_layer_0": {
+ "minimum_value_warning": 20
+ },
+ "jerk_skirt_brim": {
+ "minimum_value_warning": 20
}
}
}
diff --git a/resources/definitions/ultimaker3.def.json b/resources/definitions/ultimaker3.def.json
index 5505cf4ddf..99e4ab4176 100644
--- a/resources/definitions/ultimaker3.def.json
+++ b/resources/definitions/ultimaker3.def.json
@@ -101,20 +101,6 @@
"infill_wipe_dist": { "value": "0" },
"initial_layer_line_width_factor": { "value": "120" },
"jerk_enabled": { "value": "True" },
- "jerk_print": { "value": "20", "minimum_value_warning": 20 },
- "jerk_infill": {"minimum_value_warning": 20 },
- "jerk_wall": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_wall_0": { "value": "jerk_wall", "minimum_value_warning": 20 },
- "jerk_roofing": {"minimum_value_warning": 20 },
- "jerk_topbottom": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support_infill": {"value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support_interface": {"value": "jerk_topbottom", "minimum_value_warning": 20},
- "jerk_prime_tower": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_layer_0": { "value": "jerk_topbottom", "minimum_value_warning": 20},
- "jerk_print_layer_0": {"value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_travel_layer_0": {"value": "jerk_travel", "minimum_value_warning": 20 },
- "jerk_skirt_brim": {"value": "jerk_print", "minimum_value_warning": 20 },
"layer_height_0": { "value": "round(machine_nozzle_size / 1.5, 2)" },
"layer_start_x": { "value": "sum(extruderValues('machine_extruder_start_pos_x')) / len(extruderValues('machine_extruder_start_pos_x'))" },
"layer_start_y": { "value": "sum(extruderValues('machine_extruder_start_pos_y')) / len(extruderValues('machine_extruder_start_pos_y'))" },
diff --git a/resources/definitions/ultimaker_s3.def.json b/resources/definitions/ultimaker_s3.def.json
index 5761b09c19..cff2fe741d 100644
--- a/resources/definitions/ultimaker_s3.def.json
+++ b/resources/definitions/ultimaker_s3.def.json
@@ -93,20 +93,6 @@
"infill_pattern": { "value": "'zigzag' if infill_sparse_density > 80 else 'triangles'" },
"infill_wipe_dist": { "value": "0" },
"jerk_enabled": { "value": "True" },
- "jerk_print": { "value": "20", "minimum_value_warning": 20 },
- "jerk_infill": {"minimum_value_warning": 20 },
- "jerk_wall": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_wall_0": { "value": "jerk_wall", "minimum_value_warning": 20 },
- "jerk_roofing": {"minimum_value_warning": 20 },
- "jerk_topbottom": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support_infill": {"value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support_interface": {"value": "jerk_topbottom", "minimum_value_warning": 20},
- "jerk_prime_tower": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_layer_0": { "value": "jerk_topbottom", "minimum_value_warning": 20},
- "jerk_print_layer_0": {"value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_travel_layer_0": {"value": "jerk_travel", "minimum_value_warning": 20 },
- "jerk_skirt_brim": {"value": "jerk_print", "minimum_value_warning": 20 },
"layer_height_0": { "value": "round(machine_nozzle_size / 1.5, 2)" },
"layer_start_x": { "value": "sum(extruderValues('machine_extruder_start_pos_x')) / len(extruderValues('machine_extruder_start_pos_x'))" },
"layer_start_y": { "value": "sum(extruderValues('machine_extruder_start_pos_y')) / len(extruderValues('machine_extruder_start_pos_y'))" },
diff --git a/resources/definitions/ultimaker_s5.def.json b/resources/definitions/ultimaker_s5.def.json
index bfd80caeab..f59250f908 100644
--- a/resources/definitions/ultimaker_s5.def.json
+++ b/resources/definitions/ultimaker_s5.def.json
@@ -95,20 +95,6 @@
"infill_pattern": { "value": "'zigzag' if infill_sparse_density > 80 else 'triangles'" },
"infill_wipe_dist": { "value": "0" },
"jerk_enabled": { "value": "True" },
- "jerk_print": { "value": "20", "minimum_value_warning": 20 },
- "jerk_infill": {"minimum_value_warning": 20 },
- "jerk_wall": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_wall_0": { "value": "jerk_wall", "minimum_value_warning": 20 },
- "jerk_roofing": {"minimum_value_warning": 20 },
- "jerk_topbottom": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support_infill": {"value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_support_interface": {"value": "jerk_topbottom", "minimum_value_warning": 20},
- "jerk_prime_tower": { "value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_layer_0": { "value": "jerk_topbottom", "minimum_value_warning": 20},
- "jerk_print_layer_0": {"value": "jerk_print", "minimum_value_warning": 20 },
- "jerk_travel_layer_0": {"value": "jerk_travel", "minimum_value_warning": 20 },
- "jerk_skirt_brim": {"value": "jerk_print", "minimum_value_warning": 20 },
"layer_height_0": { "value": "round(machine_nozzle_size / 1.5, 2)" },
"layer_start_x": { "value": "sum(extruderValues('machine_extruder_start_pos_x')) / len(extruderValues('machine_extruder_start_pos_x'))" },
"layer_start_y": { "value": "sum(extruderValues('machine_extruder_start_pos_y')) / len(extruderValues('machine_extruder_start_pos_y'))" },
diff --git a/resources/intent/ultimaker_s3/um_s3_aa0.4_CPEP_Fast_Print_Accurate.inst.cfg b/resources/intent/ultimaker_s3/um_s3_aa0.4_CPEP_Fast_Print_Accurate.inst.cfg
index 48fb654a87..b74cd522ac 100644
--- a/resources/intent/ultimaker_s3/um_s3_aa0.4_CPEP_Fast_Print_Accurate.inst.cfg
+++ b/resources/intent/ultimaker_s3/um_s3_aa0.4_CPEP_Fast_Print_Accurate.inst.cfg
@@ -14,12 +14,6 @@ variant = AA 0.4
[values]
jerk_print = 30
-jerk_infill = =jerk_print
-jerk_topbottom = =jerk_print
-jerk_wall = =jerk_print
-jerk_wall_0 = =jerk_wall
-jerk_wall_x = =jerk_wall
-jerk_layer_0 = 5
speed_print = 30
speed_infill = =speed_print
diff --git a/resources/intent/ultimaker_s3/um_s3_aa0.4_TPLA_Normal_Quality_Accurate.inst.cfg b/resources/intent/ultimaker_s3/um_s3_aa0.4_TPLA_Normal_Quality_Accurate.inst.cfg
index 0ca960acd7..b92e07a877 100644
--- a/resources/intent/ultimaker_s3/um_s3_aa0.4_TPLA_Normal_Quality_Accurate.inst.cfg
+++ b/resources/intent/ultimaker_s3/um_s3_aa0.4_TPLA_Normal_Quality_Accurate.inst.cfg
@@ -14,12 +14,6 @@ variant = AA 0.4
[values]
jerk_print = 30
-jerk_infill = =jerk_print
-jerk_topbottom = =jerk_print
-jerk_wall = =jerk_print
-jerk_wall_0 = =jerk_wall
-jerk_wall_x = =jerk_wall
-jerk_layer_0 = 5
speed_print = 30
speed_infill = =speed_print
diff --git a/resources/intent/ultimaker_s5/um_s5_aa0.4_ABS_Normal_Quality_Accurate.inst.cfg b/resources/intent/ultimaker_s5/um_s5_aa0.4_ABS_Normal_Quality_Accurate.inst.cfg
index 1fcbb95940..44f76d561f 100644
--- a/resources/intent/ultimaker_s5/um_s5_aa0.4_ABS_Normal_Quality_Accurate.inst.cfg
+++ b/resources/intent/ultimaker_s5/um_s5_aa0.4_ABS_Normal_Quality_Accurate.inst.cfg
@@ -14,12 +14,6 @@ variant = AA 0.4
[values]
jerk_print = 30
-jerk_infill = =jerk_print
-jerk_topbottom = =jerk_print
-jerk_wall = =jerk_print
-jerk_wall_0 = =jerk_wall
-jerk_wall_x = =jerk_wall
-jerk_layer_0 = 5
speed_print = 30
speed_infill = =speed_print
diff --git a/resources/intent/ultimaker_s5/um_s5_aa0.4_PETG_Fast_Print_Accurate.inst.cfg b/resources/intent/ultimaker_s5/um_s5_aa0.4_PETG_Fast_Print_Accurate.inst.cfg
index f13476802c..186281c17c 100644
--- a/resources/intent/ultimaker_s5/um_s5_aa0.4_PETG_Fast_Print_Accurate.inst.cfg
+++ b/resources/intent/ultimaker_s5/um_s5_aa0.4_PETG_Fast_Print_Accurate.inst.cfg
@@ -14,12 +14,6 @@ variant = AA 0.4
[values]
jerk_print = 30
-jerk_infill = =jerk_print
-jerk_topbottom = =jerk_print
-jerk_wall = =jerk_print
-jerk_wall_0 = =jerk_wall
-jerk_wall_x = =jerk_wall
-jerk_layer_0 = 5
speed_print = 30
speed_infill = =speed_print
diff --git a/resources/quality/ultimaker_s3/um_s3_aa0.4_CPEP_High_Quality.inst.cfg b/resources/quality/ultimaker_s3/um_s3_aa0.4_CPEP_High_Quality.inst.cfg
index f895647971..dbcd95a344 100644
--- a/resources/quality/ultimaker_s3/um_s3_aa0.4_CPEP_High_Quality.inst.cfg
+++ b/resources/quality/ultimaker_s3/um_s3_aa0.4_CPEP_High_Quality.inst.cfg
@@ -17,7 +17,6 @@ cool_min_speed = 5
infill_overlap = 0
infill_wipe_dist = 0
-jerk_enabled = True
jerk_print = 25
machine_min_cool_heat_time_window = 15
machine_nozzle_cool_down_speed = 0.85
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_CPEP_High_Quality.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_CPEP_High_Quality.inst.cfg
index eb4db520bd..d6749fb862 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_CPEP_High_Quality.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_CPEP_High_Quality.inst.cfg
@@ -17,7 +17,6 @@ cool_min_speed = 5
infill_overlap = 0
infill_wipe_dist = 0
-jerk_enabled = True
jerk_print = 25
machine_min_cool_heat_time_window = 15
machine_nozzle_cool_down_speed = 0.85
diff --git a/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_Draft_Print.inst.cfg b/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_Draft_Print.inst.cfg
index e102ff7ac3..535b85955a 100644
--- a/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_Draft_Print.inst.cfg
+++ b/resources/quality/ultimaker_s5/um_s5_aa0.4_TPLA_Draft_Print.inst.cfg
@@ -16,7 +16,6 @@ cool_fan_full_at_height = =layer_height_0 + 2 * layer_height
cool_fan_speed_max = =cool_fan_speed
cool_min_speed = 7
jerk_print = 25
-jerk_roofing = 1
layer_height_0 = 0.2
machine_nozzle_cool_down_speed = 0.75
machine_nozzle_heat_up_speed = 1.6