189 Commits

Author SHA1 Message Date
Lipu Fei
04c39824cb Fix typing 2019-04-26 15:39:28 +02:00
Jaime van Kessel
0d8b625bf8 Properly cache slice values to speed up sending the slice 2019-04-26 15:25:31 +02:00
Jaime van Kessel
42b1a0e028 Refactor some small bits of the setting override decorator
There was code duplication and a number of functions that should be private

contributes to #5603
2019-04-15 17:36:55 +02:00
fieldOfView
80c102f9de Add {travel_speed} as an alias to {speed_travel}...
...for all those people who still copy paste legacy start&end gcode snippets into Cura.
2019-02-01 10:45:32 +01:00
Jaime van Kessel
75ff03f3c8 Use setState instead of emitting the backend state
CURA-6016
2018-12-11 13:13:20 +01:00
Lipu Fei
c545d9df77 Add key check before accessing in ƒStartSliceJob
CURA-5901
2018-11-29 15:17:43 +01:00
Lipu Fei
bd42136712 Fix GcodeStartEndFormatter to use fallback values
CURA-5901

Use values from the global stack (if exist) as fallback values.
2018-11-27 09:49:38 +01:00
Lipu Fei
1951391a23 Merge remote-tracking branch 'origin/3.5' 2018-10-09 12:04:53 +02:00
alekseisasin
0b70b9a218
Merge pull request #4521 from Ultimaker/CURA-5799_fix_extruder_settings_to_curaengine
[3.5] CURA-5799 Fix sending extruder settings to curaengine
2018-10-09 11:53:46 +02:00
Jaime van Kessel
d98eafe041 Merge branch '3.5' of github.com:Ultimaker/Cura 2018-10-08 17:03:25 +02:00
Lipu Fei
5ba60de209 Send extruder settings ordered by extruder position
CURA-5799
2018-10-08 16:01:51 +02:00
Lipu Fei
3965218501 Fix value templating for gcode
CURA-5793

Fix GcodeStartEndFormatter to take the correct default_extruder_nr
instead of always using -1.
2018-10-08 14:42:22 +02:00
Ghostkeeper
bfc3c5d8d8
Merge branch 'feature_mesh_names' of https://github.com/paukstelis/Cura into paukstelis-feature_mesh_names 2018-09-28 13:26:15 +02:00
Ghostkeeper
1717281d2b
Always provide extruder_nr for all models
Even if you only have one extruder in your printer. This is more consistent, and probably also faster because executing one set-addition in Python is probably still slower than sending those 20 extra bytes over the socket and parsing them in C++...

Contributes to issue CURA-4410.
2018-09-27 11:20:24 +02:00
Jaime van Kessel
a8fc6aabcc Switch incorrect usage of getMachineExtruders to getActiveExtruderStacks 2018-09-07 16:27:56 +02:00
Lipu Fei
22ccf074f3 Only check if printing extruder is enabled for printing meshes
CURA-5669
2018-08-27 13:20:21 +02:00
paukstelis
e36f78dd35 Clean up whitespace 2018-08-24 07:27:34 -04:00
paukstelis
b66558f97a Initial commit for passing mesh names to CuraEngine 2018-08-19 22:52:17 -04:00
Diego Prado Gesto
bfaaa4a471 Fix code-style 2018-08-06 09:32:12 +02:00
Diego Prado Gesto
4491d5164a Fix the gcode start/end formatter.
Fixes #4181.
2018-08-06 09:24:48 +02:00
Aleksei S
817a304ed1 After reconecting to another port update job status '_is_cancelled' to false
CURA-5549
2018-07-13 23:50:02 +02:00
Ian Paschal
1c1b45541f
Merge branch 'master' into fix_tests_cura_engine_backend 2018-07-09 12:38:54 +02:00
Ghostkeeper
dec9d7cac6
Still store disabled extruders as a set
They should be unique anyway.

Contributes to issue CURA-5456.
2018-07-09 11:32:53 +02:00
Ian Paschal
c6b290e1e5 Fix broken slicing 2018-07-06 11:03:32 +02:00
Ian Paschal
2c291e02be Revert "Fixes for StartSliceJob"
This reverts commit 9ec5770a1c2f64c50aee6a279645320e5bff8fe0.
2018-07-06 10:54:24 +02:00
Ian Paschal
9ec5770a1c Fixes for StartSliceJob 2018-07-05 15:31:08 +02:00
Ghostkeeper
8f8c515438
Fix bug when default_extruder_nr is not provided
Then this would not slice because of a KeyError that is not caught.

Contributes to issue CURA-5457.
2018-07-05 12:51:27 +02:00
Ghostkeeper
ef2250b889
Don't check if keys are str
Our type checking should take care of that.
2018-07-05 12:31:42 +02:00
Mark
e1bc5d0f74 fix typing 2018-07-05 11:25:22 +02:00
Lipu Fei
dc8d9e0f96
Merge branch 'master' into mypy_fixes 2018-06-29 13:45:55 +02:00
Ghostkeeper
e957f7b650
Fix typing errors
Contributes to issue CURA-5330.
2018-06-15 15:07:08 +02:00
Ghostkeeper
75e5a185d9
Don't unnecessarily cast to a set
The InstanceContainer version of getAllKeys was first casting to a list but I removed that, because everywhere where we were using it we were casting it directly to a set.

Contributes to issue CURA-5330.
2018-06-15 13:07:55 +02:00
Jack Ha
f5dd7f6e92 CURA-5456 fixed typo, fixed multi objects with disabled extruders in message 2018-06-14 10:27:24 +02:00
Lipu Fei
439ea79c60 Add message for unable to slice due to disabled extruders
CURA-5456
2018-06-13 11:09:20 +02:00
Jack Ha
17b127e8c1 CURA-5249 replaced the extruder value of -1 by the more explicit defaultExtruderPosition, so now Cura is aware of the actual extruder position being used. Fixes linked icon next to support settings, like support_angle. 2018-06-06 11:00:09 +02:00
Ian Paschal
7f6a89e6aa Fixed bug that didn't do anything
Sometimes `None` was in the grouped objects which threw an error when trying to use `.callDecoration("isGroup")` on it. Nothing seems to break before, apart from the error message, and nothing breaks now either. But no error message. So that's good.
2018-03-21 09:52:03 +01:00
Ian Paschal
9dc50ec73f CURA-4400 Apply correct shader to grouped nodes 2018-03-20 16:54:34 +01:00
Ian Paschal
a7b2632739 CURA-4400 Recommended mode shows support extruders 2018-03-20 13:14:48 +01:00
Jack Ha
7ebd83f815 CURA-4400 get setting type from definition instead of whole stack improves speed of this call by a factor of 10 2018-03-14 10:21:10 +01:00
Jack Ha
e0e2d3362b CURA-4400 fix for change in fdmprinter: move -1 from default_value to value 2018-03-12 13:30:31 +01:00
Jack Ha
3edc96ec8f CURA-4400 fixed wrongly converted expression 2018-03-12 10:47:23 +01:00
Jack Ha
d70cc072e9 Merge branch 'master' into feature_enable_disable_extruder 2018-03-12 09:06:24 +01:00
Ian Paschal
6bee5bf1b0 CURA-4972 Tweak per review comments 2018-03-09 10:36:34 +01:00
Jack Ha
ff1c378c08 CURA-4400 fix start slicing when disabled extruder is incompatible 2018-03-07 11:38:35 +01:00
Jack Ha
32ce458516 CURA-4400 solved merge conflict 2018-03-06 17:05:39 +01:00
Aleksei S
6bb42da056 Removed related commits to Settins per Object validation and
added short validation in StartScliceJob
CURA-4972
2018-03-06 15:40:26 +01:00
Jack Ha
53ec846436 CURA-4400 introduced value -1 for extruder number setting (not optional_extruder); this one takes the defaultExtruderPosition in MachineManager 2018-03-01 17:21:35 +01:00
Jack Ha
11bad271d3 CURA-4400 set extruder numbers of settings to an enabled extruder; added SettingOverrideDecorator by default in CuraSceneNode 2018-02-28 15:56:45 +01:00
Jack Ha
f28bed9b4f CURA-4400 not sending objects that are printed with a disabled extruder 2018-02-28 12:56:39 +01:00
Aleksei S
ed7dec0cae Fix: per model settings validation
CURA-4972
2018-02-23 13:05:29 +01:00