7888 Commits

Author SHA1 Message Date
Ghostkeeper
16c5fdd798
Code style: Spaces around binary operators
Contrbutes to issue CURA-8224.
2021-05-06 16:27:09 +02:00
Jaime van Kessel
b2b10f693d
Rate limit the sending of materials to networked ultimakers
Some ultimakers tend to choke if you try and send a lot of materials in one go.

Previously we would also always send the materials on the main thread, which would also make
the interface freeze a bit. That should no longer happen.

The implementation of this is not really great, but since this is a hotfix i've opted to change
as little as possible.

CURA-8224
2021-05-06 15:43:39 +02:00
Kostas Karmas
9b58bf0490
Remove commented out code 2021-05-03 10:49:00 +02:00
Kostas Karmas
1347471fea
Remove unused function 2021-05-03 10:48:54 +02:00
Kostas Karmas
a6d311a0f2
Fix incompatible mypy type 2021-05-03 10:48:47 +02:00
Kostas Karmas
daa0826190
Fix mypy issues with the DigitalLibrary plugin 2021-05-03 10:48:40 +02:00
Jim Watson
653dd42e87
Fix for crashes on Mac 10.13 in 2010 era hardware
Not sure I understand why this works - size_x/y are for the end of the line not the start
2021-04-28 16:35:47 +02:00
Kostas Karmas
d972c505d0 Initial commit for the DL 2021-04-20 11:30:49 +02:00
Kostas Karmas
00ade8be3a Fix crashing if the quality_type_to_apply is None
Fixes sentry issue CURA-24D
2021-04-16 16:35:44 +02:00
Kostas Karmas
df5c52d1c6 Fail gracefully if writing the backup to a temp file crashes
Fixes sentry issue CURA-21W
2021-04-16 15:55:06 +02:00
Ghostkeeper
544b267447
Merge branch 'CURA-8004_fix_wrong_uploaded_print_job_cache' into 4.9 2021-04-16 12:05:06 +02:00
Remco Burema
1eb1a943b2
Process supposed to stop when already sending a job.
When using the visibility of the progress bar to detect if a job is already being sent, then make actually sure the progress bar is visible the moment the job starts, not at some unspecified time later in a method that might not even trigger if there is already a mesh ... so it's unlikely to even work, since the thing it was intended to prevent _very_ likely has the same mesh anyway.

CURA-8004
2021-04-15 16:53:01 +02:00
Kostas Karmas
ebdd21410e Merge branch '4.9' of https://github.com/Ultimaker/Cura into 4.9 2021-04-14 17:20:42 +02:00
Kostas Karmas
361bd8c6b1 Don't crash if the returned error has no title
Fixes sentry issue CURA-23P
2021-04-14 17:20:02 +02:00
Ghostkeeper
adb5f28aaf
Filter out disallowed characters from job name
Took a while to figure out exactly what to do here. But the task itself is simple.
The Ultimaker software apparently doesn't accept special characters here. The regex here is exactly the inverse of the regex that they use to accept job names.

Done as a 5 minute fix.
2021-04-14 16:56:17 +02:00
Remco Burema
4c5dac0dfd
Improve logging, UX for cloud-upload-errors.
One of the reasons this bug (see parent of this commit ... or the issue nr if you have internal access) was so vague is that A. the user was insufficiently prompted, and B. no one could find anything in our logs.

CURA-8004
2021-04-14 14:30:42 +02:00
Remco Burema
9227c303c6
Fix 'uploaded print-job cache' set before the mesh upload.
Since we use that to detect when the mesh is already uploaded, and thus can be reprinted, this could cause problems, since, while we do properly set it to None when an error is returned, if the request never returns to us, or if a reprint is started while the mesh is still uploading, the print-job cache could be set while the mesh wasn't actually there yet. Which could in theory have maybe caused the problems we see.

CURA-8004
2021-04-14 13:59:21 +02:00
Jaime van Kessel
43cc5fbca9
Add constant marker to supportsPrintJobQueue 2021-04-12 10:14:44 +02:00
Remco Burema
7f6133ca94
Merge pull request #9535 from Ultimaker/CURA-8093_Check_client_scope_when_upgrading_from_4.8
CURA-8093: Check client scope when upgrading from 4.8
2021-04-09 09:48:55 +02:00
Kostas Karmas
dca0612ee7 Add descriptive comment for deleting the user auth data
CURA-8093
2021-04-08 12:49:33 +02:00
Kostas Karmas
72080a3cca Delete the auth data on upgrade from 4.8 if the scope doesn't match
If the user account scope is outdated, delete it when upgrading from 4.8 to 4.9. This means that
the user will have to log in again, to make sure they get the correct account scope.

CURA-8093
2021-04-08 12:46:52 +02:00
Jaime van Kessel
d49a90029f
Fix final set of typing issues 2021-04-07 14:03:35 +02:00
Jaime van Kessel
00a360aca6
Don't overload types in AMFReader
The typing really doesn't like it if we first let a variable be a list and then
an numpy array
2021-04-07 11:32:09 +02:00
Kostas Karmas
39e9dcd4f5 Fix VersionUpgrade48to49 crashing if there is no "categories_expanded"
If the 4.8 is started from a clean install and no category gets expanded in the settings panel,
then the "categories_expanded" key will not exist in the [cura] preferences in cura.cfg.
As a result, when the 4.9 gets started in this specific case, the version upgrade 48 to 49 will
produce a crash and will be considered as "failed", which will then lead to cura requesting from
the user to go from the entire onboarding flow instead of landing on the "What's new" pages (even
though everything else has been properly updated).

This commit fixes that by checking whether the "categories_expanded" key exists in the cura.cfg.
2021-04-06 16:37:06 +02:00
Kostas Karmas
b2b258d357 Fix add script button list not working in MacOS
Fixed by using the qt quick controls 2

CURA-8127
2021-04-06 14:53:20 +02:00
Ghostkeeper
08be77adad
Increment SDK version to 7.5.0
The Cura 4.9 release will have expanded functionality. If you have a plug-in that uses this functionality, marking it as using SDK 7.5.0 will notify older Cura releases that they can't use that plug-in.
2021-04-06 13:28:08 +02:00
Kostas Karmas
081b0b23a4 Fix setting the time_remaining_method in the versionUpgrader
The DisplayProgressOnLCD script was changed and the "time_remaining" was split into two settings:
the "time_remaining" and the "time_remaining_method". If the "time_remaining" was enabled, the
"time_remaining_method" should be set to "m117".

The VersionUpgrader48to49 was changing the "time_remaining" to "m117" instead of changing the
"time_remaining_method", which was leading to the "time_remaining" having a wrong value and not
being interpreted as a boolean.

This commit fixes that by setting the "time_remaining_method" into "m117" when the "time_remaining"
was True.

CURA-8110
2021-04-06 11:38:28 +02:00
jelle Spijker
27fc435724
Bumped up stack version to 5
CURA-8110_upgrader
2021-04-02 15:02:38 +02:00
jelle Spijker
ebc4f45da6
Revert "Removed the upgrader for the machine and extruder stack"
This reverts commit 4707560d
2021-04-02 14:45:16 +02:00
jelle Spijker
72478994ec
Bumped up the Preference version to 7
reverted the SettingVersion to 16

CURA-8110_upgrader
2021-04-02 14:41:52 +02:00
jelle Spijker
4707560dcb
Removed the upgrader for the machine and extruder stack
It is known that will cause some user scripts to default behaviour.
But this is accepted behaviour, and the benefits of not upgrading
the Cura Application version outweigh this.
2021-04-02 14:03:37 +02:00
Jaime van Kessel
67e03e8763
Merge branch '4.9' of github.com:Ultimaker/Cura into CURA-8110_upgrader 2021-04-02 13:48:39 +02:00
jelle Spijker
33e345d1bc
Removed upgrader for instance containers
CURA-8810_version_upgrade
2021-04-02 10:41:14 +02:00
jelle Spijker
5885c5afee
Fixed documentation of upgradeSettingVisibility
CURA-8810_version_upgrade
2021-04-02 09:44:56 +02:00
jelle Spijker
51efeb9767
Upgrade expanded categories as well
CURA-8810_version_upgrade
2021-04-01 16:47:43 +02:00
jelle Spijker
77ea5e5e89
Allow setting visibilities to be upgraded
CURA-8810_version_upgrade
2021-04-01 16:15:47 +02:00
jelle Spijker
85fa07f6dd
Add top_bottom category to visible settings in preference
CURA-8810_version_upgrade
2021-04-01 14:22:32 +02:00
Ghostkeeper
27185c268d
Strip whitespace around package name for display
The actual package name internally will still have the spaces.
People were using this to get ahead in the sorting of packages, which is a little unfair. This doesn't make that impossible, but prevents it for the most part.
2021-03-31 16:10:36 +02:00
jelle Spijker
b05b36ae56
Added the VersionUpgrade48to49 plugin to bundled packages
CURA-8810_version_upgrade
2021-03-31 15:14:18 +02:00
Ghostkeeper
c85cf7b9cb
Add version upgrade plug-in for 4.9
Needed to happen at some point...

Contributes to issue CURA-7787.
2021-03-31 15:08:47 +02:00
Ghostkeeper
0787594a3d
Accept Griffin-style time estimation header
Otherwise it doesn't work for those printers.

Contributes to issue CURA-7787.
2021-03-31 15:08:33 +02:00
Jaime van Kessel
aed653546a
Merge branch 'CURA-8126_Fix_Toolbox_not_closing_instantly_after_quitting' of github.com:Ultimaker/Cura 2021-03-30 14:26:47 +02:00
Kostas Karmas
54b30f20a3 Fix Toolbox window not closing instantly after pressing "Quit Cura"
After installing a package and hitting the "Close Ultimaker Cura" button, the Toolbox window
was remaining open for a few seconds, even though the Cura window was instantly closing.

This is not fixed by explicitly hiding the Toolbox dialog once that button is pressed.

CURA-8126
2021-03-30 11:49:56 +02:00
Kostas Karmas
6abb029afd Fix marketplace button not directing to the web marketplace
We generally disabled the clicks in the mouseArea of the tooltips.
In this case though it should still accept the left click since it acts as a button.

CURA-8125
2021-03-30 11:40:03 +02:00
Kostas Karmas
189d00c3ed Fix toolbox not initializing due to enabledChanged signal
The Connections in qml is a QObject and it has an enabledChanged signal by default.
Therefore, we cannot really use the Connections to connect to the enabledChanged signal of e.g.
a python class, because qml complains that there is already a function named enabledChanged() in
the Connections.

To circumvent that, we can simply rename the enabledChanged() signal of the Toolbox to
toolboxEnabledChanged().
2021-03-30 09:02:56 +02:00
Kostas Karmas
7827b36ab7 Fix QML warnings due to depricated on<signal> calls in Connections
As of 5.12, the signals used in connections should not be declared as on<signal>, but as
function on<signal>(arguments).
2021-03-30 09:02:48 +02:00
pnt103
2ed40fe2c6
Get last position from previous layer instead.
Old code was next-next layer, which is actually the layer _after_ the one that is meant.

Fixes #9430
CURA-8116
2021-03-25 09:19:45 +01:00
Ghostkeeper
91fe9e8ebf
Merge branch 'patch-1' of https://github.com/EGOiST1991/Cura into EGOiST1991-patch-1 2021-03-23 13:57:00 +01:00
Ghostkeeper
2c33ebdd05
Document part of the vertex positions generated here
Encountered as I made a failed attempt at solving the issue with rendering transparent support. I tried to order vertices appropriately but failed miserably.
2021-03-21 23:15:15 +01:00
Ghostkeeper
bcf180985d
Fix crash when adding USB device before global stack is created
Like when you plug in a 3D printer via USB while still in the welcome screen.

Fixes Sentry issue CURA-1ZR.
2021-03-18 16:17:09 +01:00