5901 Commits

Author SHA1 Message Date
Remco Burema
a8570920bd Make it work in dark-mode again.
part of CURA-9522
2022-12-27 12:32:23 +01:00
Remco Burema
d351458b10 Make identifier unique and call the correct one.
Wouldn't start for me without (from source, on Windows).

part of CURA-9522
2022-12-27 12:11:21 +01:00
Remco Burema
634288a37c Fix spelling mistakes.
part of CURA-9522
2022-12-27 12:09:47 +01:00
c.lamboo
e490250d9d Clean up code
Create separate re-usable component for `MaterialBrandSubMenu`

CURA-9522
2022-12-23 19:40:27 +01:00
c.lamboo
20fdf22e35 Show bottom border of material brands
CURA-9522
2022-12-23 16:18:55 +01:00
c.lamboo
ab49dcceb5 Show bottom border of material brands
CURA-9522
2022-12-23 16:18:54 +01:00
c.lamboo
0ecfdd063d Show bottom border of material brands
CURA-9522
2022-12-23 16:12:25 +01:00
c.lamboo
5a8bf7f37b Fix material colors not showing up
CURA-9522
2022-12-23 16:11:06 +01:00
c.lamboo
92e6d5007f Remove unused property
CURA-9793
2022-12-23 14:21:12 +01:00
Casper Lamboo
15761b6c59
Code style
CURA-9522
2022-12-23 13:51:32 +01:00
c.lamboo
93a51b6da9 Remove unused property
CURA-9522
2022-12-23 13:40:20 +01:00
Joey de l'Arago
e0a091e768 Add scrollview to nested material list
CURA-6867
2022-12-20 18:06:40 +01:00
Joey de l'Arago
d4679515b6 Add scrollview to material list
CURA-6867
2022-12-20 17:45:28 +01:00
Joey de l'Arago
7174861bba Move popups back on screen after opening them.
CURA-6867
2022-12-20 15:26:46 +01:00
Joey de l'Arago
0a4c7869e6 Merge branch 'main' into CURA-9622_unable_to_scroll_long_materials_list 2022-12-20 13:46:32 +01:00
c.lamboo
f6d18266e6 Give the default settings pannel a max-height
CURA-9793
2022-12-15 13:37:28 +01:00
c.lamboo
ffb59b2894 Move width, height properties to top of component
CURA-9793
2022-12-14 17:44:08 +01:00
c.lamboo
2c7bd7883a Make recommended mode-window scrollable
CURA-9793
2022-12-13 17:05:51 +01:00
c.lamboo
83603ec8fa Center extruder icon in recommended settings
CURA-9793
2022-12-13 14:36:27 +01:00
c.lamboo
564fefa1c7 Fix updating value with "," instead of "." in reccomended mode
Fixed by correctly parsing dot in `SingleSettingTextField`.

CURA-9793
2022-12-13 11:46:06 +01:00
Casper Lamboo
e558752ed0
Merge pull request #13972 from Ultimaker/CURA-9793_extend_recommended_print_settings
[CURA-9793] Extend recommended print settings
2022-12-12 14:38:46 +01:00
Joey de l'Arago
e05c70ae38 Refactor ComponentWithIcon to use contents instead of loader.
CURA-9793
2022-12-12 14:22:38 +01:00
Joey de l'Arago
8780a2c4a0 Move validators to top of file.
CURA-9793
2022-12-12 14:12:32 +01:00
Joey de l'Arago
c6cc9ee6ec Update validators for SettingTextField to use strings from our validators. You can't access the components directly from javascript without instantiating them so they are instantiated here first.
CURA-9793
2022-12-12 14:06:45 +01:00
c.lamboo
7e8eca3b03 Fix size of ColorDialog
CURA-9997
2022-12-12 11:58:22 +01:00
Joey de l'Arago
1e6184448c
Apply suggestions from code review
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-12 11:44:21 +01:00
c.lamboo
e03b4e07f9 Simplify rounding
Use sliders stepSize and snapMode properties

CURA-9793
2022-12-08 17:11:04 +01:00
c.lamboo
aaab633912 Move labels into Slider component
CURA-9793
2022-12-08 16:23:05 +01:00
Joey de l'Arago
4f4d2431fa The third nested popup will now always try to stay withen the vertical space of the root materials popup.
See CURA-9522 for diagrams and more information.

CURA-9522
2022-12-08 16:18:58 +01:00
Joey de l'Arago
e6f4055df5 Remove part of hack for fixing extrudersCHanged signal at the wrong time.
Other things rely on the extruders changed signal so it is better to just emit it again at the correct time.

CURA-9793
2022-12-08 13:11:14 +01:00
Joey de l'Arago
82fd34f168 Fix same property value check.
CURA-9793
2022-12-08 09:56:36 +01:00
Joey de l'Arago
435c67f97a revert changes to functions
CURA-9793
2022-12-08 09:53:06 +01:00
Joey de l'Arago
9a03094bfd Stop the text field from updating if the text has not changed. This was causing the custom mode text boxes to be updated instantly.
0.0 -delete-> 0. -instant update -> 0.0

 This is because the recommended mode text fields would update to "0." see that as a change from "0.0" and update the property. This triggered an update in the Custom mode textfield.

CURA-9793
2022-12-08 09:34:32 +01:00
Jelle Spijker
91170e0aef
Apply suggestions from code review 2022-12-08 07:43:57 +01:00
Joey de l'Arago
bcdfa808a8 Switch to checking enabled extruder count for showing print with Component. This is because we want the SingleSettingExtruderBar to be hidden when there are 1 or less extruders, but also when there are 1 or less enabled extruders.
CURA-9793
2022-12-07 17:33:13 +01:00
Joey de l'Arago
ca0cd5069b Remove leftover print statements
CURA-9793
2022-12-07 17:30:12 +01:00
Joey de l'Arago
8012cb5360 Signal are being emmitted before settings are updated. This is causing the combobox to update with the previous value. Only when using infill_pattern setting though. No idea what is causing this. This is a workaround for now.
CURA-9793
2022-12-07 17:16:26 +01:00
Joey de l'Arago
443252ae10 Use globalStackExtruderIds instead of extruderIds. extruderIds notifys change before the extruders change when doing a machine swap. Fixing this will take a long time so this is a workaround. If you are reading this 🙏 good luck fixing it 🙏
CURA-9793
2022-12-07 16:57:35 +01:00
Joey de l'Arago
f601229390 Move Validators to UM, so they can be used in UM components.
Update all TextFieldWithUnit to use our FloatValidator. This component now has proper styling when the input is invalid. The DoubleValidator was flagging numbers with a "." in them as an incorrect input (I assume this is because the region was set to europe on the OS where "," is common). The workaround is to use our FloatValidator which validates both "." and ","

CURA-9793
2022-12-07 16:27:42 +01:00
Joey de l'Arago
0e5ad96207 Fix bad call to keys function on string.
Also fix assigning currentIndex to correct Component.

CURA-9793
2022-12-07 16:15:09 +01:00
Joey de l'Arago
396057a56f Correct typo in name
CURA-9793
2022-12-07 16:14:17 +01:00
jspijker
0bdb04ccf6 Merge branch 'main' into CURA-9793_extend_recommended_print_settings 2022-12-07 10:16:17 +01:00
Joey de l'Arago
03fac1bc7f Make the width of the ProfileWarningREset 0 when it is hidden.
Expand the profile selection dropdown when the ProfileWarningReset is hidden in the custom menu.
CURA-9793
2022-12-06 18:11:15 +01:00
Remco Burema
4ecc0a98bb Don't show reset for only custom profile when in custom mode.
part of CURA-9347
2022-12-06 17:07:29 +01:00
Remco Burema
067a40dbe8 Don't just disable the reset/safe buttons, hide them.
part of CURA-9347
2022-12-06 17:00:06 +01:00
Joey de l'Arago
4e8e5c2bf0 Merge remote-tracking branch 'origin/CURA-9622_unable_to_scroll_long_materials_list' into CURA-9622_unable_to_scroll_long_materials_list 2022-12-06 15:37:21 +01:00
Joey de l'Arago
3dff780215 Adjust location of popups so they align with their parent popup.
CURA-9793
2022-12-06 15:36:55 +01:00
Joey de l'Arago
e5baa6e2bf
Update resources/qml/Menus/MaterialBrandMenu.qml
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-06 15:18:32 +01:00
Joey de l'Arago
493f82620e Center Manage Profiles button
CURA-9793
2022-12-06 14:57:54 +01:00
Joey de l'Arago
491c501d8c Adjust margins and correctly vertical center buttons.
CURA-9793
2022-12-06 14:48:50 +01:00