9131 Commits

Author SHA1 Message Date
Jaime van Kessel
4ac8229c33
Clean up codestyle violations
Boyscouting! CURA-8463
2022-08-30 10:28:22 +02:00
Jaime van Kessel
36d3a92fc0
Fix gramar mistake in documentation
CURA-8463
2022-08-26 13:27:58 +02:00
joeydelarago
17e6bccf51 Create abstract printers when adding lan printers.
CURA-9514
2022-08-24 10:07:17 +02:00
jspijker
54e9dbf827 Show device name of failed machine creation in log
CURA-9277 Detect and Load Specific printers and Cloud Printer Types
2022-08-22 14:57:37 +02:00
Casper Lamboo
12f3581337
Assign result of createAbstractMachine to a variable
With prepended underscore to highlight the result of the function is not being used.

CURA-9277
2022-08-22 14:44:45 +02:00
c.lamboo
d7f119415f Use pretty-printed string for the AbstractMachine name
Cura-9277

Co-authored-by: joeydelarago <joeydelarago@gmail.com>
2022-08-19 16:35:00 +02:00
c.lamboo
761bf3b8fa Fix creating abstract machines on account sync
Cura-9277

Co-authored-by: joeydelarago <joeydelarago@gmail.com>
2022-08-19 14:44:19 +02:00
joeydelarago
b82f1f4a8c Add new Abstract machine stack type. This represents a type of printers (ultimaker_s3 etc).
These are created whenever a cloud printer of a new printer type is added.

CURA-9277

Co-authored-by: casperlamboo <c.lamboo@ultimaker.com>
2022-08-19 13:53:43 +02:00
digitalfrost
aed16cf849 PostProcessingPlugin/.../Stretch.py Use enumerate
Use enumerate instead of range(len
2022-08-10 10:47:18 +02:00
digitalfrost
72751b2507 Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 09:36:53 +02:00
digitalfrost
0f0815efab Use is not operator rather than not ...is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 09:33:26 +02:00
digitalfrost
d65e198e8c Use is not operator rather than not ...is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-08 09:28:26 +02:00
digitalfrost
2f9e5b00bb Use is not operator rather than not ... is
This is advocated by both PEP8 and the Google Python Style Guide
2022-08-07 10:09:33 +02:00
Jelle Spijker
7b768ca810
Merge pull request #12866 from Ultimaker/CURA-9220_hide_if_no_permission
Hide cloud interaction buttons if the user has no permissions to them
2022-08-01 12:41:11 +02:00
Ghostkeeper
8a55a2aff6
Further review suggestions
Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
7c1a254812
Add newlines before properties
As suggested in the code review.

Contributes to issue CURA-9220.

Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-08-01 10:47:57 +02:00
Ghostkeeper
a0f640586c
Add slice ID to example data
Contributes to issue CURA-9031.
2022-07-29 15:57:10 +02:00
j.spijker@ultimaker.com
a88e31eddd Add the slice_uuid to the slice info data
Contributes to CURA-9031
2022-07-27 18:13:09 +02:00
j.spijker@ultimaker.com
a712e7517a Add the received slice_uuid to the print information
Contributes to CURA-9031
2022-07-27 18:12:25 +02:00
Ghostkeeper
f849df6ba3
Remove old df_access additional right
It is replaced by the new permissions system. The rights are more specific than 'digital factory access, yes or no'. It's now about whether you can read/write printers/projects/print jobs/etc and can differ whether it is your own project/job/etc or someone else's.

Contributes to issue CURA-9220.
2022-07-26 17:49:55 +02:00
Ghostkeeper
615f16bda0
Hide 'show in browser' when the user can't visit the printer overview
No use then. They can't visit that page.

Contributes to issue CURA-9220.
2022-07-26 16:57:07 +02:00
Ghostkeeper
19ba092340
Add property of whether the printer details can be read
We'd assume so, but there is a permissions node for it. If it can't be read by the user, they can't navigate to the printer's overview page. So we should hide the button then.

Contributes to issue CURA-9220.
2022-07-26 16:56:19 +02:00
Ghostkeeper
e9f9730364
Don't show context menu button if it is empty
It will likely be empty for guest accounts on networks where the administrator is the only one with rights to access other people's prints.

Contributes to issue CURA-9220.
2022-07-26 16:36:38 +02:00
Ghostkeeper
5eb340e3f0
Check permissions before showing abort/pause/delete context buttons
The user needs permissions to do these things, so don't show them if the user can't use them.

Contributes to issue CURA-9220.
2022-07-25 17:34:34 +02:00
Ghostkeeper
99d93fa58a
Check if the user can change the queue before showing option
If the user can't change the queue of other prints, then it can't move prints to the top.

Contributes to issue CURA-9220.
2022-07-25 17:07:52 +02:00
Ghostkeeper
bef10b8b35
Hide print queue if the user can't read the print queue
If there are no permissions, this would result in an error and a supposedly empty queue. That's incorrect. It should make it more clear that the user has no permissions to view the queue, while appearing that it is the normal workflow (it is for that user). So hide the queue entirely, just like with the UM2+C.

Contributes to issue CURA-9220.
2022-07-25 16:57:47 +02:00
Ghostkeeper
9e1940dd4b
Move default behaviour up in inheritance hierarchy
This way, any new printer types we define will automatically get these properties that are used by the monitor stage anyway.

Contributes to issue CURA-9220.
2022-07-25 16:55:05 +02:00
Ghostkeeper
b4c4371929
Add properties of whether the queue can be manipulated
Not all printers can do that.

Contributes to issue CURA-9220.
2022-07-25 16:51:13 +02:00
Ghostkeeper
483911dc4a
Fix error of undefined property when using LAN printers
This property was defined for Cloud printers, but not for Network printers. In QML this then resulted in an error saying that null cannot be assigned to a bool (for the 'visible' property). The visible property then defaulted to its default, true. And so it was always visible, but still had an error.
The error is now solved so that I can also check for other properties in this visible check.

Contributes to issue CURA-9220.
2022-07-25 16:49:48 +02:00
c.lamboo
0afab9f9e9 Add label-string to translations 2022-07-18 10:40:41 +02:00
Jelle Spijker
1a0ecfd850
Merge branch '5.1'
# Conflicts:
#	.github/workflows/conan-package.yml
#	.github/workflows/cura-installer.yml
2022-07-14 16:30:52 +02:00
Evangelos Trantos
96c4e15c03
Merge pull request #12746 from Ultimaker/CURA-9465_dark_theme_issues
Fix multiple dark theme issues
2022-07-14 09:34:58 +02:00
Ghostkeeper
107d12856d
Remove fill colours from this icon
Otherwise the theme won't have any effect on it since 5.0.

Done as a 5 minute fix.
2022-07-13 17:35:19 +02:00
Jaime van Kessel
0fac778601
Fix postprocessing settings being too dark
In dark theme you couldn't really read them.

CURA-9465
2022-07-12 10:06:39 +02:00
jspijker
f9d4628b95 Merge branch 'main' into CURA-9365
# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/cura-installer.yml
#	.github/workflows/requirements-conan-package.txt
#	resources/definitions/Mark2_for_Ultimaker2.def.json
#	resources/definitions/elegoo_neptune_2.def.json
#	resources/definitions/elegoo_neptune_2D.def.json
2022-07-08 12:37:32 +02:00
Ghostkeeper
15c1b96d7b
Fix crash if a Digital Library project is made by deleted user
If the user that created a project has been deleted, the response from the API doesn't include a username. This crashes Cura because it had no default for the username.
The organization_shared field was also optional.

Done as a small fry to fix a bug found by a colleague.
2022-07-07 15:04:15 +02:00
Remco Burema
3dc646874d
Merge pull request #12634 from Ultimaker/CURA-9402_fix_background_dark_theme
Fix background dark theme
2022-07-01 14:30:10 +02:00
Remco Burema
ca36b4f2ef Set proper background color for open project dialogs.
part of CURA-9402
2022-07-01 14:22:27 +02:00
Jaime van Kessel
12379b15cd Use correct key for serialized setting to keep
'recommend cleaning after n prints' instead of 'recommended cleaning after n prints'

CURA-9432
2022-06-30 16:37:26 +02:00
Remco Burema
fab86be909 Keep settings throughout reserilization process.
Save some settings Cura doesn't use, but other consumers of the file might in the metadata during deserilization, so they can be properly re-serialized whenever exported.

part of CURA-9432
2022-06-30 14:14:11 +02:00
Ghostkeeper
795814d50b
Store unmapped settings in a separate set
We don't want to create actual settings for all of these. Just store them in the profile metadata and restore them.
Serialising and deserialising these is a bit more work than what I could do now in 5 minutes so we'll have to do that a bit later, but at least for now we have the complete list.

Contributes to issue CURA-9432.
2022-06-30 09:45:45 +02:00
Jaime van Kessel
ddb87656ff Add two recently introduced material settings
CURA-9432
2022-06-29 16:24:51 +02:00
Jaime van Kessel
91cd709b46 Properly set background for postprocessing plugin
CURA-9402
2022-06-29 10:56:08 +02:00
Ghostkeeper
adeb9da356
Merge branch '5.1' 2022-06-28 17:53:24 +02:00
Remco Burema
c4422b87f9
Merge pull request #12599 from Ultimaker/CURA-9414
Don't show scary error message when saving custom file
2022-06-28 13:07:21 +02:00
Remco Burema
1872e54842 Message might be good for debugging.
Maybe at some point someone will ask wjy they don't get a message.

part of CURA-9414
2022-06-28 13:06:59 +02:00
Ghostkeeper
96192adce2
Catch wrong cloud responses when it responds with a new file name
It could happen if there are bugs in the cloud, e.g. if they strip special characters somewhere.
We'd want to know it if they do. But we also don't want Cura to crash if the remote connection is not reliable, or if there's changes/bugs in the future.

Fixes Sentry issue CURA-42F.
2022-06-27 11:30:38 +02:00
c.lamboo
2c074fb7a3 Don't show scary error message when saving custom file
CURA-9414
2022-06-24 14:52:42 +02:00
j.delarago
9aaf59ae86 Suggested changes
CURA-9412
2022-06-24 14:29:50 +02:00
j.delarago
dd3abf7ff0 Add check for empty material instance containers before trying to fetch material metadata. This fixes failing to save a project on a printer with no materials (UM2 for example).
CURA-9412
2022-06-22 14:05:56 +02:00