26 Commits

Author SHA1 Message Date
Lipu Fei
4d7bf579e6 Do not keep triggering on changed in MA 2018-04-24 13:49:07 +02:00
Lipu Fei
c381f3707b Schedule model check for later if a machine change has not done yet
CURA-5239
2018-04-16 17:33:14 +02:00
Lipu Fei
e5d795cc0b Update model checker text
CURA-5237
2018-04-16 17:21:12 +02:00
Lipu Fei
4bb6962302 Rename model checker property to hasWarnings
CURA-5237
2018-04-16 17:20:40 +02:00
Diego Prado Gesto
04c21f3f30 CURA-4557 Minor changes in the message. 2018-03-26 11:52:39 +02:00
Ruben D
58205fb965
Make _getMaterialShrinkage protected
No need to expose this.

Contributes to issue CURA-4557.
2018-03-22 01:59:49 +01:00
Ruben D
5d51b75f4d
Remove unnecessary _has_warnings
We just always show the message because the button can only be pressed while there are warnings.

Contributes to issue CURA-4557.
2018-03-22 01:56:12 +01:00
Ruben D
8e6ee41124
Let shrinkage check set its own message
Another attempt to keep the shrinkage check contained to functions related to shrinkage more.

Contributes to issue CURA-4557.
2018-03-22 01:43:06 +01:00
Ruben D
329a0b121d
Move shrinkage parameters into shrinkage function
So that they are closer to where they are relevant if we're going to have more checks in this class.

Contributes to issue CURA-4557.
2018-03-22 01:38:34 +01:00
Ruben D
25e7cb457d
No need to create view again upon showing warnings
It is now already done when initialization is completed.

Contributes to issue CURA-4557.
2018-03-22 01:35:35 +01:00
Ruben D
15ad528aa5
Remove happy message
Since the button can only get shown when there is something wrong, the happy message can never be shown any more.

Contributes to issue CURA-4557.
2018-03-22 01:34:04 +01:00
Ruben D
5bf93a8398
Only display plug-in checker when there's really a warning
As discussed with LukeChen-Ultimaker, we only want to display a button when there is really something up with the current set-up, not when there might be something up. Most users will be confused to see a button that always says that everything is fine.

This also simplifies the signal handling a lot.

Contributes to issue CURA-4557.
2018-03-22 01:31:35 +01:00
Ruben D
987b475e3b
Remove unused parameter
Contributes to issue CURA-4557.
2018-03-22 00:48:23 +01:00
Ruben D
f5c1e59166
Call checkObjectsForShrinkage directly from runChecks
I'd like to transition to a state where you can read in runChecks all the checks that are being run. The former function checkAllSliceableNodes is now a helper function to list sliceable nodes.

Contributes to issue CURA-4557.
2018-03-22 00:46:29 +01:00
Ruben D
f91abf042f
Add documentation for globals
And maybe they should not be globals.

Contributes to issue CURA-4557.
2018-03-22 00:35:55 +01:00
Ruben D
55b247abbd
Hide outdated message if checking again
And if the result is different.

Contributes to issue CURA-4557.
2018-03-22 00:32:46 +01:00
Ruben D
37edce5976
Reuse message instances
Slightly more performant. And now if you click on the button again you won't get a spammy new message each time.

Contributes to issue CURA-4557.
2018-03-22 00:28:00 +01:00
Ruben D
ab7f10ea52
Make model checker warning easier to translate
It's often more clear to have a variable name in there so that the translator knows what'll be filled in for the variable.

Contributes to issue CURA-4557.
2018-03-22 00:20:10 +01:00
Ruben D
c7ba9f9e37
Improve wording of warning for too large models
A bit simpler English here.

Contributes to issue CURA-4557.
2018-03-22 00:18:12 +01:00
Ruben D
6646d898c2
Remove debug code
This code was put in to allow debugging before the branches are merged. We should just assume that the two branches get merged at the same time.

Contributes to issue CURA-4557.
2018-03-22 00:14:58 +01:00
Jack Ha
d8d226c0d6 CURA-4557 it's now a small button next to the job spec when one of the warping materials is selected 2018-03-21 16:55:58 +01:00
Jack Ha
9ea59c1976 CURA-4557 rename ratio percentage to percentage 2018-03-20 17:07:03 +01:00
Jack Ha
1aba1cfe6a CURA-4557 model checker is now a tool, click to activate 2018-03-20 16:30:11 +01:00
Jack Ha
e958516913 CURA-4557 add checking on material change as well 2018-03-19 16:50:35 +01:00
Jack Ha
ef7139d3b2 CURA-4557 First version of model checker 2018-03-19 16:17:24 +01:00
Jack Ha
50f9548da0 CURA-4557 setting up plugin 2018-03-15 14:33:31 +01:00