Ian Paschal
1f403f815d
CURA-4972 Moved validation to SettingOverrideDecorator.py
...
**The diagnosis:**
The issue arrises from the fact that while the original object is subscribed to be validated, that subscription is only created by setting it as a settings override object. A clone of that object, while still a settings-override object, never gets subscribed because it's not explicitly set with the tool.
**The solution (?):**
I moved all the validation stuff over to SettingOverrideDecorator.py, and use its onSettingChanged() function to trigger the validation. Unfortunately, I can't use the timer because of some limitation with QTTimer and threads. So it's _a bit laggy in some places, and I'd be open to tips about how to fix this. It does work reliably though.
2018-03-02 17:05:58 +01:00
Lipu Fei
355b8cbac3
Move renameQualityChangesGroup() into QualityManager
2018-03-02 16:58:50 +01:00
Lipu Fei
8324f4f44e
Move removeQualityChangesGroup() into QualityManager
2018-03-02 16:47:25 +01:00
Lipu Fei
6cae82a64e
Fix comments for createQualityChanges()
2018-03-02 16:42:10 +01:00
Lipu Fei
0944653412
Change VariantType to an Enum
2018-03-02 16:41:19 +01:00
Lipu Fei
fc36df2bea
Remove unnecessary comments in getQualityGroupsForMachineDefinition()
2018-03-02 16:37:23 +01:00
Lipu Fei
e340f8e534
Add documentation for getQualityGroups()
2018-03-02 16:34:42 +01:00
Lipu Fei
27f4574223
Remove some superfluous comments in QualityManager
2018-03-02 16:31:57 +01:00
Lipu Fei
29631fa8eb
Fix QualityManager doc
2018-03-02 16:25:16 +01:00
Lipu Fei
c6128ef5ba
Move setMaterialName() into MaterialManager
2018-03-02 16:22:22 +01:00
Lipu Fei
f7377e6321
Fix extruder_stacks.items()
2018-03-02 16:20:03 +01:00
Lipu Fei
d372fc75e7
Fix type hinting for getFallbackMaterialIdByMaterialType()
2018-03-02 16:16:51 +01:00
Lipu Fei
a6f22fd9cc
Remove unnecessary comments
2018-03-02 16:10:59 +01:00
Lipu Fei
2135e30aad
Simplify for loop in _calculateInformation()
2018-03-02 16:10:06 +01:00
Ghostkeeper
7b809becd9
Merge branch 'M&P-Setting-Optimization'
2018-03-02 15:22:54 +01:00
THeijmans
75d106368e
Retraction minimum travel fix
...
Retraction minimum travel distance set to two times the line width for all 0.4 and 0.8 mm TPU profiles.
2018-03-02 15:15:23 +01:00
THeijmans
0305ad1ea2
Zig_zaggifying the infills
...
Connected infill lines in all our profiles, for increased strenght and print quality.
2018-03-02 15:11:26 +01:00
THeijmans
e080ff2db0
Revert "Combing to "No Skin""
...
This reverts commit ca83089eff9f9ed3b8a37b1d593993662cb27e0c.
2018-03-02 15:04:33 +01:00
Ghostkeeper
acbc6893f5
Also allow backspace to delete models
...
See the documentation in the code as to why. Macintosh keyboards...
Fixes #3257 .
2018-03-02 14:51:13 +01:00
Lipu Fei
93190dde9b
Merge remote-tracking branch 'origin/master' into refactoring_machine_manager
2018-03-02 09:55:14 +01:00
Lipu Fei
1743954ef7
chmod a+x check_preset_settings.py
...
CURA-5032
2018-03-02 09:33:15 +01:00
Lipu Fei
c82b2f2f6c
Fix gcode flave RepRap for dagoma neva
...
CURA-4988
2018-03-02 09:29:38 +01:00
Lipu Fei
5351ce7d23
Fix dagoma discoeasy200 travel speed 100
...
CURA-4988
2018-03-02 09:29:03 +01:00
Lipu Fei
844a597e08
Fix materials models
2018-03-02 09:28:25 +01:00
Diego Prado Gesto
ae57e23eec
Create a mouse area around the sidebar to avoid propagating mouse wheel events.
...
Contributes to CURA-4495
2018-03-01 19:48:41 +01:00
Ian Paschal
feb3143874
CURA-5032 Settings for settings visibility
...
Settings groups now match specification.
2018-03-01 17:51:51 +01:00
Jack Ha
53ec846436
CURA-4400 introduced value -1 for extruder number setting (not optional_extruder); this one takes the defaultExtruderPosition in MachineManager
2018-03-01 17:21:35 +01:00
Lipu Fei
97059daf6a
Separate quality manager related classes into separate files
2018-03-01 16:37:01 +01:00
Lipu Fei
31d1a3b5db
Code style fix
2018-03-01 16:31:00 +01:00
Lipu Fei
59f31c9fe0
Add doc for quality settings model grouping
2018-03-01 16:29:56 +01:00
Lipu Fei
71e8478419
Rename to selected_position
2018-03-01 16:26:12 +01:00
Jack Ha
2538c689f1
CURA-4400 make extruder combobox disabled items grey
2018-03-01 16:22:40 +01:00
Lipu Fei
a81d124aae
Merge remote-tracking branch 'origin/master' into refactoring_machine_manager
2018-03-01 16:03:49 +01:00
Lipu Fei
afae550b5a
Store layer_height as float
2018-03-01 16:00:46 +01:00
Lipu Fei
e87077802f
Change to layer_height and layer_height_unit
2018-03-01 15:55:44 +01:00
Lipu Fei
b74e2553e7
Use more descriptive variable names
2018-03-01 15:47:52 +01:00
Lipu Fei
d1c518f6d7
Fix the usage of protected variables in quality models
2018-03-01 15:44:06 +01:00
Lipu Fei
06ec16d627
Rename quality drop down menu models
2018-03-01 15:37:48 +01:00
Lipu Fei
a395f93706
Add docs for quality models
2018-03-01 15:28:58 +01:00
Lipu Fei
52da140833
Add doc and copyright headers for MultiBuildPlateModel
2018-03-01 15:27:13 +01:00
Lipu Fei
c0604e5c75
Move MultiBuildPlateModel into Models folder
2018-03-01 15:25:11 +01:00
Lipu Fei
72b42113b3
Add doc for BrandMaterialsModel
2018-03-01 15:19:01 +01:00
Lipu Fei
d6f6dbe45e
Rename to available_material_dict
2018-03-01 15:12:34 +01:00
Lipu Fei
4b7c8a8a80
Add doc for BaseMaterialsModel
2018-03-01 15:09:58 +01:00
Lipu Fei
b4c3536999
Move getAvailableMaterials() into MaterialManager
2018-03-01 15:02:57 +01:00
Jack Ha
ba7b18a88b
CURA-4400 corrected getProperty in correctExtruderSettings
2018-03-01 15:02:35 +01:00
Ghostkeeper
7b794249f6
Add 512 padding bytes to the end of the g-code
...
Due to a bug in the firmware of the Ultimaker 2, the print was already ending before the last few commands were executed completely. It would then finish the last few commands in a different routine but the extrusion modifier wasn't applied there, resulting in a blob on your print.
This is a workaround that puts always one file system page (512 bytes) of padding at the end of the g-code file. If these comments are not executed that is fine. If they are then it's also fine. Until the bug is fixed in firmware, this will at least prevent the issue from occurring for users.
2018-03-01 13:33:14 +01:00
Jack Ha
ac76d6ea52
Merge branch 'refactoring_machine_manager' into feature_enable_disable_extruder
2018-03-01 13:14:10 +01:00
Jack Ha
71e631150d
CURA-4400 update extruder disabled color
2018-03-01 13:06:12 +01:00
Jack Ha
c94d88cd9d
CURA-4400 added context menu on right click extruder in SidebarHeader
2018-03-01 12:58:27 +01:00
