151 Commits

Author SHA1 Message Date
Jaime van Kessel
99bf6883d7
Set defaultExtruderIndex to activeExtruderIndex
This doesn't fix the problem in it's entirety, but it does make the behavior
to be the same as it was in the previous releases

CURA-10342
2023-02-28 11:50:54 +01:00
c.lamboo
564fefa1c7 Fix updating value with "," instead of "." in reccomended mode
Fixed by correctly parsing dot in `SingleSettingTextField`.

CURA-9793
2022-12-13 11:46:06 +01:00
Joey de l'Arago
1e6184448c
Apply suggestions from code review
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-12 11:44:21 +01:00
c.lamboo
e03b4e07f9 Simplify rounding
Use sliders stepSize and snapMode properties

CURA-9793
2022-12-08 17:11:04 +01:00
c.lamboo
aaab633912 Move labels into Slider component
CURA-9793
2022-12-08 16:23:05 +01:00
Joey de l'Arago
e6f4055df5 Remove part of hack for fixing extrudersCHanged signal at the wrong time.
Other things rely on the extruders changed signal so it is better to just emit it again at the correct time.

CURA-9793
2022-12-08 13:11:14 +01:00
Joey de l'Arago
82fd34f168 Fix same property value check.
CURA-9793
2022-12-08 09:56:36 +01:00
Joey de l'Arago
435c67f97a revert changes to functions
CURA-9793
2022-12-08 09:53:06 +01:00
Joey de l'Arago
9a03094bfd Stop the text field from updating if the text has not changed. This was causing the custom mode text boxes to be updated instantly.
0.0 -delete-> 0. -instant update -> 0.0

 This is because the recommended mode text fields would update to "0." see that as a change from "0.0" and update the property. This triggered an update in the Custom mode textfield.

CURA-9793
2022-12-08 09:34:32 +01:00
Jelle Spijker
91170e0aef
Apply suggestions from code review 2022-12-08 07:43:57 +01:00
Joey de l'Arago
ca0cd5069b Remove leftover print statements
CURA-9793
2022-12-07 17:30:12 +01:00
Joey de l'Arago
8012cb5360 Signal are being emmitted before settings are updated. This is causing the combobox to update with the previous value. Only when using infill_pattern setting though. No idea what is causing this. This is a workaround for now.
CURA-9793
2022-12-07 17:16:26 +01:00
Joey de l'Arago
443252ae10 Use globalStackExtruderIds instead of extruderIds. extruderIds notifys change before the extruders change when doing a machine swap. Fixing this will take a long time so this is a workaround. If you are reading this 🙏 good luck fixing it 🙏
CURA-9793
2022-12-07 16:57:35 +01:00
Joey de l'Arago
bec02cf312 Fix extruder icon text scaling. I've added a new font size here since there is not any real way I can see to scale the font based on the component size. This is because we do some magic with the font numbers before passing them to the QML.
CURA-9793
2022-12-06 12:08:00 +01:00
Joey de l'Arago
3ddebe7a84 The extrudersCHanged signal was incorrectly being emitted before the global stack had updated. This was causing the extruderIds to always return the old extruderIds to connected qml components.
The setting slider was incorrectly setting the slider value when updating the model.

CURA-9793
2022-12-06 10:37:06 +01:00
Joey de l'Arago
ce5691c12d
Apply suggestions from code review
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-05 14:42:35 +01:00
Joey de l'Arago
d7e1aa08ac Update the single setting components to optionally update all extruders when a setting is settable per extruder or limited to extruder.
This forces all extruders to have their settings updated but only displays the value from a single extruder.

CURA-9793
2022-12-05 11:32:24 +01:00
Joey de l'Arago
540d810293 The slider was not forcing its setting value to stay the same when changes were made in the "Advanced" menu. This is because the slider updating and setting updating functions were intertwined. I've seperated them so that the slider no longer interferes with changes to the setting.
The Shell thickness settings were not being read or set correctly. I fixed this by setting the value to all extruders and reading from extruder 1. This setting is not set per machine but for all extruders. Not sure why.

CURA-9793
2022-12-05 10:23:40 +01:00
Joey de l'Arago
df8d0e9b46 Make it easier to override how the settingComboBox updates a setting.
CURA-9793
2022-12-02 18:01:12 +01:00
Joey de l'Arago
dfb6c04d00 Add SingleSettingTextField.qml
Added a workaround for states of inheriting components. See comments for details.

CURA-9793
2022-12-02 11:48:50 +01:00
Joey de l'Arago
73137a140a Inherit UM.TextField in Cura.TextField and remove redundant properties
CURA-9793
2022-12-01 17:09:19 +01:00
Joey de l'Arago
01ebee4aea Cleanup
CURA-9793
2022-12-01 15:27:54 +01:00
Joey de l'Arago
680a86c896 Add default height to combobox, not sure why this was never set before.
CURA-9793
2022-11-30 15:08:06 +01:00
Joey de l'Arago
75721f467b Remove margins and padding and scale icon better.
CURA-9793
2022-11-30 14:41:19 +01:00
Joey de l'Arago
4f8943412f Remove unused anchors
CURA-9793
2022-11-30 12:10:50 +01:00
Joey de l'Arago
69af593d8c Make Slider generic component in UM. Make Infill slider into generic SingleSettinSlider which will work for any setting now.
Change slider theme slighly.

CURA-9793
2022-11-30 11:45:27 +01:00
Joey de l'Arago
f99f1a4528 Stop logging spam by checking before setting property.
CURA-9793
2022-11-29 17:49:26 +01:00
Joey de l'Arago
c356b9d46f Rename ExtruderSelectorBar -> SingleSettingExtruderSelectorBar to be inline with new single setting widgets.
Move common functionality into SingleSettingExtruderSelectorBar

Add adhesion settings

CURA-9793
2022-11-29 17:00:55 +01:00
Joey de l'Arago
b53c8aac54 Add single setting update ComboBox
CURA-9793
2022-11-29 16:16:50 +01:00
Joey de l'Arago
5d5915e49e Make support selector functional
CURA-9793
2022-11-29 09:19:56 +01:00
Joey de l'Arago
631d6a15b0 Add extruder button bar that shows icons for each extruder in a horizontal row 💪
Make ExtruderButton more generic by moving functionality out.

Remove background color from ToolbarButton and add that background color to the Toolbar.qml.

Fix Toolbar border being created by overlapping rectangles instead of using border

Add scaling options for ToolBarButtons icon

CURA-9793
2022-11-28 15:55:55 +01:00
Joey de l'Arago
da71983891 Make combobox font and padding customizable.
Style WorkspaceDialog comboboxes similar to MachineSelector

CURA-9424
2022-11-17 14:41:14 +01:00
Joey de l'Arago
e4ad9cb48c Move base hovered logic out of ComboBox.qml since base is undefined in most places the component is used.
CURA-9424
2022-11-15 14:08:47 +01:00
Joey de l'Arago
dbba1c4110 patch checking for base parent component of Combobox to check if it exists first. This should be refactored out some time.
CURA-9424
2022-11-02 15:14:33 +01:00
j.delarago
4ee4a781f4 Change flashing yellow warning on resolution combobox to blue flashing lining.
Removed alwaysRunToEnd on animation since we would like the previous animation to stop if a user clicks through multiple intents triggering multiple animations.

CURA-8849
2022-06-20 11:33:28 +02:00
Ghostkeeper
e095d41f0b
Implement pulse animation option for ComboBox widget
You can now call pulse() on it and it'll pulse in the warning colour.

Contributes to issue CURA-8849.
2022-06-14 16:00:14 +02:00
Ghostkeeper
bd131257fe
Implement sending a signal when changing intent changes quality level
For now it does nothing. But I'm adding a function that should cause the combobox to pulse. That'll be a new feature so I'm implementing it in a separate commit.

Contributes to issue CURA-8849.
2022-06-14 16:00:13 +02:00
Ghostkeeper
28c1291feb
Allow configuring combobox with whether they allow styled text or not
For some models we'd like to have the possibility to have rich text in the combobox. For some we'd like to prevent that, for instance to prevent the user from using colours in their profile names, or boldface, or even images.

Contributes to issue CURA-8849.
2022-06-14 15:36:28 +02:00
Ghostkeeper
97e2d6a432
Use border only on active state
Contributes to issue CURA-9217.
2022-05-10 16:03:55 +02:00
Ghostkeeper
7fda81b678
Show a border around text fields and drop-downs when hovering
And when they are focused.
This applies to the setting text fields, extruder selectors and drop-downs as well as to the machine settings.

Contributes to issue CURA-9217.
2022-05-09 17:48:38 +02:00
j.delarago
ba3913395c Add catalog to files that weren't translating
CURA-9141
2022-05-05 16:42:01 +02:00
Ghostkeeper
eae5f4d57a
Set colour of placeholder text from theme
Otherwise it defaults to black which is not readable in dark mode.

Done as a 5 minute fix.
2022-05-04 15:44:42 +02:00
Jaime van Kessel
15d1ded365 Change selectedTextColor for textfield
CURA-9199
2022-04-26 15:11:19 +02:00
c.lamboo
45bc498c7f Replace RecolorImage with ColorImage
CURA-8640
2022-04-08 15:55:34 +02:00
Ghostkeeper
11b557b3d9
Replace material sub-menus with custom Popup
The sub-menus were giving segfaults for some reason. We couldn't figure out how to circumvent that. So now we're at a last resort: Implement the whole thing ourselves, but with Popup instead of Menu.

Contributes to issue CURA-8640.
2022-04-08 11:57:19 +02:00
Jaime van Kessel
2c09943bd6 Remove opacity from menuItem 2022-04-01 16:05:54 +02:00
Remco Burema
d2ab7d3d4d
Merge pull request #11633 from Ultimaker/CURA-9012_application_menu_fixes
Application menu fixes
2022-03-10 12:55:54 +01:00
Jaime van Kessel
84a0c732c1 Fix warnings caused by combobox
Parent wasn't always set, which caused ocasional warnings
2022-03-10 11:34:11 +01:00
Jaime van Kessel
dab67d9b38 Ensure that invisible menu seperators have a height of 0
CURA-9012
2022-03-09 13:26:16 +01:00
j.delarago
fb42679d08 Update TextField to match designs when disabled.
CURA-8991
2022-03-04 13:39:50 +01:00