24650 Commits

Author SHA1 Message Date
Remco Burema
3fcd7d567f
Show warning icon on import non-visible profile.
part of CURA-7691
2020-09-16 08:26:41 +02:00
Ghostkeeper
a1c3c44ed0
Fix warning limit for prime tower minimum volume to take other extruders into account
Since the prime tower for other extruders is now folded into one instead of alternating the layers, you need to have enough diameter to print all extruders, not just the current extruder.

Fixes one side-issue mentioned in #8148.
2020-09-15 13:43:06 +02:00
Ghostkeeper
10f8c381e1
Use initial layer settings during start g-code
Fixes #8364.
2020-09-15 11:58:00 +02:00
Evangelos Trantos
548e6e19e5
Remove the opening of the mycloud/digital factory URL in cases where the user has already signed in.
In cases where a staging build is created this hardcoded value would cause confusion, since it would always point the user to the production environment.
2020-09-14 21:20:38 +02:00
Evangelos Trantos
f906017835
Add the CURA_DIGITAL_FACTORY_URL variable
This way its value will be imported in the UltimakerCloudConstants.py file and be used throughout the application.
2020-09-14 21:15:32 +02:00
Evangelos Trantos
fc4de53269
Add the CURA_DIGITAL_FACTORY_URL variable in the CMakeLists file.
In this way it can be used as an argument during the Cura build configuration.
2020-09-14 21:13:05 +02:00
KOUBeMT
6e60cd4e15 Update strateo3d.def.json 2020-09-14 11:10:24 +02:00
Konstantinos Karmas
36a2535650
Merge pull request #8297 from Ultimaker/CURA-7118_shrinkage_compensation
Shrinkage compensation
2020-09-11 14:22:33 +02:00
Kostas Karmas
0524e8d129 Fix missing quality profile when message says its successful
Make sure to add the container before doing any other checks. Then, if the importing fails, remove
all the profiles related to that quality.

CURA-7691
2020-09-11 11:35:39 +02:00
Kostas Karmas
665496ceff Warn when importing quality profiles that don't match the current configuration
When importing a profile that doesn't much the current nozzle combination (e.g. importing a 'high'
quality when we have AA0.8 and AA0.4 nozzles), the profile was being accepted and a success message
was shown to the user, but the quality did not show up in the profile list.

This commit fixes that by accepting the quality profile and informing the user that the profile is
not visible due to the current configuration.

CURA-7691
2020-09-10 16:58:30 +02:00
Kimmo Toivanen
ad79cf878f Added M73 remaining time option and option to output remaining time more often 2020-09-09 22:43:54 +03:00
Kostas Karmas
2e240b646d Fix failing tests
A printer was added in the meantime that had setting_version = 15, which was leading to failing
tests, considering that this PR has changed the setting version to 16.

CURA-7118
2020-09-09 09:51:45 +02:00
Kostas Karmas
85f113a683 Merge branch 'master' into CURA-7118_shrinkage_compensation 2020-09-09 09:46:29 +02:00
Jelle Spijker
0725bdcd64
Merge pull request #8335
Speed up disable extruder
2020-09-09 09:42:36 +02:00
Ghostkeeper
765004cd68
Take node groups into account when computing the centre of the mesh group
These groups were not considered because they are not sliceable. Their children are sliceable, so I could just use a DepthFirstIterator. However their group computes the AABB correctly also, so taking the AABB of the group is more efficient.

Contributes to issue CURA-7118.
2020-09-08 17:54:09 +02:00
Ghostkeeper
d3e5f9ec93
Don't re-scale convex hulls for groups
The convex hulls for groups are already constructed from the convex hull of the convex hulls of all of their children. Since the children's convex hulls are already scaled, we don't want to scale it again for the group.

Contributes to issue CURA-7118.
2020-09-08 17:45:38 +02:00
Konstantinos Karmas
9156b2b922
Merge pull request #8200 from oducceu/master
Add 'Flying Bear Ghost 5' printer
2020-09-08 17:00:14 +02:00
Ghostkeeper
1ce8ef3293
Catch OSError and related errors when saving workspaces
This should prevent a crash when saving to a path that the file system doesn't support (because of e.g. disallowed symbols in the file name).

Instead it will now show an error message to the user.

Fixes Sentry issue CURA-157.
2020-09-08 13:01:10 +02:00
Ghostkeeper
6e2738a254
Don't update extruders that Cura doesn't have
This is a bit of defensive coding. If the position is out of bounds for Cura it should now ignore those extruders.
This could be due to broken firmware, or maybe someone MITM-ing the connection and changing it, or perhaps because the printer was changed while the sync was ongoing? Whatever the cause, it now puts a warning in the log about it and doesn't crash any more.

Fixes Sentry issue CURA-156.
2020-09-08 12:53:30 +02:00
Ghostkeeper
59669f6bad
Apply bitmask to user scope
As discussed, this is a method to prevent leaking personally identifiable information through crash reports, while still keeping the useful information for the developers on how widely spread the crashes are.
2020-09-08 02:00:58 +02:00
Kostas Karmas
43969c8074 Merge branch 'master' of https://github.com/Ultimaker/Cura 2020-09-07 16:37:02 +02:00
Kostas Karmas
17177eccfa Remove unused keyword argument
I18ncp already puts the number of printers in the text, so the keyword argument is not longer
necessary.

CURA-7665
2020-09-07 16:33:16 +02:00
Remco Burema
66132ef217
Don't use full-width unicode percent as placeholder in zh_CN locale.
Fixes #8322
2020-09-07 15:28:49 +02:00
KOUBeMT
0ce53cbf08 Merge remote-tracking branch 'upstream/master'
Updating branch
2020-09-07 15:19:38 +02:00
Jaime van Kessel
bde6e1bb97
Fix crash when removing cloud printers
CURA-7665
2020-09-07 11:27:36 +02:00
Jaime van Kessel
ea376c9ee8
Update translations based on suggestion from reseller 2020-09-07 10:52:45 +02:00
Jaime van Kessel
49c401590b
Update bugreport link 2020-09-07 10:47:52 +02:00
Jaime van Kessel
349f3b7e11
Force update when changing nozzle size in custom FFF
Fixes #8306
2020-09-07 10:46:17 +02:00
Jaime van Kessel
b35c8ba9bc
Add recalculate call to tests 2020-09-07 10:22:23 +02:00
Jaime van Kessel
175244fdc8
No longer spam the GUI with hasUserSettingsUpdates
The QML profiler showed me that it was causing a *lot* of issues
when switching between extruders. More than 10% of the time in QML
was spent on just updating ine property in the workspace summary dialog.
There were other properties that were also being updated without there being a point.

Contributes to #8250
2020-09-04 17:23:52 +02:00
Jaime van Kessel
6dbdee8d98
Don't switch away from disabled extruder
In some situations this could cause a slowdown, since halfway through
calculating the values the extruder switch would happen. If this is
split up a bit, it's at least less noticeable

Contributes to #8250
2020-09-04 16:43:53 +02:00
Jaime van Kessel
c383fe9656
Don't force an update when disabling an extruder
All the settings that are changed get a notification from the settingRelation.
There should be no need to re-fire all of those settings again!

Contributes to #8250
2020-09-04 16:39:06 +02:00
Jaime van Kessel
8ecdce3b26
Remove postponeEmit that didn't do anything
The signals it was postponing weren't ever being triggered
2020-09-04 16:38:15 +02:00
Jaime van Kessel
b09a88075e
Show a visual indication of enabled directly after click
This doesn't actually speed up the process, but it does give some indication
that something is going on while the changes are happening

Contributes to #8250
2020-09-04 14:48:55 +02:00
Ghostkeeper
8c0e21f0d5
Don't crash if mesh loading fails
Some plug-ins (like the OBJReader) return None then.

Fixes Sentry issue CURA-14P.
2020-09-03 17:52:44 +02:00
Remco Burema
0b22b94950
Merge pull request #8232 from Ultimaker/CloudNetworkConnectionFixes
Cloud network connection fixes
2020-09-03 09:57:36 +02:00
FoxExe
c87e78163e Added Kossel linear plus platform model
Small fix'es
2020-09-02 12:18:29 +05:00
Ghostkeeper
59bf1c10af
Account for the fact that global_stack may be empty
You should not have any models in your scene then though. But oh well. It also fixes the typing.

Contributes to issue CURA-7118.
2020-09-02 03:21:11 +02:00
Ghostkeeper
323be4deff
Fix updating the 2D convex hull
This comes at some performance cost, sadly. This is necessary because the convex hull of every node may change if the transformation of any other node changes, since that transformation may adjust the total bounding box of the mesh group.

Contributes to issue CURA-7118.
2020-09-02 03:09:41 +02:00
Ghostkeeper
f613a54b79
Compute centre of current mesh group
This is either the centre of the bounding box around all printable nodes in the scene, or the centre of the bounding box of the most-ancestral node that is not yet the scene root itself in one-at-a-time mode.

Contributes to issue CURA-7118.
2020-09-02 02:43:43 +02:00
Ghostkeeper
bc0ac0f2a0
Only scale convex hull if there is a non-1 scaling factor
This will save some processing power for the very common case where there is no scaling factor.

Contributes to issue CURA-7118.
2020-09-02 02:10:19 +02:00
Ghostkeeper
a6707217c7
Get scale factor from global stack
This is the one that's actually used by CuraEngine. If I get it per-object, the material profile overrides it.

Contributes to issue CURA-7118.
2020-09-02 02:08:18 +02:00
Ghostkeeper
4e283b5a78
Invert warning values
A small positive (>100) value is correct. It needs to compensate by increasing the size, usually. If you need to compensate by making it smaller, that means that the material would expand when cooling, which is very rare.

Contributes to issue CURA-7118.
2020-09-02 02:03:34 +02:00
Ghostkeeper
67092e1355
Don't forget to also upgrade fdmextruder
This one doesn't inherit from fdmprinter so it doesn't get the updated version number.

Contributes to issue CURA-7118.
2020-09-02 01:56:12 +02:00
Ghostkeeper
a7b2f7de5a
Upgrade setting_version to 16
We have a change now that requires a version upgrade. This triggers all profiles to update for the user, and we must update accordingly in the built-in profiles.

Contributes to issue CURA-7118.
2020-09-02 01:51:13 +02:00
Ghostkeeper
2395c0b1be
Add version upgrade for Cura 4.8
We're changing the unit of one of our settings, so we need to implement a version upgrade to change that for our users in case they changed this setting themselves.

Contributes to issue CURA-7118.
2020-09-02 01:20:59 +02:00
Ghostkeeper
bd074bf753
Fix check of model checker to take new unit of shrinkage factor into account
It's now based around 100%, so this should be adjusted.

Contributes to issue CURA-7118.
2020-09-02 01:02:12 +02:00
Ghostkeeper
af03bc8f24
Adjust collision area based on shrinkage compensation ratio
So now if the model is grown due to shrinkage compensation, its collision area will also grow. This prevents objects adjacent to each other from hitting each other.

Contributes to issue CURA-7118.
2020-09-02 00:51:58 +02:00
FoxExe
9b3d446a98 Use already provided Kossel platform model
Added Pulley version of Kossel
2020-09-02 03:51:13 +05:00
Ghostkeeper
d189485043
Change label and resolve functionality of shrinkage compensation setting
We'll now actually compensate for the shrinkage. That means that the setting needs to become user-visible. We need to make that experience a bit more user-friendly.

The setting is now also global, with a resolve function. That means that the user can't change this per extruder any more, because the scale factor applied in the engine can only be global. The resolve function means that profiles can still apply a per-extruder value but this value gets resolved with other extruders' values.

Contributes to issue CURA-7118.
2020-09-01 23:28:28 +02:00