15180 Commits

Author SHA1 Message Date
Ian Paschal
3321b23925 Fixes for UM3NetworkPrinting 2018-07-05 16:31:56 +02:00
Ghostkeeper
96896088c3
Add spaces around equals operators
As per our code style regulations.
2018-07-05 16:27:52 +02:00
Ian Paschal
85be9cea07 Fixes for Toolbox 2018-07-05 16:06:37 +02:00
Ian Paschal
cfae634061 Fixes for SliceInfo 2018-07-05 15:54:21 +02:00
Ian Paschal
d0c68f8e94 Fixes for WindowsRemovableDrivePlugin 2018-07-05 15:46:16 +02:00
Ian Paschal
2f8debc985 Fixes for FlavorParser 2018-07-05 15:45:48 +02:00
Diego Prado Gesto
87261b2754
Merge pull request #4020 from Ultimaker/add_test_versionupgrade_version
Add test for the version number being incremented
2018-07-05 15:36:15 +02:00
Diego Prado Gesto
c0985bec2a Add the data to the tests. 2018-07-05 15:32:43 +02:00
Ian Paschal
9ec5770a1c Fixes for StartSliceJob 2018-07-05 15:31:08 +02:00
Ghostkeeper
7b284355fb
Revert "Fix code-style in CuraEngineBackend"
This reverts commit 7d7a51d77241026ef665300b944b64dd69dbddcc. That commit broke the start-up sequence.
2018-07-05 15:24:55 +02:00
Ian Paschal
07e92ead0b last fixes for CuraEngineBackend 2018-07-05 15:20:38 +02:00
Diego Prado Gesto
8afc49e902 Add style to a variable in X3Reader 2018-07-05 14:41:49 +02:00
Lipu Fei
b0f1a6d859 Use Label delegate to avoid overlapping texts
CURA-5544
2018-07-05 14:36:41 +02:00
Diego Prado Gesto
c738f306fb Fix style in some components 2018-07-05 14:35:12 +02:00
Diego Prado Gesto
ab339e7784
Merge pull request #4024 from Ultimaker/fix_use_engine_ready
Use _engine_ready to detect if there is a QML engine
2018-07-05 13:57:53 +02:00
Ghostkeeper
ec00e5b721
Remove references to deleted settings
Also convert the values for prime_tower_min_volume to make it behave similar to what the minimum volume used to be. This feature fixed a bug with the computation from volume to thickness. Now it's correct but we have to correct the old values to be still the same (approximately) as what used to be the end result.

Contributes to issue CURA-5457.
2018-07-05 13:22:17 +02:00
Mark
4157cffdbd Merge branch 'master' into fix_use_engine_ready 2018-07-05 13:18:12 +02:00
Ghostkeeper
8f8c515438
Fix bug when default_extruder_nr is not provided
Then this would not slice because of a KeyError that is not caught.

Contributes to issue CURA-5457.
2018-07-05 12:51:27 +02:00
Andreea Scorojitu
87fd4c9e70 Add color to text in toolboxFooter, CURA-5544
"You will need to restart Cura before changes in packages have effect." wasn't visible in Ultimaker darktheme, color has been added to the label, CURA-5544.
2018-07-05 12:44:11 +02:00
Diego Prado Gesto
a27ec30575
Merge pull request #4021 from Ultimaker/add_types_for_backup_metadata
Add types for backup metadata
2018-07-05 12:33:26 +02:00
Ghostkeeper
ef2250b889
Don't check if keys are str
Our type checking should take care of that.
2018-07-05 12:31:42 +02:00
Diego Prado Gesto
3d549d0fb0
Merge pull request #4023 from Ultimaker/add_types_volume_dimensions
Add types for width, height, depth and shape
2018-07-05 12:29:51 +02:00
Diego Prado Gesto
20a9d8568f Merge branch 'master' of github.com:Ultimaker/Cura 2018-07-05 12:09:32 +02:00
Ian Paschal
6f20b9219d code style fixes 2018-07-05 11:57:13 +02:00
Jack Ha
675c5064ed Added checkPackageUsageAndUninstall and the package usage check. No confirmation dialog yet 2018-07-05 11:47:06 +02:00
Ian Paschal
1aac301f75 additional code style fixes 2018-07-05 11:46:21 +02:00
Ian Paschal
50da6d5176 Fix some code-style 2018-07-05 11:36:36 +02:00
Mark
e1bc5d0f74 fix typing 2018-07-05 11:25:22 +02:00
Ghostkeeper
807e8410c0
Give warning when sum of volumes exceeds volume of prime tower
It could happen that the desired volume is not entirely reached in the inner shells because of rounding the volume up to the nearest perimeter on the outer shells.

Contributes to issue CURA-5457.
2018-07-05 10:31:23 +02:00
Lipu Fei
e87f3d7ca9 Fix plugins import in CuraApplication
CURA-5543

Only import types for type checking when TYPE_CHECKING is true.
2018-07-05 10:23:20 +02:00
Ghostkeeper
192a581d6d
Don't round the warning threshold
The threshold is not visible. It's not necessary to round.

Contributes to issue CURA-5457.
2018-07-05 09:50:05 +02:00
Ghostkeeper
4f1b2d51cc
Remove old commented code
This is not valid any more by a long shot.
2018-07-05 09:45:20 +02:00
Mark
20180e3804
Merge pull request #4022 from Ultimaker/remove_id_raise3d
Remove ID from Raise3D definition
2018-07-05 09:44:42 +02:00
Diego Prado Gesto
7d7a51d772 Fix code-style in CuraEngineBackend 2018-07-05 08:04:19 +02:00
Ghostkeeper
2023973e98
Use _engine_ready to detect if there is a QML engine
We already have this variable. Let's not use a private variable from another class.
2018-07-04 17:39:24 +02:00
Ghostkeeper
b812989f1c
Add types for width, height, depth and shape 2018-07-04 17:34:26 +02:00
Ghostkeeper
9e18bb8b4c
Remove ID from Raise3D definition
These IDs are not used and should never be added again.
2018-07-04 17:31:58 +02:00
Diego Prado Gesto
71ca5f39f2 Fix indentation to move the remove function outside of the loop because
it only needs to be done once.
2018-07-04 17:30:29 +02:00
Ghostkeeper
c9480f2f2b
Add types for backup metadata 2018-07-04 17:30:01 +02:00
Diego Prado Gesto
efb9fcb645 Merge branch '3.4' 2018-07-04 17:28:08 +02:00
Diego Prado Gesto
ed882b917e Merge branch 'check_before_install_packages' into 3.4 2018-07-04 17:20:03 +02:00
Ghostkeeper
b149ef57fd
Add test for the version number being incremented 2018-07-04 17:18:01 +02:00
Diego Prado Gesto
d7c1767a23 Merge branch '3.4' into check_before_install_packages 2018-07-04 17:12:46 +02:00
Diego Prado Gesto
8e9ded98e4 Merge branch '3.4' 2018-07-04 14:57:43 +02:00
Lipu Fei
2b5700e4e1 Check the package file before installing it
Make sure that the package file is there before we remove the existing
installed files.
2018-07-04 14:50:32 +02:00
Diego Prado Gesto
4fd4043706 CURA-5528 Make the variable remove_failures a set. 2018-07-04 14:39:01 +02:00
Diego Prado Gesto
3b406b5467 Merge branch 'master' of github.com:Ultimaker/Cura 2018-07-04 14:32:05 +02:00
Diego Prado Gesto
4722b5387b CURA-5334 Add extruder definition for Wanhao printers, Uni Print 3d and
Tevo Tornado. Those definitions were added without extruder definitions.
2018-07-04 14:22:22 +02:00
Ghostkeeper
8ff4327c41
Remove Wipe Nozzle After Switch and Purge Volume settings
The entire purging algorithm is gone now since it purges by printing the prime tower. The prime tower should be sufficiently strong now to not need this.

Contributes to issue CURA-5457.
2018-07-04 14:17:57 +02:00
Ghostkeeper
7b2a5c9160
Remove prime_tower_wall_thickness setting
The wall thickness now depends on the order in which the prime towers are folded, which is really hard to obtain within an inheritance formula. So we forego one of the settings and compute the required thickness to obtain the desired volume in the engine where the shell order is known.

Contributes to issue CURA-5457.
2018-07-04 13:45:44 +02:00