digitalfrost
a39fed1dc3
Use one line conditional assignment
...
Use one line conditional assignement instead of if else block.
The intent is now clearer and the code is easier to read.
2022-08-04 09:45:47 +02:00
j.spijker@ultimaker.com
c1ae1872d0
Make sure build and generate steps are present
...
Contributes to CURA-8831
2022-08-03 17:49:13 +02:00
j.spijker@ultimaker.com
ae7023b2db
Create the package
...
Contributes to CURA-8831
2022-08-03 17:10:53 +02:00
j.spijker@ultimaker.com
cc329955f0
Just do an actual create
...
Contributes to CURA-8831
2022-08-03 17:02:50 +02:00
j.spijker@ultimaker.com
7bd90d21ab
First do a build
...
Contributes to CURA-8831
2022-08-03 16:59:01 +02:00
j.spijker@ultimaker.com
15e1d063d8
Also create the generator folder
...
Contributes to CURA-8831
2022-08-03 16:51:54 +02:00
j.spijker@ultimaker.com
2845b9a42b
Export-pkg requires a build dir
...
Contributes to CURA-8831
2022-08-03 16:11:50 +02:00
j.spijker@ultimaker.com
145194cc25
Only export-pkg on Linux
...
No need for bins and therefor different OSes
Contributes to CURA-8831
2022-08-03 15:51:03 +02:00
j.spijker@ultimaker.com
4e31b4328c
Treat it as bool
...
Contributes to CURA-8831
2022-08-03 15:49:35 +02:00
digitalfrost
fad47856e4
Rename _start_time to _check_start_time
...
This better reflects what _start_time is and makes the code easier
to read. _check_start_time is self documenting.
The current comment next to _start_time is erroneous
since _start_time is not "measuring the checking time"
2022-08-03 11:40:15 +02:00
digitalfrost
556b009a9d
Fix Bug in timing MachineErrorChecker execution
...
We want the Logger in line 215 to give the execution time in seconds
so we don't want the start time to be the epoch.
Currently the logger will output something like
time = 1659518458.5s
not like
time = 3.0s
2022-08-03 11:26:39 +02:00
j.spijker@ultimaker.com
cf548613ca
Add cura env to Run environments
...
Contributes to CURA-8831
2022-08-03 08:51:41 +02:00
j.spijker@ultimaker.com
f95b22404a
fix base_dir for venv when running from source
...
Contributes to CURA-8831
2022-08-03 08:51:41 +02:00
j.spijker@ultimaker.com
e4feae414b
Build pyarcus and pysavitar shared
...
Contributes to CURA-8828, CURA-8829 and CURA-8831
2022-08-03 08:51:41 +02:00
j.spijker@ultimaker.com
de9d432398
Use new pysavitar as package
...
Contributes to CURA-8828, CURA-8829 and CURA-8831
2022-08-02 15:47:17 +02:00
j.spijker@ultimaker.com
76b2984426
Use new pynest2d package
...
Contributes to CURA-8828, CURA-8829 and CURA-8831
2022-08-02 12:56:25 +02:00
digitalfrost
cba2e07adc
Remove extra spaces
2022-08-02 09:08:46 +02:00
digitalfrost
b13b7a892d
Move _error_check_timer initialization to a separate function
...
This simplifies understanding the class __init__ function
2022-08-02 08:55:17 +02:00
j.spijker@ultimaker.com
a7b1052b27
Use the latest pyarcus dependency
...
Since we split of Arcus and pyArcus into separate repo's
Contributes to CURA-8824 and CURA-8831
2022-08-01 16:11:51 +02:00
Jelle Spijker
7b768ca810
Merge pull request #12866 from Ultimaker/CURA-9220_hide_if_no_permission
...
Hide cloud interaction buttons if the user has no permissions to them
2022-08-01 12:41:11 +02:00
Jelle Spijker
405baea1ae
Merge pull request #12898 from Ultimaker/CURA-9520_warning_line_density_children
...
Don't show warning color for children of support_infill_rate when using tree support
2022-08-01 12:37:59 +02:00
j.spijker@ultimaker.com
d1e8ae1ca7
Fix curapackage intent and intents mappings
...
Contributes to SD-3871 and CURA-7667
2022-08-01 11:16:48 +02:00
Ghostkeeper
8a55a2aff6
Further review suggestions
...
Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
84cf72d58f
Document shortcoming of isMine check
...
Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
da289b51d0
Deprecate additionalRights property
...
Consumers should now use the permissions system which gets the permissions from the account via a separate API call.
Contributes to issue CURA-9220.
2022-08-01 10:49:29 +02:00
Ghostkeeper
7c1a254812
Add newlines before properties
...
As suggested in the code review.
Contributes to issue CURA-9220.
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-08-01 10:47:57 +02:00
digitalfrost
cfeab2e6c0
Use dataclasses for Peripheral
...
Since Peripheral is a data class use dataclasses
2022-07-31 11:46:03 +02:00
j.spijker@ultimaker.com
5a8047e7d9
Don't show warning color for children of support_infill_rate when using tree support
...
CURA-9520 PPM: Tree support has infill density 15%, but should have 0%
2022-07-29 18:04:49 +02:00
Ghostkeeper
9bb3b1a375
Merge branch 'CURA-9031_add_slice_id_to_griffin_gcode_header'
2022-07-29 16:02:39 +02:00
Ghostkeeper
a0f640586c
Add slice ID to example data
...
Contributes to issue CURA-9031.
2022-07-29 15:57:10 +02:00
Jelle Spijker
c27cee8a72
Merge pull request #12878 from Ultimaker/CURA-9520_Fix_support_infill_tree_support
...
CURA-9520_Fix_support_infill_tree_support
2022-07-29 12:32:43 +02:00
j.spijker@ultimaker.com
6df721eb7a
Don't use conan 1.51.0
...
Conan 1.51.0 seems to have bug in the MSBuild generator, used on Windows
2022-07-29 12:17:01 +02:00
j.spijker@ultimaker.com
d9e3e4d395
Made slice_uuid a public field
...
Contributes to CURA-9031
2022-07-29 12:13:12 +02:00
Ghostkeeper
d27ed71518
Increase maximum integer length to 12 characters
...
This may cause overflows if the integer type is 32-bit, but we tend to use 64-bit anyway. And 9,999,999 was already an overflow too.
Fixes #12859 .
2022-07-29 10:30:25 +02:00
digitalfrost
b8f448a359
Add link to style guide
...
Add link to the document that describes the code conventions and guidelines to be followed in all Ultimaker code, regardless the programming environment / language.
This document is located in the Ultimaker/Meta repo.
2022-07-28 11:18:16 +02:00
j.spijker@ultimaker.com
fdad2590da
Switch to macos-11
...
This will drop support for MacOS 10.15 and lower, which will be deprecated
within the next 3 months or so. But the GH hosted runners have dropped support
for this already.
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
2022-07-28 10:44:55 +02:00
j.spijker@ultimaker.com
5dc0310f26
Use the release naming scheme for out installer
2022-07-28 10:44:00 +02:00
j.spijker@ultimaker.com
2c6979bc5e
Switch to macos-11
...
This will drop support for MacOS 10.15 and lower, which will be deprecated
within the next 3 months or so. But the GH hosted runners have dropped support
for this already.
https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/
2022-07-28 10:41:24 +02:00
j.spijker@ultimaker.com
a88e31eddd
Add the slice_uuid to the slice info data
...
Contributes to CURA-9031
2022-07-27 18:13:09 +02:00
j.spijker@ultimaker.com
a712e7517a
Add the received slice_uuid to the print information
...
Contributes to CURA-9031
2022-07-27 18:12:25 +02:00
p.kuiper
6ea1079b60
Set the infill density of the support to 0% when tree structures are used.
...
Relates to CURA-9520
2022-07-27 15:38:03 +02:00
j.spijker@ultimaker.com
2e23fe84ff
Add missing Python requirements.txt
...
Somehow these were left out during the merge from the 5.1 to main branch
2022-07-27 14:28:14 +02:00
j.spijker@ultimaker.com
89042f9dd4
Fix failing trimesh
2022-07-27 12:50:30 +02:00
j.spijker@ultimaker.com
89de2b1fae
Set the Cura Version also when running from source
2022-07-27 12:03:51 +02:00
Ghostkeeper
37a98cbb6f
Mock HttpRequestManager while changing sync state
...
This change triggers a cascade of updates and in some cases triggers a sync. The sync trigger also triggers an update of the account permissions which crashes because the HttpRequestManager can't be started on a thread. We shouldn't make HTTP requests from our tests anyway so mock this away.
Contributes to issue CURA-9220.
2022-07-27 11:43:31 +02:00
Ghostkeeper
d52be42e01
Mock HttpRequestManager while changing log-in state
...
Changing the log-in state causes additional requests to be made to get information from the account. Previously this wasn't a problem because the information was only obtained from other classes such as the DigitalLibrary to get information on how many library projects the user can make. But now that there are triggers in the Account class itself, those triggers get triggered. It'd make additional requests to the account server. We don't want the tests to make such requests.
Contributes to issue CURA-9220.
2022-07-27 11:41:50 +02:00
Ghostkeeper
f849df6ba3
Remove old df_access additional right
...
It is replaced by the new permissions system. The rights are more specific than 'digital factory access, yes or no'. It's now about whether you can read/write printers/projects/print jobs/etc and can differ whether it is your own project/job/etc or someone else's.
Contributes to issue CURA-9220.
2022-07-26 17:49:55 +02:00
Ghostkeeper
7287644324
Add specific permission requirements to application switcher
...
These functions require special permissions in the account now. Just checking for digital factory access is no longer enough.
Contributes to issue CURA-9220.
2022-07-26 17:46:26 +02:00
Ghostkeeper
9d820b8d02
Redirect to USB workflow if user account doesn't have permissions
...
If the user is not allowed to write profiles to the printers, then they'd get errors when trying to sync. Instead we'll redirect them to the USB workflow.
This also works for users that have accounts but don't have the printers in the cloud. The original requirements suggest that the entire sync button must be hidden for this case. But to allow those people to still sync via USB I'm opting for this solution instead.
Contributes to issue CURA-9220.
2022-07-26 17:21:08 +02:00
Ghostkeeper
615f16bda0
Hide 'show in browser' when the user can't visit the printer overview
...
No use then. They can't visit that page.
Contributes to issue CURA-9220.
2022-07-26 16:57:07 +02:00