19 Commits

Author SHA1 Message Date
Lipu Fei
e414621250 Fix code style 2017-08-09 09:27:42 +02:00
Lipu Fei
ab3d8349b6 Also skip empty containers when getting layer height for a quality profile
CURA-4133

On some machines such as UM2, there is no material. Getting the layer
height in this case will result back to the global stack itself, which
is the layer height of the current setting. This is a problem for
"Normal" (or "Fine") quality because it uses the machine's default layer
height.
2017-08-09 09:24:04 +02:00
Ghostkeeper
81e07b1530
Use stack properties instead of .findContainer(type = ...)
Recently we changed the empty containers such that there is only one empty container instance and it doesn't have the proper type any more. Instead we have properties on the stack that allows us to find the container with the proper type. It's faster and easier to use.
We've had a few bugs about this so I decided to update all of them to remove those for the future, except the ones in plugins/MachineSettingsAction/MachineSettingsAction.py because we have a pending pull request that fixes those. Fixing them would give merge conflicts for fieldOfView.

It doesn't really belong to CURA-4024 but I'm sticking it under that nomer anyway to get it reviewed.
2017-07-10 10:35:03 +02:00
Jaime van Kessel
437c78711d Added typing to all singletons
This greatly helps with pycharms ability to do auto code completion
2017-04-13 16:32:17 +02:00
Simon Edwards
4fecf55b3b Use double quotes instead of singles. 2017-01-17 20:56:50 +01:00
Simon Edwards
5884509af1 More type checking fixes after the merge.
CURA-2917
2016-11-22 11:51:18 +01:00
Jaime van Kessel
1aa71d6171 Profiles model is now a singleton, to prevent the agressive garbage collecting to break stuff
CURA-2826
2016-10-27 14:26:43 +02:00
Ghostkeeper
e6c68bcdc9
Add fallback if no unit is known for layer_height
If there is no unit known, it is interpreted as there being no unit. There is currently mm, but if we changed that it is probably on purpose so we write no unit.

Contributes to issue CURA-2723.
2016-10-25 11:28:41 +02:00
Jaime van Kessel
844b9729f4 Fixed critical errors when first adding UM3 2016-10-25 11:16:54 +02:00
Ghostkeeper
58dba9bcb3
Dynamically get unit of layer height
If the unit of layer height would become something else than mm eventually, it'll still be correct here.

Contributes to issue CURA-2737.
2016-10-21 14:03:28 +02:00
Ghostkeeper
c92ccee1e4
Add layer height role to profiles model
This layer height computation is rather complex, but because the items are now computed in a separate function, we can safely overwrite that and the update is made only once in the UI.

Contributes to issue CURA-2737.
2016-10-21 13:59:23 +02:00
Simon Edwards
f7fe59c707 A small fix for the case when Cura is starting up and there is no printer.
CURA-2271 Warn for unsupported material/printcore combinations
2016-10-13 11:10:40 +02:00
Simon Edwards
f659d01da1 Make the labels in the quality menus match those from the selected extruder.
CURA-2271 Warn for unsupported material/printcore combinations
2016-10-13 10:55:32 +02:00
Simon Edwards
963fac7806 Filter the list of quality changes taking into account the quality(-type) profile they depend on.
Contributes to CURA-2248 Duplicated profile not shown in the profile manager list
2016-10-05 09:32:18 +02:00
Jaime van Kessel
7d9d751121 ProfilesModel is now updated when active variant or material is changed
Contributes to CURA-2494
2016-10-03 15:43:42 +02:00
Simon Edwards
cd45ef496b Handle materials which don't have any quality profiles of their own. Moved the quality_type computation code into the QualityManager.
Contributes to CURA-2477 Profile menu should only contain valid options for all materials
2016-09-29 16:39:30 +02:00
Simon Edwards
4a85ee85c1 Update the model when something changes in the global stack.
Contributes to CURA-2477 Profile menu should only contain valid options for all materials
2016-09-29 12:27:04 +02:00
Simon Edwards
062611a92a Handle the startup situation where there is no global stack. Fixed a bug where the wrong stack was used instead of the first extruder.
Contributes to CURA-2477 Profile menu should only contain valid options for all materials
2016-09-28 15:56:10 +02:00
Simon Edwards
a7c58c33f7 Fixed up the profiles menu to handle multiple extruders better.
Contributes to CURA-2477 Profile menu should only contain valid options for all materials
2016-09-28 15:15:18 +02:00