31177 Commits

Author SHA1 Message Date
Remco Burema
358ca13fd8 Also show 'warning' when only recommended settings changed.
part of CURA-9347
2022-12-06 12:03:31 +01:00
Joey de l'Arago
362877dee1 Add new recommended mode tooltips and remove extra margin at the bottom of tooltips.
CURA-9793
2022-12-06 10:50:04 +01:00
Joey de l'Arago
ea5d4a8211 Make tickmarks bigger to avoid issues with pixel rounding errors causing the tickmarks to appear above or below the background line.
CURA-9793
2022-12-06 10:38:49 +01:00
Joey de l'Arago
3ddebe7a84 The extrudersCHanged signal was incorrectly being emitted before the global stack had updated. This was causing the extruderIds to always return the old extruderIds to connected qml components.
The setting slider was incorrectly setting the slider value when updating the model.

CURA-9793
2022-12-06 10:37:06 +01:00
whoseyoung
55a1a16e44
Merge branch 'Ultimaker:main' into main 2022-12-06 13:49:20 +08:00
Christian Kvasny
3acda6a7da
Merge branch 'Ultimaker:main' into main 2022-12-05 23:29:33 +01:00
Joey de l'Arago
c495f0de3f Hide extruder selector when there is only one extruder.
CURA-9793
2022-12-05 17:11:05 +01:00
Joey de l'Arago
5a415b8324 Remove black fill from icons. This fill prevents themeing
CURA-9793
2022-12-05 16:55:48 +01:00
jspijker
8058c16f00 Merge branch 'main' into CURA-9793_extend_recommended_print_settings 2022-12-05 16:45:33 +01:00
Joey de l'Arago
d2ff62485d Fix popups not maxing height at top of parent
CURA-9793
2022-12-05 16:18:03 +01:00
Modix-Lazar
13dab34ad2 Removed pre-defined values from the files 2022-12-05 15:55:28 +01:00
Joey de l'Arago
7185b898a3 remove comments
CURA-9793
2022-12-05 15:44:27 +01:00
Joey de l'Arago
bfb2b044bb nested popups will always try to take up the same vertical area as it's parent. If the popup is small than it's parent it won't go below or above the parent. If it is longer than the parent, the bottom will extend past the parent.
CURA-9793
2022-12-05 15:43:05 +01:00
Jelle Spijker
b8b433ed5c
Merge pull request #13938 from Ultimaker/CURA-9347_safe_to_profile_button
[CURA-9347] Easier 'compare-and-safe' for (new or custom) profiles
2022-12-05 15:34:57 +01:00
Joey de l'Arago
80e9f64c85 Fix overwritten theme name for slider
Add property for background ticks.

CURA-9793
2022-12-05 15:30:51 +01:00
Joey de l'Arago
f034c115be Rename slider theme items
CURA-9793
2022-12-05 15:11:48 +01:00
Joey de l'Arago
ce5691c12d
Apply suggestions from code review
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-05 14:42:35 +01:00
Joey de l'Arago
741a112282 Remove recommended adhesion selector.
CURA-9793
2022-12-05 14:05:22 +01:00
Christian Kvasny
c4621cbb1a
Update resources/definitions/vzbot_base.def.json
removed

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-12-05 13:24:32 +01:00
Christian Kvasny
fc6db7b020
Update vzbot_base.def.json
remove retraction_hop_enabled false
2022-12-05 13:14:31 +01:00
Christian Kvasny
8d46640441
Merge branch 'Ultimaker:main' into main 2022-12-05 12:59:49 +01:00
Joey de l'Arago
6d474dfe40 Remove comments
CURA-9793
2022-12-05 11:56:22 +01:00
whoseyoung
33b815dec5 add Geeetech 24 machine profiles 2022-12-05 18:45:09 +08:00
Joey de l'Arago
0738f996d0 Merge branch 'main' into CURA-9793_extend_recommended_print_settings 2022-12-05 11:39:51 +01:00
Joey de l'Arago
29172014ad Add all new recommended items to ignored custom settings keys. This stops the reset setting button from appearing even though we have changed these settings.
CURA-9793
2022-12-05 11:37:18 +01:00
Joey de l'Arago
d7e1aa08ac Update the single setting components to optionally update all extruders when a setting is settable per extruder or limited to extruder.
This forces all extruders to have their settings updated but only displays the value from a single extruder.

CURA-9793
2022-12-05 11:32:24 +01:00
whoseyoung
6de976f1e0
Merge branch 'Ultimaker:main' into main 2022-12-05 18:32:11 +08:00
Jelle Spijker
e91d5df3a3
Apply suggestions from code review 2022-12-05 10:39:20 +01:00
Joey de l'Arago
540d810293 The slider was not forcing its setting value to stay the same when changes were made in the "Advanced" menu. This is because the slider updating and setting updating functions were intertwined. I've seperated them so that the slider no longer interferes with changes to the setting.
The Shell thickness settings were not being read or set correctly. I fixed this by setting the value to all extruders and reading from extruder 1. This setting is not set per machine but for all extruders. Not sure why.

CURA-9793
2022-12-05 10:23:40 +01:00
Luis Gabriel Gomez
358f20a94e
printer-linter: exit on invalid definition file paths
This PR prevents silent failure with empty diagnostics if an invalid file path was provided
2022-12-04 19:45:25 -03:00
Luis Gabriel Gomez
651e56ca9d
Clarify linter steps for running locally 2022-12-04 19:33:48 -03:00
Luis Gabriel Gomez
80373b25b3
Run printer-linter format/fix 2022-12-04 19:28:52 -03:00
Luis Gabriel Gomez
e83f9eabef
Merge remote-tracking branch 'upstream/main' into feat/sermoonv1_update 2022-12-04 19:22:02 -03:00
Luis Gabriel Gomez
7e15acb959
Update Sermoon V1 profile with better hotend specifics 2022-12-04 19:14:42 -03:00
Jelle Spijker
4a0711b665
Merge pull request #13964 from Ultimaker/fusion3_f410
Added fusion3 F410

Contributes to CURA-9972
2022-12-04 14:01:19 +01:00
jspijker
f3b9e86068 Fixed fan speeds 2022-12-04 13:52:13 +01:00
jspijker
6abaa44731 Removed UM materials from excluded list
These are excluded anyway due to the filament diamter
2022-12-04 13:33:21 +01:00
jspijker
88792d7bda Added fusion3 F410
Based on PR #13355 Credits to @64bittuning

Adding support for the Fusion3Designs F410 machine. Later the F400, F306 and Edge will follow.

My business owns a Fusion3 F410 and using it has been difficult. The manufacturer originally shipped the machine with a license for Simplify 3d. We originally purchased the machine about three years ago, and the S3D license was lost when the previous controlling employee left the organization. I have spent a long time trying to get this machine operational and unfortunately my employer will not replace the S3D license. Enter Ultimaker Cura...

I have been using Cura since 4.4 and have spent a LONG time building and updating profiles. In 2020 I added Tronxy support, and recently performed a major overhaul on the profiles package. This brought me back to my attempt at adding support for our F410.
The vast majority of the profiles used here are a culmination of things I have learned through building other profiles, as well as using data points extracted from the large repository of S3D profiles that were released by Fusion3Design. The profiles all work, they produce good results, and use all of the original settings placed fourth by the manufacturer.

There are unfortunately some limitations that I felt were important to work around. Fusion3Design has a large list of certified materials. With such, in an effort to help prevent users from voiding the warranty on their machine, materials that do not match the approved materials list have been omitted from the machine profile at this time. The Generic profiles provided by Fusion3Design have been incorporated in order to provide support for PLA, PETG, ABS, ASA, PC, PA, CPE, and TPU. There are many brand name and specialty filament specific profiles available, however since Ultimaker Cura does not already "support" these materials with specific selectable profiles, the best option was to leave them for a future update.

Please view the certified materials lists below.
https://www.fusion3design.com/wp-content/uploads/2020/11/Fusion3-Certified-Materials-List-updated-10.28.2020-Simplify3D.pdf

https://www.fusion3design.com/list/

Fusion3Design can be found at https://www.fusion3design.com/

Co-authored-by: 64bittuning <64bittuning@users.noreply.github.com>
2022-12-04 13:20:10 +01:00
jellespijker
6da1abcd49 Applied printer-linter format 2022-12-03 14:03:25 +00:00
Jelle Spijker
7bc7f6e504
Merge pull request #13708 from eropple/ed/sv01-sv02-fixes
fixed bed dimensions of Sovol SV01 and SV02

Contributes to CURA-9971
2022-12-03 15:02:25 +01:00
Remco Burema
c74e7be602 Appease reviewers.
- Ditch state in favour of enum.
- Comment explaining 'extraInfo'.

part of CURA-9347
2022-12-02 19:52:37 +01:00
Remco Burema
9fe261ff58
Apply suggestions from code review.
part of CURA-9347

Co-authored-by: Joey de l'Arago <joeydelarago@gmail.com>
2022-12-02 19:07:41 +01:00
Joey de l'Arago
df8d0e9b46 Make it easier to override how the settingComboBox updates a setting.
CURA-9793
2022-12-02 18:01:12 +01:00
Joey de l'Arago
02572311bf Components were clickable when hidden.
CURA-9793
2022-12-02 16:19:29 +01:00
Joey de l'Arago
5b76e3dd7c Add component with icon generic component.
Add print walls and print top/bottom settings to recommended menu

CURA-9793
2022-12-02 12:41:04 +01:00
Joey de l'Arago
dfb6c04d00 Add SingleSettingTextField.qml
Added a workaround for states of inheriting components. See comments for details.

CURA-9793
2022-12-02 11:48:50 +01:00
whoseyoung
36ac3d7744 add geeetech profiles 2022-12-02 18:29:20 +08:00
jspijker
7820cc9840 Fix multiline printer-linter PR suggestions 2022-12-02 10:28:42 +01:00
jellespijker
b788987ae1 Applied printer-linter format 2022-12-02 09:07:39 +00:00
Jelle Spijker
1bd2e6c67e
Merge pull request #13952 from Ultimaker/cura_9951_dxu_umo_plus_empty_nozzle_fix
Cura 9951 dxu umo plus empty nozzle fix
2022-12-02 10:06:39 +01:00