585 Commits

Author SHA1 Message Date
Lipu Fei
9856ccf700
Merge pull request #4073 from Ultimaker/CURA-5572_fix_gcode_reader
CURA-5572 Update the scene when a Gcode is loaded.
2018-07-16 08:07:02 +02:00
Aleksei S
817a304ed1 After reconecting to another port update job status '_is_cancelled' to false
CURA-5549
2018-07-13 23:50:02 +02:00
Diego Prado Gesto
01a26b0360 CURA-5572 The scene was not updated when a Gcode was loaded.
This fixes a bug that we introduced when fixing code style. This was a
bad translation.
2018-07-13 16:05:13 +02:00
Diego Prado Gesto
e88362930d CURA-5562 Don't trigger the stop slicing if some nodes without build
plate associated with it changes in the scene, such as the NozzleNode in
the SimulationView.
2018-07-12 14:34:42 +02:00
Jack Ha
993dd7a90e Check for None instead of evaluating the variable as True/False. 2018-07-11 11:34:31 +02:00
Ian Paschal
6a5c0b608d Fix missing layer view 2018-07-11 11:24:16 +02:00
Ian Paschal
d709650def Try to ignore _process variable 2018-07-10 11:04:17 +02:00
Ian Paschal
8dab2a6696 Do not attempt to discard changed build plates 2018-07-09 15:33:41 +02:00
Ian Paschal
1c1b45541f
Merge branch 'master' into fix_tests_cura_engine_backend 2018-07-09 12:38:54 +02:00
Ghostkeeper
dec9d7cac6
Still store disabled extruders as a set
They should be unique anyway.

Contributes to issue CURA-5456.
2018-07-09 11:32:53 +02:00
Ian Paschal
ac0192f01f Improve fixes 2018-07-09 11:29:25 +02:00
Ian Paschal
c6b290e1e5 Fix broken slicing 2018-07-06 11:03:32 +02:00
Ian Paschal
2c291e02be Revert "Fixes for StartSliceJob"
This reverts commit 9ec5770a1c2f64c50aee6a279645320e5bff8fe0.
2018-07-06 10:54:24 +02:00
Ian Paschal
9ec5770a1c Fixes for StartSliceJob 2018-07-05 15:31:08 +02:00
Ian Paschal
07e92ead0b last fixes for CuraEngineBackend 2018-07-05 15:20:38 +02:00
Ghostkeeper
8f8c515438
Fix bug when default_extruder_nr is not provided
Then this would not slice because of a KeyError that is not caught.

Contributes to issue CURA-5457.
2018-07-05 12:51:27 +02:00
Ghostkeeper
ef2250b889
Don't check if keys are str
Our type checking should take care of that.
2018-07-05 12:31:42 +02:00
Ian Paschal
6f20b9219d code style fixes 2018-07-05 11:57:13 +02:00
Ian Paschal
1aac301f75 additional code style fixes 2018-07-05 11:46:21 +02:00
Ian Paschal
50da6d5176 Fix some code-style 2018-07-05 11:36:36 +02:00
Mark
e1bc5d0f74 fix typing 2018-07-05 11:25:22 +02:00
Lipu Fei
dc8d9e0f96
Merge branch 'master' into mypy_fixes 2018-06-29 13:45:55 +02:00
Ghostkeeper
e957f7b650
Fix typing errors
Contributes to issue CURA-5330.
2018-06-15 15:07:08 +02:00
Ghostkeeper
2b33a1f1b6
Fix broken import with DefinitionContainerInterface
And the ensuing type error that can then be found.

Contributes to issue CURA-5330.
2018-06-15 14:31:29 +02:00
Ghostkeeper
0d52b03716
Fix the wrong types in this class
These mistakes were found by MyPy.

Contributes to issue CURA-5330.
2018-06-15 14:25:25 +02:00
Ghostkeeper
4c3d28709b
Add typing for all functions and fields
Lots of typing so that MyPy can then check whether the functions are safe to call.

Contributes to issue CURA-5330.
2018-06-15 14:07:33 +02:00
Ghostkeeper
8256788ed8
Use CuraApplication instead of Application
Because we need to call getExtruderManager which is only in CuraApplication.

Contributes to issue CURA-5330.
2018-06-15 13:40:43 +02:00
Ghostkeeper
75e5a185d9
Don't unnecessarily cast to a set
The InstanceContainer version of getAllKeys was first casting to a list but I removed that, because everywhere where we were using it we were casting it directly to a set.

Contributes to issue CURA-5330.
2018-06-15 13:07:55 +02:00
Jack Ha
f5dd7f6e92 CURA-5456 fixed typo, fixed multi objects with disabled extruders in message 2018-06-14 10:27:24 +02:00
Lipu Fei
439ea79c60 Add message for unable to slice due to disabled extruders
CURA-5456
2018-06-13 11:09:20 +02:00
Jack Ha
17b127e8c1 CURA-5249 replaced the extruder value of -1 by the more explicit defaultExtruderPosition, so now Cura is aware of the actual extruder position being used. Fixes linked icon next to support settings, like support_angle. 2018-06-06 11:00:09 +02:00
Diego Prado Gesto
43657010ba CURA-5164 The Preferences is not a singleton class anymore since in some point
several instances need to be created.

- In the ThreeMFWorkspaceReader we need to create some temporal
instances of Preferences that makes it not singleton anymore.

- The current preferences are kept in the Application class and so all
the calls to the preferences are changed to get the preferences from
Application.

- The method getInstance in Preferences is kept as deprecated since some
external plugins.
2018-05-11 08:50:42 +02:00
Lipu Fei
051dd7a6e9 WIP: Make application initialization and start up more clear
- Create SingleInstance class to handling single instance stuff.
 - Instead of calling getInstance() everywhere, initialize each object
   explicitly in order when application starts and getInstance()s do not
   create instances any more and they merely return the created
   instances.
 - Only set initial values in construtor functions __init__(). Move the
   initialization of context-aware (i.e. things that depend on other
   things) to separate functions.
 - Split application creation and initialziation into several steps and
   them should be called explicitly in the correct order.
2018-05-04 09:57:02 +02:00
Mark
b78b6b2c01 Change default auto_slice setting to False
CURA-5188
2018-04-17 10:37:07 +02:00
Diego Prado Gesto
1a6a39da93 CURA-5197 Add log output with number of models in the buildplate after
slice.
2018-04-12 16:53:00 +02:00
Jack Ha
283cbed1ad CURA-5130 move the part that determines if it should slice 2018-03-22 16:02:09 +01:00
Lipu Fei
0787f0b2ba Fix autoslice check so it doesn't slice if there is no need
CURA-5130
2018-03-22 14:46:19 +01:00
Ian Paschal
7f6a89e6aa Fixed bug that didn't do anything
Sometimes `None` was in the grouped objects which threw an error when trying to use `.callDecoration("isGroup")` on it. Nothing seems to break before, apart from the error message, and nothing breaks now either. But no error message. So that's good.
2018-03-21 09:52:03 +01:00
Ian Paschal
9dc50ec73f CURA-4400 Apply correct shader to grouped nodes 2018-03-20 16:54:34 +01:00
Ian Paschal
a7b2632739 CURA-4400 Recommended mode shows support extruders 2018-03-20 13:14:48 +01:00
Jack Ha
10ba900449 CURA-5090 empty layer data when new sliced data is empty and prevent some layer data to be processed if it is outdated 2018-03-19 14:02:02 +01:00
Jack Ha
7ebd83f815 CURA-4400 get setting type from definition instead of whole stack improves speed of this call by a factor of 10 2018-03-14 10:21:10 +01:00
Lipu Fei
934d297e6c Split error checking into smaller sub-tasks
CURA-5059

Split stack error checking into smaller sub-tasks so running them on the Qt
thread will not block GUI updates from happening for too long.
2018-03-13 13:21:44 +01:00
Jack Ha
e0e2d3362b CURA-4400 fix for change in fdmprinter: move -1 from default_value to value 2018-03-12 13:30:31 +01:00
Jack Ha
3edc96ec8f CURA-4400 fixed wrongly converted expression 2018-03-12 10:47:23 +01:00
Jack Ha
d70cc072e9 Merge branch 'master' into feature_enable_disable_extruder 2018-03-12 09:06:24 +01:00
Ian Paschal
6bee5bf1b0 CURA-4972 Tweak per review comments 2018-03-09 10:36:34 +01:00
Jack Ha
3b8d470323 Merge branch 'master' into feature_enable_disable_extruder 2018-03-08 09:35:49 +01:00
ChrisTerBeke
3d42849f90
Merge pull request #3418 from Ultimaker/docker
Docker support
2018-03-07 11:08:42 -08:00
Jack Ha
ff1c378c08 CURA-4400 fix start slicing when disabled extruder is incompatible 2018-03-07 11:38:35 +01:00