Ghostkeeper
c42d092b0f
Merge branch 'master' into cura_containerstack
2017-05-03 15:21:01 +02:00
Ghostkeeper
86f1a0559f
Add documentation and further specify except around disconnecting signals
...
Catch just a TypeError instead of all exceptions. Added documentation to say why we catch a TypeError there. Also splitted up the try-except block for the 3 disconnects, just so that if the first fails we still try to disconnect from the other two.
Contributes to issue CURA-3497.
2017-05-03 14:56:52 +02:00
Jaime van Kessel
9a46a24b19
Profile menu now correctly marks active qualties as checked
...
CURA-3497
2017-05-03 13:13:09 +02:00
Jaime van Kessel
d83b4daf78
Switching from quality_changes to quality profile is now possible again
...
CURA-3497
2017-05-03 11:23:59 +02:00
Jaime van Kessel
c8f823154c
Instead of searching for a container with type, we now use the newly introduced properties
...
CURA-3497
2017-05-03 11:10:39 +02:00
Jaime van Kessel
f062322ebf
Switching from dual extrusion to single extrusion machine is now possible again
...
CURA-3497
2017-05-03 10:59:07 +02:00
Jaime van Kessel
ab6240bd31
Replace quality(changes) in machine manager now uses new API as well
...
CURA-3497
2017-05-03 10:38:31 +02:00
Jaime van Kessel
a028297cb2
Machine manager now uses the new specific setters to switch instanceContainers
...
CURA-3497
2017-05-03 10:15:18 +02:00
Jaime van Kessel
d7004d3547
Merge branch 'master' of github.com:Ultimaker/Cura into cura_containerstack
2017-05-02 11:42:16 +02:00
Jack Ha
ed23e6f5b2
Removed more commented out code. CURA-3497
2017-04-25 08:56:28 +02:00
fieldOfView
2ca24ba7e6
Restore both material and variant to match 1st extruder when switching to single extrusion
2017-04-22 11:20:55 +02:00
Arjen Hiemstra
af3f340fc2
Handle the fact that findContainers might end up returning None
...
Since we now do not necessarily have a container with the specified
type.
2017-04-18 17:37:05 +02:00
Jaime van Kessel
53ecaba7f2
Added more typing.
...
These typing hints should have prevented the previous issue from happening
2017-04-14 14:21:36 +02:00
Jaime van Kessel
09d624dcfe
Fixed accidental switch of function properties
2017-04-14 14:15:43 +02:00
Arjen Hiemstra
b87e7c46bf
Use the normal empty container for quality changes as well
2017-04-13 01:37:45 +02:00
Arjen Hiemstra
33301c835b
Use CuraStackBuilder::createMachine when adding a new machine
2017-04-13 01:37:26 +02:00
fieldOfView
db6cdad956
Filter preferred materials by approximate material diameter
2017-04-12 23:27:34 +02:00
Arjen Hiemstra
6827849220
Un-deprecate activeMachine{Name,Id}
...
Since it provides too much noise and I do not want to change the code
that uses it right now.
2017-04-06 17:50:05 +02:00
Arjen Hiemstra
82333a244b
Add some initial code to use the new classes to create new machines
2017-04-04 17:40:58 +02:00
Arjen Hiemstra
cbc19b13eb
Deprecate the activeMachineName/Id properties in favour of activeMachine
2017-04-04 17:40:34 +02:00
Arjen Hiemstra
7eb5441ebc
Add an "activeMachine" property to MachineManager
...
Directly exposes the global container stack to QML.
2017-04-04 17:39:57 +02:00
Arjen Hiemstra
7015702832
Add a change timer to perform the error state checking
...
This pulls the checkStackHaveErrors code out of the critical path when
editing settings, instead moving it to be handled later. This greatly
reduces the delay that happens when editing settings.
Fixes CURA-3653
Contributes to #1631
2017-04-04 13:39:18 +02:00
Jaime van Kessel
90a92dce19
If a container_changes can not be found, handle it more gracefully
...
CURA-3560
2017-03-21 13:23:50 +01:00
Jack Ha
32d5fbe557
Fixed choosing a quality that is compatible with multiple extruders as fallback. CURA-3510
2017-03-13 17:17:56 +01:00
Lipu Fei
55727f20e5
CURA-3507 Make quality lookup more robust
2017-03-13 09:45:23 +01:00
Jaime van Kessel
85b58c9296
Pressing the discard button now actually discards the changes
...
CURA-3221
2017-02-28 12:35:08 +01:00
Jaime van Kessel
2462699982
Switching profiles now shows a new dialog with all the changes.
...
CURA-3221
2017-02-28 10:25:42 +01:00
Simon Edwards
92cee4a9d7
Merge branch 'master' into python_type_hinting
2017-02-13 16:31:31 +01:00
Arjen Hiemstra
a63b4646e9
Postpone containersChanged signals of all active stacks
...
This avoids things taking longer because the not-active extruder stack
was still emitting containersChanged.
2017-02-07 17:01:52 +01:00
Arjen Hiemstra
0292756ad7
Do not limit containersChanged methods to a single container type
...
This may trigger a few extra updates, but allows us to use signal
compression in the postponesignals context manager, which greatly
improves performance.
2017-02-07 16:28:08 +01:00
Arjen Hiemstra
927055806c
Postpone containersChanged signals when doign setActive* calls
...
This makes sure we do not trigger everything three times when switching
variants.
2017-02-07 16:26:44 +01:00
Ghostkeeper
425dbf1ad8
Only check for validationState changes if it's not already a value change
...
No need to check the second if-statement in most cases.
Contributes to issue CURA-3291.
2017-02-01 16:29:59 +01:00
Ghostkeeper
3ac9036b4a
Only listen for other container stack errors if multi-extrusion
...
It's not even necessary to check otherwise. Requesting an extruder stack would give None anyway, which would give errors.
Contributes to issue CURA-3291.
2017-02-01 16:28:45 +01:00
Ghostkeeper
a0ba1188a1
Always listen to changes on all extruder stacks of the current machine
...
We need to listen for changes on all extruder stacks because the values might change and therefore the validation states might change. The value of a different extruder stack could change if you change a global value that has impact on a per-extruder value via inheritance, or in this case if a limit-to-extruder property specifies that the setting should be changed on a different stack. It could change on the stack that is not active in either case.
This might have some performance impact, but it is very small. Other than layer_height there aren't many global settings that have impact on multiple extruders via inheritance. And via limit-to-extruder there will typically only be one changed value which you want to update for. Changing layer height will be a bit slower though.
Contributes to issue CURA-3291.
2017-02-01 16:17:12 +01:00
Ghostkeeper
362c5835ee
Don't use limit_to_extruder if it evaluates to -1
...
The default value for the limit_to_extruder property is -1. So no need to check if the property exists. Just check if it is positive.
Contributes to issue CURA-3291.
2017-02-01 14:42:06 +01:00
Ghostkeeper
ed2b09c975
Fix getting limit to extruder property
...
Apparently it didn't even reach this code up until now. Well, now it does.
Contributes to issue CURA-3291.
2017-02-01 14:26:37 +01:00
Ghostkeeper
039015e3df
Don't unnecessarily copy extruder stacks to list
...
You're just looping over it. No need to actually make a list out of it.
Contributes to issue CURA-3291.
2017-02-01 14:24:03 +01:00
Ghostkeeper
7d536e2f8b
Clarify global container stack checking code in _checkStacksHaveErrors
...
The order of operations was a bit weird. This made the code unclear and also required an extra check in an if-statement. This is simpler and theoretically even a bit faster.
Contributes sorta to issue CURA-3291.
2017-02-01 14:17:23 +01:00
Ghostkeeper
31e88aa5af
Also check for errors via limit_to_extruder settings
...
The error should then not be checked in the active stack but in the stack which has the correct setting value.
Contributes to issue CURA-3291.
2017-02-01 14:14:50 +01:00
Simon Edwards
d5c96c1aae
Removed a line of debug.
2017-01-18 13:49:18 +01:00
Simon Edwards
fb70eb6813
Merge branch 'master' into python_type_hinting
2017-01-17 08:42:55 +01:00
Simon Edwards
a5181f157e
Applied the profiler's pyqtSlot decorator to all of the code.
2017-01-10 13:35:39 +01:00
Jaime van Kessel
ff18a314ef
Added extruder information to workspace summary dialog
...
CURA-1263
2016-12-16 13:16:11 +01:00
Jaime van Kessel
8391a7971b
Added machine type to workspace summary dialog
...
CURA-1263
2016-12-16 12:40:59 +01:00
Jaime van Kessel
0e09de195b
Added num user settings to save project dialog
2016-12-16 11:50:50 +01:00
Ghostkeeper
c7a8ffb3c0
Set quality to empty if no profiles for current material type
...
This then causes the text 'Not supported' to appear to the user, indicating that for his foreign material we have no known quality profiles.
Contributes to issue CURA-3144.
2016-12-15 16:41:56 +01:00
Simon Edwards
d4619da358
Merge branch 'master' into python_type_hinting
2016-12-13 14:39:35 +01:00
Jack Ha
6e8e7d090d
Fix for Not Supported when adding a new machine. CURA-3042
2016-12-12 16:46:19 +01:00
Jaime van Kessel
0229fd8676
Fixed issue with first startup
2016-12-12 11:00:19 +01:00
Jaime van Kessel
36d743384c
Initial work for adding a save dialog for project saving
...
CURA-1263
2016-12-08 11:56:42 +01:00