73 Commits

Author SHA1 Message Date
Ghostkeeper
9feb609fba Don't add a setting if evaluation failed
If the eval failed that is likely caused by a variable not existing. It now continues with evaluating other settings and just doesn't add the setting that depends on non-existing legacy settings. This happens when the imported profile is not complete or corrupt.

Contributes to issue CURA-37.
2016-01-13 16:59:05 +01:00
Ghostkeeper
7f1a746a45 Make infill_before_walls opposite
The perimeter_before_infill setting was opposite of infill_before_walls, so turn this boolean around.

Contributes to issue CURA-37.
2016-01-13 16:33:39 +01:00
Ghostkeeper
a4777ac2ed Correct wall thickness setting
The shell thickness also governs the top_bottom_thickness, which is not desired.

Contributes to issue CURA-37.
2016-01-13 16:32:38 +01:00
Ghostkeeper
8b72834c9b Remove skin_no_small_gaps_heuristic
Apparently this setting doesn't exist in the legacy Cura.

Contributes to issue CURA-37.
2016-01-13 16:24:20 +01:00
Ghostkeeper
5d4cceb47c Don't add a setting if it's the default
If the imported setting is the default in the new Cura, don't add it to the profile.

Contributes to issue CURA-37.
2016-01-13 16:16:00 +01:00
Ghostkeeper
3195684892 Parse speed settings as string
In the evaluation that's passed from the Dictionary of Doom, the settings are still strings so you can only parse the settings as string...

Contributes to issue CURA-37.
2016-01-13 15:55:09 +01:00
Ghostkeeper
ef3b5792b4 Fix retraction combing import
Retraction combing was an enum (a fact which was not documented). This enum must be parsed to a boolean. The 'no skin' option now evaluates to true since it is not implemented in the new Cura.

Contributes to issue CURA-37.
2016-01-13 15:52:38 +01:00
Ghostkeeper
731fd41ecd If specific speed setting is 0, use print_speed
Something that was not in the translation document: If a speed setting for a specific part is 0 (such as infill_speed) then the global print speed should be used.

Contributes to issue CURA-37.
2016-01-13 15:42:15 +01:00
Ghostkeeper
482f0461fc Add check for profile version
The profile reader now checks whether the profile version is the same as the target version in the Dictionary of Doom.

Contributes to issue CURA-37.
2015-12-18 10:50:54 +01:00
Ghostkeeper
68496349a9 Fix import of top and bottom thickness
The legacy settings had a boolean for these, but in the current version is should just be a float.

Contributes to issue CURA-37.
2015-12-18 10:19:28 +01:00
Ghostkeeper
84613d99c4 Fix import of platform_adhesion
This setting should never be set to None.

Contributes to issue CURA-37.
2015-12-18 10:10:08 +01:00
Ghostkeeper
d2513f9bbb Fix prime_tower_size import
It was using math.sqrt incorrectly and also was trying to divide strings by each other, while they were floats.

Contributes to issue CURA-37.
2015-12-18 10:03:34 +01:00
Ghostkeeper
0454b37243 Fix importing math to eval
We expose only math, so it can do mathematical operations on the setting values when translating.

Contributes to issue CURA-37.
2015-12-18 10:00:00 +01:00
Ghostkeeper
bfa332e227 Fix ternary operator in import of support_enable
The ternary operator of Python is different.

Contributes to issue CURA-37.
2015-12-18 09:54:35 +01:00
Ghostkeeper
5358b700ca Fix ternary operator in import of support_enable
The ternary operator of Python is different.

Contributes to issue CURA-37.
2015-12-18 09:52:50 +01:00
Ghostkeeper
99a13ba3aa Fix getting settings from JSON file
When reading a node of a JSON file, apparently it only lists the keys instead of key-value pairs. You have to get the values separately.

Contributes to issue CURA-37.
2015-12-18 09:14:55 +01:00
Ghostkeeper
6bde0e3404 Sync translation category name from JSON
The category was named 'translation' instead of 'translations'.

Contributes to issue CURA-37.
2015-12-18 09:10:52 +01:00
Ghostkeeper
644038af97 Missing imports
Test before commit. Test before commit. Test before commit. Test before commit!

Contributes to issue CURA-37.
2015-12-18 09:06:43 +01:00
Ghostkeeper
166c8a3048 Fix call to configparser.options
It needs to have the section from which to read the options.

Contributes to issue CURA-37.
2015-12-18 09:01:22 +01:00
Ghostkeeper
abb92afc27 Fix call to prepareLocals
Turns out the 'self.' is required...

Contributes to issue CURA-37.
2015-12-17 14:54:48 +01:00
Ghostkeeper
f2a95ae89c Correct the configparser
The import was missing. Also, the parser was not called on the correct stream.

Contributes to issue CURA-37.
2015-12-17 14:30:53 +01:00
Ghostkeeper
57f5e60fa5 Fix link to LegacyProfileReader
This was preventing the entire plugin from being loaded.

Contributes to issue CURA-37.
2015-12-17 14:02:29 +01:00
Ghostkeeper
513941097f Initial LegacyProfileReader plugin implementation
This plugin reads a profile from legacy Cura versions. It hasn't been tested much except that there are no syntax errors. It is currently being blocked by issue 34.

Contributes to issue CURA-37.
2015-12-17 13:49:53 +01:00