Should've done this in the merge, but I just increased the setting_version for these.
I also removed a deleted setting from the advanced visibility. We don't have tests that ensure that these visibility presets are good. Lucky I found it then, with a Ctrl+Shift+F search.
We'll offer the option to print from outside to inside, from inside to outside, or from inside to outside except that the very innermost centre wall is printed last.
Contributes to issue CURA-8109.
To my surprise, it seems fdmprinter has merged perfectly. Nice.
Conflicts:
resources/setting_visibility/advanced.cfg -> Settings moved to a different category while we added new settings in the same place.
Context: Print Thin Walls and Fill Perimeter Gaps are old settings that aren't needed any more since we switched to libArachne (Varianble Line Widths).
CURA-7148
This setting denotes what is the maximum allowed area lost or gained when the middle junction of a
straight line is removed (due to the simplification). This area deviation exists due to the
difference of width of the colinear segments.
A B C A C
--------------- ************** deviation_error / 2
| |--------------------------- B removed ------------------------------------------
| | | ---------> | | |
| |--------------------------- ------------------------------------------
--------------- ^ ************** ^
^ C.w C.w
B.w
CURA-7751
These have moved. The Support Structure setting was already present in the support category.
Done as a 5 minute fix while working on the Settings Guide.
Conflicts:
plugins/VersionUpgrade/VersionUpgrade41to42/VersionUpgrade41to42.py -> Both had a version upgrade implementation.
plugins/VersionUpgrade/VersionUpgrade41to42/__init__.py -> Both had a version upgrade implementation.
I decided not to put the prime tower brim in advanced because the rest of the advanced settings are still a bit more novice than that.
Contributes to issue CURA-6194.
Also convert the values for prime_tower_min_volume to make it behave similar to what the minimum volume used to be. This feature fixed a bug with the computation from volume to thickness. Now it's correct but we have to correct the old values to be still the same (approximately) as what used to be the end result.
Contributes to issue CURA-5457.