Ghostkeeper
dd8ee2e3d8
Switch early fail around to reduce indentation
...
Makes this more readable.
Contributes to issue CURA-6793.
2019-10-08 15:22:12 +02:00
Ghostkeeper
b137e6a36d
Don't add extruders twice upon start-up
...
The extruders are added when changing printers anyway, and we call this change signal upon start-up. So one of them is going to do unnecessary work.
Contributes to issue CURA-6793.
2019-10-08 15:21:19 +02:00
Jaime van Kessel
0ff9d72c4c
Remove use of deprecated extruders property
2019-09-13 17:27:16 +02:00
Lipu Fei
c841382bbd
Add more info in exceptions
2019-08-02 11:12:16 +02:00
Jaime van Kessel
d8ddcba091
Fix typing ignore for breath frist iterator
2019-07-23 13:40:40 +02:00
Jaime van Kessel
9ceb9ce18b
Fix typing issues
...
They were caused by upgrading to a higher mypy version, which found more mistakes
2019-07-23 12:58:46 +02:00
Jaime van Kessel
1c93dffc22
Added deprecation warning to getExtruderName
2019-07-19 13:36:53 +02:00
Jaime van Kessel
f329d7aed9
Made typing hint a bit more specific
2019-06-28 15:08:46 +02:00
Jaime van Kessel
1759e01b27
Make _geSettingFromAllExtruders use zip
...
This is a bit cleaner to use
2019-06-07 13:40:41 +02:00
Jaime van Kessel
915e0e2047
Only add extrudernr to used extruders if it actually exists
...
This can cause issues when a profile got messed up (especially when using profiles between different custom machines)
2019-05-16 15:41:52 +02:00
Ghostkeeper
8c5f871185
Also omit support meshes from used extruders list
...
Their own extruder doesn't get used necessarily, because these meshes are then printed using the support extruder.
Contributes to issue CURA-6440.
2019-04-04 16:35:48 +02:00
Lipu Fei
8da1f8fa7d
Exclude support blockers in used extruders
...
CURA-6440
2019-04-02 14:16:57 +02:00
Ghostkeeper
1d25f52df6
Merge branch '4.0'
2019-03-06 15:23:55 +01:00
Jaime van Kessel
91cceea6e0
Fix the situation where an upgraded single extrusion machine and loading project caused issues
...
If the upgraded single extrusion machine was never activated, it would not have it's extruders set.
CURA-6252
2019-02-28 16:17:34 +01:00
Remco Burema
f1b6e527be
Rectified wrong placement of brackets causing logic change. [CURA-5864]
2019-02-14 14:55:12 +01:00
Remco Burema
a601e0878c
Explicitly also check for Raft when checking for prime-tower=brim. [CURA-5864]
2019-02-13 15:46:39 +01:00
Lipu Fei
173f125d3e
Fix merge conflicts
2019-01-24 14:55:29 +01:00
Jaime van Kessel
e8febaff59
Remove code duplication
2019-01-02 09:23:20 +01:00
Ghostkeeper
42058a2e8f
Revert "Prevent some unneeded calling of signals"
...
This reverts commit 85f10e7c4f9bc48afd2fe43903e565b128e03189.
The second time you start Cura, it won't slice due to the number of extruders being wrong.
2018-12-24 09:37:17 +01:00
Remco Burema
f62e8b4bb2
Create 'brim for prime tower only' option (see also backend PR). [CURA-5864]
2018-12-21 17:38:30 +01:00
Jaime van Kessel
85f10e7c4f
Prevent some unneeded calling of signals
2018-12-21 16:57:52 +01:00
Jaime van Kessel
1436301d78
Ensure setActiveExtruderIndex only gets called once when switching machines
...
CURA-6016
2018-12-10 16:20:00 +01:00
Ghostkeeper
4e2f51e7e8
Use public activeExtruderIndex rather than internal _activeExtruderIndex
...
So that this getter still does what it needs to do if we ever decide to add side-effects.
Contributes to issue CURA-5876.
2018-11-30 11:13:04 +01:00
Lipu Fei
0e1e8d269a
Fix the extra setNextStack()
2018-10-25 13:40:34 +02:00
Lipu Fei
5e8dba5266
Remove some duplicate addExtruder() and setNextStack() calls
2018-10-25 11:42:47 +02:00
Lipu Fei
7d7de32dbd
Add ExtruderStack to GlobalStack in single extrusion machine fix
2018-10-03 16:53:07 +02:00
Lipu Fei
18cb21186c
Merge remote-tracking branch 'origin/master' into WIP_kill_extruder_manager
2018-10-03 15:45:18 +02:00
Diego Prado Gesto
c0c66649b8
Merge branch '3.5'
2018-10-02 20:27:18 +02:00
Lipu Fei
f69005fef9
Rename to CuraFormulaFunctions
...
to avoid confusion with "SettingFunction" in Uranium.
2018-10-01 11:24:34 +02:00
Lipu Fei
3c8368827b
Remove unused functions in ExtruderManager
2018-09-26 17:04:15 +02:00
Lipu Fei
7a681a2ae4
Move Cura custom setting functions to a separate file
2018-09-26 16:54:00 +02:00
Lipu Fei
91bcfb9445
Take in account extruders that haven't been loaded yet
...
CURA-5751
2018-09-25 15:29:31 +02:00
Lipu Fei
3b62284276
Merge remote-tracking branch 'origin/3.5'
2018-09-18 16:15:55 +02:00
Lipu Fei
ddc5d983a1
Fix single extrusion machines without an ExtruderStack
...
CURA-5736
2018-09-18 13:35:25 +02:00
Ghostkeeper
e9ac0e5564
Merge branch '3.5'
2018-09-14 12:41:35 +02:00
Ghostkeeper
fb9c21e914
Fix imports
2018-09-14 12:41:03 +02:00
Ghostkeeper
3b36223681
Merge branch '3.5'
2018-09-14 12:40:29 +02:00
Ghostkeeper
e9cdd47a03
Fix types of getGlobalContainerStack call results
...
We know in these places that there must be a global stack at this point. So to hide the type error we'll cast it here.
Of course, the danger in this is that someone might call this function that doesn't know about this requirement and calls it when there is potentially no global stack yet. Hopefully they'll discover this crash when that happens then.
2018-09-14 12:38:16 +02:00
Jaime van Kessel
757c8754b1
Merge branch '3.5' of github.com:Ultimaker/Cura
2018-09-13 16:23:55 +02:00
Lipu Fei
b27e5a1f77
Fix getActiveExtruderStacks()
...
CURA-5719
The dict values can be a random list. We need to fetch the first N
extruders starting from position 0.
2018-09-12 14:00:36 +02:00
Jaime van Kessel
c84a2213a7
Merge branch '3.5' of github.com:Ultimaker/Cura
2018-09-11 11:01:55 +02:00
Diego Prado Gesto
351fe5c5bc
Fix style.
2018-09-10 17:25:06 +02:00
Jaime van Kessel
e7d9f0ce45
Added typing for various setting classes
2018-09-10 15:24:11 +02:00
Jaime van Kessel
5c6c299b27
Cleanup extruder manager
...
Few more unused functions removed & simplified.
It also fixes a few more typing issues that I encountered.
2018-09-07 17:06:18 +02:00
Jaime van Kessel
e6d0a9cc6a
Add missing typing
2018-09-07 16:33:44 +02:00
Jaime van Kessel
a8fc6aabcc
Switch incorrect usage of getMachineExtruders to getActiveExtruderStacks
2018-09-07 16:27:56 +02:00
Jaime van Kessel
638f9fb941
Remove unused functions
2018-09-07 16:02:54 +02:00
Jack Ha
3761123513
Merge branch 'master' into CURA-5334_extruder_def_for_all
2018-07-02 14:11:24 +02:00
Ghostkeeper
6e663ac6f5
Don't call getMachineManager on Uranium's application
...
It is a function of CuraApplication.
Contributes to issue CURA-5330.
2018-06-15 11:15:31 +02:00
Ghostkeeper
c3d4d5eba7
Ignore MyPy errors caused by DepthFirstIterator not being detected as iterator
...
MyPy is wrong in this case.
Contributes to issue CURA-5330.
2018-06-15 11:02:15 +02:00
