GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-05-23 21:19:58 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,023 Commits 290 Branches 265 Tags
Commit Graph

169 Commits

Author SHA1 Message Date
Jelle Spijker
91170e0aef
Apply suggestions from code review 2022-12-08 07:43:57 +01:00
Joey de l'Arago
bcdfa808a8 Switch to checking enabled extruder count for showing print with Component. This is because we want the SingleSettingExtruderBar to be hidden when there are 1 or less extruders, but also when there are 1 or less enabled extruders. 
CURA-9793
 2022-12-07 17:33:13 +01:00
Joey de l'Arago
f601229390 Move Validators to UM, so they can be used in UM components. 
Update all TextFieldWithUnit to use our FloatValidator. This component now has proper styling when the input is invalid. The DoubleValidator was flagging numbers with a "." in them as an incorrect input (I assume this is because the region was set to europe on the OS where "," is common). The workaround is to use our FloatValidator which validates both "." and ","

CURA-9793
 2022-12-07 16:27:42 +01:00
Joey de l'Arago
362877dee1 Add new recommended mode tooltips and remove extra margin at the bottom of tooltips. 
CURA-9793
 2022-12-06 10:50:04 +01:00
Joey de l'Arago
3ddebe7a84 The extrudersCHanged signal was incorrectly being emitted before the global stack had updated. This was causing the extruderIds to always return the old extruderIds to connected qml components. 
The setting slider was incorrectly setting the slider value when updating the model.

CURA-9793
 2022-12-06 10:37:06 +01:00
Joey de l'Arago
c495f0de3f Hide extruder selector when there is only one extruder. 
CURA-9793
 2022-12-05 17:11:05 +01:00
jspijker
8058c16f00 Merge branch 'main' into CURA-9793_extend_recommended_print_settings 2022-12-05 16:45:33 +01:00
Joey de l'Arago
ce5691c12d
Apply suggestions from code review 
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
 2022-12-05 14:42:35 +01:00
Joey de l'Arago
741a112282 Remove recommended adhesion selector. 
CURA-9793
 2022-12-05 14:05:22 +01:00
Joey de l'Arago
d7e1aa08ac Update the single setting components to optionally update all extruders when a setting is settable per extruder or limited to extruder. 
This forces all extruders to have their settings updated but only displays the value from a single extruder.

CURA-9793
 2022-12-05 11:32:24 +01:00
Joey de l'Arago
540d810293 The slider was not forcing its setting value to stay the same when changes were made in the "Advanced" menu. This is because the slider updating and setting updating functions were intertwined. I've seperated them so that the slider no longer interferes with changes to the setting. 
The Shell thickness settings were not being read or set correctly. I fixed this by setting the value to all extruders and reading from extruder 1. This setting is not set per machine but for all extruders. Not sure why.

CURA-9793
 2022-12-05 10:23:40 +01:00
Joey de l'Arago
02572311bf Components were clickable when hidden. 
CURA-9793
 2022-12-02 16:19:29 +01:00
Joey de l'Arago
5b76e3dd7c Add component with icon generic component. 
Add print walls and print top/bottom settings to recommended menu

CURA-9793
 2022-12-02 12:41:04 +01:00
Joey de l'Arago
dfb6c04d00 Add SingleSettingTextField.qml 
Added a workaround for states of inheriting components. See comments for details.

CURA-9793
 2022-12-02 11:48:50 +01:00
Joey de l'Arago
62bae7df19 Collapse the setting section when the switch for the section is disabled. 
Add collapse animation for setting items and setting section.

Swap out ColumnLayout for Layout. Animating the Layouts does not seem to be possible.

I had to put spacer back into the Column but it is the lesser of two evils.

CURA-9793
 2022-12-01 14:03:11 +01:00
Joey de l'Arago
574b1000f6 Add tooltips 
CURA-9793
 2022-11-30 17:44:58 +01:00
Joey de l'Arago
522bf60e81 Adjust left margins 
CURA-9793
 2022-11-30 15:43:14 +01:00
Joey de l'Arago
d617566db4 Move show custom button next to setting section title. 
CURA-9793
 2022-11-30 15:36:15 +01:00
Joey de l'Arago
b356335f4f Correct spelling mistake 
CURA-9793
 2022-11-30 15:10:19 +01:00
Joey de l'Arago
dbf2ae4f60 Fix spacing vertical between Recommended sections and setting items. 
CURA-9793
 2022-11-30 15:09:05 +01:00
Joey de l'Arago
0514c62b3e Remove bad height assignment to dynamic layout 
CURA-9793
 2022-11-30 14:51:45 +01:00
Joey de l'Arago
dbf27a432f Change confusing naming of section enable switch. 
CURA-9793
 2022-11-30 12:12:41 +01:00
Joey de l'Arago
69af593d8c Make Slider generic component in UM. Make Infill slider into generic SingleSettinSlider which will work for any setting now. 
Change slider theme slighly.

CURA-9793
 2022-11-30 11:45:27 +01:00
Remco Burema
40b7233125 Also add save/reset buttons to custom profile. 
part of CURA-9347
 2022-11-29 23:18:15 +01:00
Remco Burema
0ea2830108 Add the 'safe to profile' button itself. 
Currently only works for creating a new profile from current changes (when on top of a built-in profile). Only does the compare (not the safe yet) in the other circumstance. Also already anticipate the next commits by being able to hide the text and icon (because this will be added to the custom mode view as well).

part of CURA-9347
 2022-11-29 22:54:30 +01:00
Joey de l'Arago
7ba0281136 Move required settingPropertyProvider into InfillSlider. 
Use new RecommendedSetting components for Strength section of recommended.

CURA-9793
 2022-11-29 17:50:40 +01:00
Joey de l'Arago
1224f076c3 Fix switch alignment 
CURA-9793
 2022-11-29 17:20:34 +01:00
Joey de l'Arago
c356b9d46f Rename ExtruderSelectorBar -> SingleSettingExtruderSelectorBar to be inline with new single setting widgets. 
Move common functionality into SingleSettingExtruderSelectorBar

Add adhesion settings

CURA-9793
 2022-11-29 17:00:55 +01:00
Joey de l'Arago
c240833868 Add Support type settings 
CURA-9793
 2022-11-29 16:23:49 +01:00
Joey de l'Arago
b53c8aac54 Add single setting update ComboBox 
CURA-9793
 2022-11-29 16:16:50 +01:00
c.lamboo
0fc4773db3 Round possible fractional positional values 
CURA-9793
 2022-11-29 14:56:15 +01:00
c.lamboo
a470a6c333 Add indicator arrow to slider 
CURA-9793
 2022-11-29 14:37:45 +01:00
c.lamboo
f4e7829e0b Remove infill icon changing density on change slider 
Suggestion from @lorenzoromagnoli

CURA-9793
 2022-11-29 13:12:11 +01:00
c.lamboo
261adf06e7 Place InfillSlider in sperate file 
CURA-9793
 2022-11-29 10:32:47 +01:00
Joey de l'Arago
d9a2a3f5b7 cleanup 
CURA-9793
 2022-11-29 09:19:56 +01:00
Joey de l'Arago
5d5915e49e Make support selector functional 
CURA-9793
 2022-11-29 09:19:56 +01:00
c.lamboo
84988a57e5 Update styling of infill slider 
CURA-9793
 2022-11-28 22:01:28 +01:00
Joey de l'Arago
631d6a15b0 Add extruder button bar that shows icons for each extruder in a horizontal row 💪 
Make ExtruderButton more generic by moving functionality out.

Remove background color from ToolbarButton and add that background color to the Toolbar.qml.

Fix Toolbar border being created by overlapping rectangles instead of using border

Add scaling options for ToolBarButtons icon

CURA-9793
 2022-11-28 15:55:55 +01:00
Joey de l'Arago
30d886cfcd Adjust setting first column width to match designs. 
CURA-9793
 2022-11-28 13:06:03 +01:00
Joey de l'Arago
4a59607d05 Switch to ColumnLayout 
Update part of Support selector to new layout.

CURA-9793
 2022-11-28 10:49:53 +01:00
Joey de l'Arago
ba958e1186 Changes by c.lamboo 2022-11-25 17:42:55 +01:00
Joey de l'Arago
eb13ac7f6b Getting setting section sized properly 
CURA-9793
 2022-11-25 17:42:50 +01:00
Joey de l'Arago
ac2e733ea6 Add Section Header and Section Setting item components. 
Upgrade Adhesion to use new components

CURA-9793
 2022-11-24 17:24:28 +01:00
Joey de l'Arago
a7dc1b24bc Rename RecommendedInfillDensitySelector.qml since it will now be a more generic Strength selector 
CURA-9793
 2022-11-24 16:42:46 +01:00
c.lamboo
e25048d88a Add width to intent tool tips 
CURA-9746
 2022-10-12 15:29:08 +02:00
Remco Burema
e9b268bc06
Review suggestion; best practices; javascript. 
done as part of CURA-9746

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
 2022-10-12 14:54:33 +02:00
Remco Burema
8db3f02a4f Re-add tooltips for intent profile selection in recommended. 
They where skipped over when transferring the radio bar to the current large button based setup.

CURA-9746
 2022-10-12 14:43:55 +02:00
joeydelarago
fd8d6498ee When changing to an intent with infillDensity > 100 in recommended settings the RecommendedInfillDensitySelector would set infillDensity=100. 
This is because the onValueChanged function checks if the slider has a different value from the settings and updates the settings if it does. The slider has a max value of 100, so when setting the sliders value to 1000 the slider would update to have a value of 100. This would then update the setting to value to 100.

The fix is as follows. When updating the slider value > 100 just ignore the first onValueChanged. Following onValueChanged, which are triggered by the user sliding the slider, will still trigger.

CURA-9488
 2022-08-10 16:45:16 +02:00
c.lamboo
efce84284e Update translation strings 
The profile name in the translation string was hard coded to be prepended before the actual string. Put this in the translation string as some languages may change the position of this part of the sentence.
 2022-07-15 10:29:56 +02:00
Jaime van Kessel
656a3dc707 Remove stray print 2022-07-11 16:02:17 +02:00