12 Commits

Author SHA1 Message Date
Jaime van Kessel
d7d7a7302d
Set defaultExtruderIndex to activeExtruderIndex
This doesn't fix the problem in it's entirety, but it does make the behavior
to be the same as it was in the previous releases

CURA-10342
2023-02-28 18:00:23 +01:00
c.lamboo
564fefa1c7 Fix updating value with "," instead of "." in reccomended mode
Fixed by correctly parsing dot in `SingleSettingTextField`.

CURA-9793
2022-12-13 11:46:06 +01:00
Joey de l'Arago
1e6184448c
Apply suggestions from code review
Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-12 11:44:21 +01:00
Joey de l'Arago
e6f4055df5 Remove part of hack for fixing extrudersCHanged signal at the wrong time.
Other things rely on the extruders changed signal so it is better to just emit it again at the correct time.

CURA-9793
2022-12-08 13:11:14 +01:00
Joey de l'Arago
82fd34f168 Fix same property value check.
CURA-9793
2022-12-08 09:56:36 +01:00
Joey de l'Arago
9a03094bfd Stop the text field from updating if the text has not changed. This was causing the custom mode text boxes to be updated instantly.
0.0 -delete-> 0. -instant update -> 0.0

 This is because the recommended mode text fields would update to "0." see that as a change from "0.0" and update the property. This triggered an update in the Custom mode textfield.

CURA-9793
2022-12-08 09:34:32 +01:00
Jelle Spijker
91170e0aef
Apply suggestions from code review 2022-12-08 07:43:57 +01:00
Joey de l'Arago
443252ae10 Use globalStackExtruderIds instead of extruderIds. extruderIds notifys change before the extruders change when doing a machine swap. Fixing this will take a long time so this is a workaround. If you are reading this 🙏 good luck fixing it 🙏
CURA-9793
2022-12-07 16:57:35 +01:00
Joey de l'Arago
ce5691c12d
Apply suggestions from code review
Co-authored-by: Jelle Spijker <j.spijker@ultimaker.com>
2022-12-05 14:42:35 +01:00
Joey de l'Arago
d7e1aa08ac Update the single setting components to optionally update all extruders when a setting is settable per extruder or limited to extruder.
This forces all extruders to have their settings updated but only displays the value from a single extruder.

CURA-9793
2022-12-05 11:32:24 +01:00
Joey de l'Arago
540d810293 The slider was not forcing its setting value to stay the same when changes were made in the "Advanced" menu. This is because the slider updating and setting updating functions were intertwined. I've seperated them so that the slider no longer interferes with changes to the setting.
The Shell thickness settings were not being read or set correctly. I fixed this by setting the value to all extruders and reading from extruder 1. This setting is not set per machine but for all extruders. Not sure why.

CURA-9793
2022-12-05 10:23:40 +01:00
Joey de l'Arago
dfb6c04d00 Add SingleSettingTextField.qml
Added a workaround for states of inheriting components. See comments for details.

CURA-9793
2022-12-02 11:48:50 +01:00