From f82afdcfb5af1aba01b45142cc6a6cba1187dbec Mon Sep 17 00:00:00 2001 From: "chunmao.guo" Date: Thu, 3 Nov 2022 09:28:19 +0800 Subject: [PATCH] FIX: dealloc player on destructor of wxMediaCtrl2 Change-Id: Ie8055dc6c0b861c2f9b0dcd86cf333fd68b3bf0f --- src/slic3r/GUI/wxMediaCtrl2.h | 2 ++ src/slic3r/GUI/wxMediaCtrl2.mm | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/src/slic3r/GUI/wxMediaCtrl2.h b/src/slic3r/GUI/wxMediaCtrl2.h index 44fc8f42c3..e5e1a007ae 100644 --- a/src/slic3r/GUI/wxMediaCtrl2.h +++ b/src/slic3r/GUI/wxMediaCtrl2.h @@ -17,6 +17,8 @@ class wxMediaCtrl2 : public wxWindow { public: wxMediaCtrl2(wxWindow * parent); + + ~wxMediaCtrl2(); void Load(wxURI url); diff --git a/src/slic3r/GUI/wxMediaCtrl2.mm b/src/slic3r/GUI/wxMediaCtrl2.mm index 9f6fa850d4..5d8431c90f 100644 --- a/src/slic3r/GUI/wxMediaCtrl2.mm +++ b/src/slic3r/GUI/wxMediaCtrl2.mm @@ -47,6 +47,12 @@ wxMediaCtrl2::wxMediaCtrl2(wxWindow * parent) create_player(); } +wxMediaCtrl2::~wxMediaCtrl2() +{ + BambuPlayer * player = (BambuPlayer *) m_player; + [player dealloc]; +} + void wxMediaCtrl2::create_player() { auto module = Slic3r::NetworkAgent::get_bambu_source_entry();