GitHub-Proxy/PrusaSlicer
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/prusa3d/PrusaSlicer.git synced 2025-08-14 14:35:54 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

SPE-2639: Ensure no scarf seam is generated when a point fail to project to the perimeter

Browse Source
This commit is contained in:
Martin Šach 2025-01-13 17:34:14 +01:00 committed by Lukas Matena
parent f3d736ab63
commit 02779e211f
1 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/libslic3r/GCode/SeamPlacer.cpp
View File

@ -312,11 +312,15 @@ boost::variant<Point, Scarf::Scarf> finalize_seam_position(
} }
if (loop.role() != ExtrusionRole::Perimeter) { // Outter perimeter if (loop.role() != ExtrusionRole::Perimeter) { // Outter perimeter
scarf.start_point = scaled(project_to_extrusion_loop( const Vec2d start_point_candidate{project_to_extrusion_loop(
to_seam_choice(*outter_scarf_start_point, perimeter), to_seam_choice(*outter_scarf_start_point, perimeter),
perimeter, perimeter,
distancer distancer
).second); ).second};
if ((start_point_candidate - outter_scarf_start_point->point).norm() > 5.0) {
return scaled(loop_point);
}
scarf.start_point = scaled(start_point_candidate);
scarf.end_point = scaled(loop_point); scarf.end_point = scaled(loop_point);
scarf.end_point_previous_index = loop_line_index; scarf.end_point_previous_index = loop_line_index;
return scarf; return scarf;
@ -359,18 +363,25 @@ boost::variant<Point, Scarf::Scarf> finalize_seam_position(
if (!inner_scarf_start_point) { if (!inner_scarf_start_point) {
return scaled(inner_scarf_end_point.point); return scaled(inner_scarf_end_point.point);
} }
const Vec2d start_point_candidate{project_to_extrusion_loop(
scarf.start_point = scaled(project_to_extrusion_loop(
to_seam_choice(*inner_scarf_start_point, perimeter), to_seam_choice(*inner_scarf_start_point, perimeter),
perimeter, perimeter,
distancer distancer
).second); ).second};
if ((start_point_candidate - inner_scarf_start_point->point).norm() > 5.0) {
return scaled(loop_point);
}
scarf.start_point = scaled(start_point_candidate);
const auto [end_point_previous_index, end_point]{project_to_extrusion_loop( const auto [end_point_previous_index, end_point]{project_to_extrusion_loop(
to_seam_choice(inner_scarf_end_point, perimeter), to_seam_choice(inner_scarf_end_point, perimeter),
perimeter, perimeter,
distancer distancer
)}; )};
if ((end_point - inner_scarf_end_point.point).norm() > 5.0) {
return scaled(loop_point);
}
scarf.end_point = scaled(end_point); scarf.end_point = scaled(end_point);
scarf.end_point_previous_index = end_point_previous_index; scarf.end_point_previous_index = end_point_previous_index;
return scarf; return scarf;