GitHub-Proxy/PrusaSlicer
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/prusa3d/PrusaSlicer.git synced 2025-08-04 03:00:37 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix undefined behaviour in maybe change instance

Browse Source
This commit is contained in:
Martin Šach 2024-03-04 18:15:32 +01:00 committed by Lukas Matena
parent 8119bb2925
commit 08fa362abd
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/libslic3r/GCode/LabelObjects.cpp
View File

@ -138,7 +138,10 @@ std::string LabelObjects::maybe_stop_instance() {
std::string LabelObjects::maybe_change_instance() { std::string LabelObjects::maybe_change_instance() {
if (last_operation_instance != current_instance) { if (last_operation_instance != current_instance) {
return this->maybe_stop_instance() + this->maybe_start_instance(); const std::string stop_instance_gcode{this->maybe_stop_instance()};
// Be carefull with refactoring: this->maybe_stop_instance() + this->maybe_start_instance()
// may not be evaluated in order. The order is indeed undefined!
return stop_instance_gcode + this->maybe_start_instance();
} }
return ""; return "";
} }